From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5EAC4167D for ; Tue, 12 Dec 2023 12:26:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 465DC6B02C2; Tue, 12 Dec 2023 07:26:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 416426B02C3; Tue, 12 Dec 2023 07:26:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B8896B02C4; Tue, 12 Dec 2023 07:26:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1CF226B02C2 for ; Tue, 12 Dec 2023 07:26:43 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E786FA1E6D for ; Tue, 12 Dec 2023 12:26:42 +0000 (UTC) X-FDA: 81558089844.27.AD44C1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 8E94D40014 for ; Tue, 12 Dec 2023 12:26:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OANrcpkT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702384000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fDP3FXwDxg0e6Hl2R7PIsXLl/CSKl+eIMo7Jo4/Is8Q=; b=mfVwfHw49299wepraTuB8U9vjyT1KR5kLSsdvC7MhTr5/L2Q1k8Ho2bjM585s9Z54CkUzE vff095SZ1W2Co5Pg5ZaY2NZiTjBS5xI9+h/2V/ucio3QGIsZWB/FZoq48HJISSz6+Yml3I 6GRHrn6kjBtJc8ElCQXmhMJgJ0K/1s8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OANrcpkT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702384000; a=rsa-sha256; cv=none; b=YG6Jrj3IQl/1KRRJAf7E9uTHhEeGWRm+mmulu0tNe+vXb6I92DOs6NH2fBsegRmrl/57HH 6zmfy1/zTjL6R52tVaEKAZG/V5VjTRWkBrEaYjuL6HIGFnLT3Wd65LTMwWFWmyvDQWrKWL Gptjn2dCYDeg2aHxIq42F0v9nYQ7BRI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702383999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fDP3FXwDxg0e6Hl2R7PIsXLl/CSKl+eIMo7Jo4/Is8Q=; b=OANrcpkTBzx41r2Uz8w/a1s+0ffADnEJsC7UQIFDdJgPzgt0Sb25YI3Amgs5+9k+5W9YV9 Zp2OXuD32pWGxx7CR6yD9gFtOn8Tb02Gp//lsPrI5+xfSqUP133lBmfjsIJjRD+1dNiS5w 5qLSc5KAo8TLrqZgB+A+0THgxI2x+b4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-K_2A-OicM_mkadQ__H-6HA-1; Tue, 12 Dec 2023 07:26:38 -0500 X-MC-Unique: K_2A-OicM_mkadQ__H-6HA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-332ee20a40fso4496980f8f.3 for ; Tue, 12 Dec 2023 04:26:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702383997; x=1702988797; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fDP3FXwDxg0e6Hl2R7PIsXLl/CSKl+eIMo7Jo4/Is8Q=; b=agqulAeiAlhkwfEnWfS9UCI4LntcIfpLImVnCe3n3IgvaZ9f/7WORaxViuIIhx4VUo 7Otssre4WwzsCbbuBTDtZW5spG7Ca96MO6OR0vk4YAb4JIXXzijhU/A04q2rOtEvUJst AT3qj8qY2o0vE300TdVWRudGRW++on1OE3jdbCuerO3ILV7jmXcX/kpRXUaXBKClfNG0 +87CGOj1mhmDeY+vzhaetTiWtkfi/bZMS/QItn1PGwvwHkkvuyuVe5wJZ8hePnYBZ26i amE3D8itVjihGzqtDblXla3iBkEm/WC4Pydw4mi50Fug5Jr6/tOSUncGIzsh8quuGIRb hLgg== X-Gm-Message-State: AOJu0YwYNB4LYkM2agDX2GeSXS4mQm0BF+ZsyGmibqklXqiAlbyLDYMk uPOjJ+mKBm6eWCCCG3L6mGa+edOvd5+s+UgGGtmpmpHe7xrjGR5E9DLDsLnuK/zLjxFSeo7jbKZ OSK6SVzlEiV4XF+B+RYc= X-Received: by 2002:adf:e8c5:0:b0:336:1d06:ce40 with SMTP id k5-20020adfe8c5000000b003361d06ce40mr2207440wrn.43.1702383997371; Tue, 12 Dec 2023 04:26:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMu21rWfMpbhua9h8rJicLGJH+qz+90CLcznY8ld3LJKVAmGJCrj21caZtF88mnPRcf/u0OA== X-Received: by 2002:adf:e8c5:0:b0:336:1d06:ce40 with SMTP id k5-20020adfe8c5000000b003361d06ce40mr2207430wrn.43.1702383997002; Tue, 12 Dec 2023 04:26:37 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id c15-20020adfe74f000000b0033335644478sm10742219wrn.114.2023.12.12.04.26.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 04:26:36 -0800 (PST) Message-ID: <02d6d72a-334c-40c0-8490-b941d798d2dc@redhat.com> Date: Tue, 12 Dec 2023 13:26:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] mm: Simplify the assertions in unuse_pte() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20231211162214.2146080-1-willy@infradead.org> <20231211162214.2146080-3-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231211162214.2146080-3-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8E94D40014 X-Stat-Signature: tgefxjk5adkbasynshxcmnh9hdfuqum8 X-HE-Tag: 1702384000-26471 X-HE-Meta: U2FsdGVkX189KWIZOsa1aLo4TYxvkxqIa2B2JwPdmqiy61gcnVhh1JwzZ0YfWY6rBjddQ9qi7C+3I3+u+lpa8sCjQczG7WQuNEccJ9pptfSHiV8gn6RvYWcX42BBL86iZr8Gu8rQ1P4W9Sstrf9dS3VgAKTbI91HPN9jBbC4tftbfErL6iynh5rEue6maqFVl/nlN7d1y4hf/4/DUY8N952J2NrGyEo6qizTjeYEASB/aXoLHCIsHTSFJmUs11WMvL27qeotXBdImefnWdjLX5VpMLm5RXhFfjd8XtWwMpJHAD9v3mHQqwsVcfCWRZqEDB7CicdaTelfE9+PjbLYpR/ilRohZAmVuhDNzHMEz4qxIxvh6Acnu4igZtIXKyVQ3ZojyrDuSQu5tm2ZZ2EJL29IhogXJQuamGZJcDRmSSSqr1Lm0pFoLPwoKxO7JmTvliUlh2ywNpKFnk+ob7a8cdlZOjEY8dXX9g3jvj+sWy1l2aFlZzv9mhHJl9IYcx9PfpqYFFMDcRQnPnwVtDG7kkTG/PKwsqd2JJokyNok2gwBXigRbxGNM6z62IMi4mo5YhL5YLhzm1IDIijdEwz+SxTao/FYXX3dVgj7O3EHPq6yOYe7xzgYMF6T2vlOHBTfxvOIPCJpXRdKGzMRWUHypJfF2ExxnWS0PWiYsZNG1bwwV8NBc6U23RBy8+u/Z9Nd7eSDBsWuBkYYeG74QxM64vy8ZH/N3caRo5zs3HkmKRPPwmTqsDtpFnZD7MhEyDTLLV8j0oGDA1hnu9SbLMUavmO8bLgEaTy2hYjagFS311g78kYFbqf328l5Ot4Y9eBKYolvWrCdrCVGRkPP0NdlWDkTcFc7wV1qkBy/nFmkaT8Snj1dg+Gmxg7AhXuiHVb9BXUCGNoLdRgla3vwtp++4MF7UNGfWUpwSLQ/I/x69oyugjwIGDli5zO4pV5Zpl5qIVEnlDKs72FcSPMHge1 5u37GTaQ VxmQozxIzkI/9YF9YvM04bewDtEZBYzMSwslsgOuocecRa1sxiOzj4EVO0l+qJOg1bkKDEmvPRekl5Fnt/wCUpRdu7GM3zpN+hVFQA3CNUG4Gf0yDm4bYGIAKRR8UJezytgRHvQ3o0jEGh9KHYPyOkX3VXT6v2qwGSf3Mhq9Vm89san511yxx3G0EdGQC4uNmP0pnmAGSW0P22BzUxFbX8SjIPIGwGQh1N/E8fVSn/661ngoe5e3Lkw5JBqJokgLC5t6cw4uyRHR86Cpm7AKZoEQ3jwPm3Khb03q7UQa/VT6m7Tx10zV8EA9F7V1eR0imHD10i/LglOv3pDvXPBLzixFuwN5b0yjZNQeXribOlMA24YCmoy4zT3T4fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.035214, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.12.23 17:22, Matthew Wilcox (Oracle) wrote: > We should only see anon folios in this function (and there are many > assumptions of that already), so we can simplify these two assertions. If we swapped in a fresh page, it is not PageAnon before we do the page_add_anon_rmap() call. So I'm pretty sure this is wrong. [I have plans of moving the "turn into anon folio" out of page_add_anon_rmap(), it will require teaching page_add_new_anon_rmap() about RMAP_EXCLUSIVE] -- Cheers, David / dhildenb