From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72123C0219B for ; Tue, 11 Feb 2025 18:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A0096B007B; Tue, 11 Feb 2025 13:49:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 050666B0082; Tue, 11 Feb 2025 13:49:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59AA6B0085; Tue, 11 Feb 2025 13:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C82D56B007B for ; Tue, 11 Feb 2025 13:49:02 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3F15CB0DC4 for ; Tue, 11 Feb 2025 18:49:02 +0000 (UTC) X-FDA: 83108550924.25.25CFF73 Received: from 008.lax.mailroute.net (008.lax.mailroute.net [199.89.1.11]) by imf30.hostedemail.com (Postfix) with ESMTP id 1CE6180012 for ; Tue, 11 Feb 2025 18:48:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b="W7Qi/NV0"; spf=pass (imf30.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.11 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739299740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c6L8zUH86MvTF1+XsPn+yHHz6hoj4ydZJlFliOWt6lM=; b=R4NSMbWX44mGjFwY3DqkANrHLmFo3MYSlTsr7UYQgR+T4Bma1mrmG2/jjiCzjw3OjQqX1D sKZvwnWLwlmbwmRszPxznhgtK9IKwsZ5leSbO4VswP5v2emJQkU1Va6YlVy6xDlsYa7hMY OjGoqNxm13SievPfGALGdhfJezGs74I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b="W7Qi/NV0"; spf=pass (imf30.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.11 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739299740; a=rsa-sha256; cv=none; b=BRtuCJbJof8FgXTNmO6cf8Jw/lZPiqt90otbOKxkqc9MqPlAlA5YotTm6jUlqGc/BvPXLD hiBSXNQ9JArqpuTzKIe8EVKVPGdn9WX1V2ncFRK8YsW3tSNcsxLSZf8GhplfiU1lTa4eaz /d/c4UxTquo6o4q77BMl/uk+DnW9jRM= Received: from localhost (localhost [127.0.0.1]) by 008.lax.mailroute.net (Postfix) with ESMTP id 4Ysr7t65RRz6Cl0k0; Tue, 11 Feb 2025 18:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1739299733; x=1741891734; bh=c6L8zUH86MvTF1+XsPn+yHHz 6hoj4ydZJlFliOWt6lM=; b=W7Qi/NV0gYq9/nzQ96QQx3AnCvoKsAW1sG2H10ke hargjArMFwsNFlLbi+fEJfFo5yBDfHCOIN3wiTWHJo+ry8+RXXTGVot1IfXznb0M L8lWbhilXwGhwIa+NwOP3BoUGOAHDLG6DOQ1xt2REiFWcJnpVG4/dyk3Z3g9u6AZ JpvE+/5usq9mag4xqDLgcSQgHOGEyJiUr9DIgG1TRng1UpmFbn4IpJKsVZXwcFRK W83EuIl76H7O+ZwyYszukGbixhCuvvkJ1Qu4hB5p0Z4568xHvQO6qsWsXSw3Whdm cN2EQJCOsw0/9m6dhV0N3dDRmuvklzJ2/ZatH1PcrdDaFg== X-Virus-Scanned: by MailRoute Received: from 008.lax.mailroute.net ([127.0.0.1]) by localhost (008.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id tpU7bE7Eg6PC; Tue, 11 Feb 2025 18:48:53 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 008.lax.mailroute.net (Postfix) with ESMTPSA id 4Ysr7h6CYTz6ClRNx; Tue, 11 Feb 2025 18:48:48 +0000 (UTC) Message-ID: <02cd4d8e-9451-4785-9664-0d680d5e82e3@acm.org> Date: Tue, 11 Feb 2025 10:48:47 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings To: Vlastimil Babka , Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner , Linus Torvalds References: <20250131191231.1370466-1-bvanassche@acm.org> <8b018dd9-37bc-468b-b992-2731c0270c12@suse.cz> Content-Language: en-US From: Bart Van Assche In-Reply-To: <8b018dd9-37bc-468b-b992-2731c0270c12@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1CE6180012 X-Stat-Signature: kidm59cezdj3ik7d7cft61rxoxdrpc4t X-HE-Tag: 1739299739-897740 X-HE-Meta: U2FsdGVkX1/bmdPoptAhd6N66yElejsseA57mxlFk54jcds+zS4CwRmtDpYjvheCl7fFHgudlzHD6pr2HV9utB4Jf5cuasi6GHEQm51yA+cU15/5Ohed7tcJipVEKe5vsbfRKcptqCQ1q7/+Hez2bN3l3AsN4SIwoK/DA9tdPwsrgLkaHCbi78OxaF9GKOfqrPIfBBsemb85+ZZFvkcEZnQcF4k2867CFxZEcqDVapIlIdA03Pnnyo/jRTQ+iwiYg0pkyy+NOjeTIsfZTy401leY0nVGBHDMMsJ8+HVODq+cwJmbUwMfSg8lwkFH41hquUs5AgXgbNTQ7Cevs/4SJ872Lrl7jH25iE/G9IXwksxzg85FrAptO9QaEGgC277HBeSEhRaqapxuooxs/2dvLNKIAv8EXX8XBdNH+KT+UtunTVMjIgrKlJnQChn0lPBKlN8YD9LGgUhfR7GGUgqTCGgP2LZhWyjm6c4YzobbHmf+kQg1p4HrF/drhjgVq0/RibOgcLo9vP/KvAkpDQZcTldw4p1JagMnF3vmSBE5Veq4TIct3cwLuQ02jKC2OWIE/0HCGjdaN3dSd7tcoBaGIjjbYK1v//SADwF1f5sbGJByXcBXFNEZACuUugpK3+ISBh2Znq3mh8417E+GOOQnCVMkiXlP7k/ZlI0mzYECCeijmvql2jp59Fk67ev4X/bpdhbqLEl5KgeHkcVoDxu7KYdQaaIQcxdJ1ZovmJbjQAlfEgsc0Td7zwgz1j0hQRCkgUf2nHSW0AG0CZjYqSUmowEjOlbHxj8rS/PWNaqGZQtNlyczO1noSCGKSyY+dZ2HD7sdYg8YqLUYb8YfuaFNUEO+SBrJID71vfvkLeObP/zWM9HxVgEsjb2ymKjOg4eNj0swhwPaj98/2AHA5g7eGtwTAZVNZJKbL261mfqWFCsssyORnUHf5DQW0CpSP/ega0paHB6Knd0gdvfGaXo /YzBuG9Y 6asV2oMvuOad4nDJiRZ+w35g32V9j4Tqf76qrp0UaKc/VzIryFI2UCYJfjRRMQAlm//oIRUi4pBULR0NtooHVnNpjfakjK4wl0k3z9Q3cDizm5fmzBjwNL06tB6dGMn6I2Utq7ts3Tm/W5XBsjeRaA9q2B8dRs2uLxRpo+tKWtbJxSwOPkfInd0EBPIErW9mJFRGXvx9IfuGzkTlkBKaYF5DbAOYH5TfW8wg0Gh/j8vc3CTqjpJTaGKRdCYnNUMvN5Crh+3SLslWTbGjYNtGt7EG8tdWKz7VaC4cALmkm5GDpqTWHdFWoKNLTMWP+GyNk+rgCKENYS9a4jjvKEv9M80T0k/ZY9waUubTRMqotjG5b5xQa9PTeEBKIew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/11/25 6:34 AM, Vlastimil Babka wrote: > On 2/8/25 11:28, Matthew Wilcox wrote: >> this patch was NAKed last year >> >> https://lore.kernel.org/all/ZnXC5Xa4R0Mp7FCB@casper.infradead.org/ I wasn't Cc-ed on that email thread so I hadn't seen it yet. > With the warning now in W=2, want to submit the revert of above, Bart? OK, I will submit a revert of commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning"). I see that Nathan's change already made it in Linus' tree as commit 8f6629c004b1 ("kbuild: Move -Wenum-enum-conversion to W=2"). Thanks, Bart.