From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABAA6C4829E for ; Thu, 15 Feb 2024 21:44:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BB208D0007; Thu, 15 Feb 2024 16:44:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 243D58D0006; Thu, 15 Feb 2024 16:44:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070048D0007; Thu, 15 Feb 2024 16:44:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E57188D0006 for ; Thu, 15 Feb 2024 16:44:08 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 94C0414057B for ; Thu, 15 Feb 2024 21:44:08 +0000 (UTC) X-FDA: 81795366576.19.ED002CD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 282111C001A for ; Thu, 15 Feb 2024 21:44:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ay4ravC8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sPqC4gP5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ay4ravC8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sPqC4gP5; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708033446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sQY+F3nMlxstoB6O6HK9gnIcEp2qVMn7wy1cyDkxwTk=; b=a9VEPnyTa1fh/WsVQP8tGqJCw/6IjyiV7KN6ahBu1rZHOaomierS3psW+DR8ut+gBztNIr i7uwu9VG+u1II2rHzLYsuqMK3k4OJI2bOrjHXkVvuqMLO4e41l3X7Pym+lFY3TnHNahOTk +n0Oiu0tVZ06ySkG6pz3FLEAsNW1dH4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ay4ravC8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sPqC4gP5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ay4ravC8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sPqC4gP5; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708033446; a=rsa-sha256; cv=none; b=rJKIi0nMHPCqEFheQnmVCtRHvRB3eYFm/MG4HSqoazgIGbgF7IENluqAs+/+Hqhp2IBbQu AGOhMdh01puZaoXebCZhuy84EoOBESgLNIYGK5x4b0Ms7h7c6WC1ZqF7gmj4UCBNoSOhju kdRBEbSOsUrlgc44bD0irtd3YUAVyno= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 632D9220D6; Thu, 15 Feb 2024 21:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708033444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQY+F3nMlxstoB6O6HK9gnIcEp2qVMn7wy1cyDkxwTk=; b=Ay4ravC8tz3DhfoYvoB3LNDbjnAF0ZXlS655OZ3Fd0H/F55bSQDiu48paFSjQX0cKW5AgT 5iyUw/Htn37YNdgjBvwRJyX2Sd2Bg+9UTep/WDJ7H+xA2xGgkyFZSjqIN68pSEw4kJzoMJ dErOJCGuqDpXXWQK5IIwVDOJQzk8wZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708033444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQY+F3nMlxstoB6O6HK9gnIcEp2qVMn7wy1cyDkxwTk=; b=sPqC4gP5gNHBPrt4HC5l6ZN5X9CSu4w9/m7c2WnUTrBqWbrv4PL9ApcsRSztcRjH4lhvGx e22tnmK9X77zK6AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708033444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQY+F3nMlxstoB6O6HK9gnIcEp2qVMn7wy1cyDkxwTk=; b=Ay4ravC8tz3DhfoYvoB3LNDbjnAF0ZXlS655OZ3Fd0H/F55bSQDiu48paFSjQX0cKW5AgT 5iyUw/Htn37YNdgjBvwRJyX2Sd2Bg+9UTep/WDJ7H+xA2xGgkyFZSjqIN68pSEw4kJzoMJ dErOJCGuqDpXXWQK5IIwVDOJQzk8wZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708033444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQY+F3nMlxstoB6O6HK9gnIcEp2qVMn7wy1cyDkxwTk=; b=sPqC4gP5gNHBPrt4HC5l6ZN5X9CSu4w9/m7c2WnUTrBqWbrv4PL9ApcsRSztcRjH4lhvGx e22tnmK9X77zK6AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6209F13A53; Thu, 15 Feb 2024 21:44:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +AxGF6OFzmUvTQAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 21:44:03 +0000 Message-ID: <02cb04cd-0d8d-4948-b3ef-036160c52e64@suse.cz> Date: Thu, 15 Feb 2024 22:44:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/35] mm: prevent slabobj_ext allocations for slabobj_ext and kmem_cache objects Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-9-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240212213922.783301-9-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 282111C001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: tps54zbuzm18zoxcn56sumsqutenaunb X-HE-Tag: 1708033445-251197 X-HE-Meta: U2FsdGVkX1+3qvRNmO2XAulPUAh0JecD5YDWDWrS4zSlvgTxy1iV9yDX3KFHACm668xYOtp4avdblWqZ76h6ZHM0yrNHtz0TnSrJ223zqi+HEHqtdRh/akfRIkujWrEZRAScaSAE7dNPmas2PERfARNmJIWbCxCnpg1XpI0ho1B1mJzB3tz5UScSa0BSF7rSPPvtmncYXTudryVXnRf4Gyu4qk12cuwjmKZqvuDz9reKS7QiQYoSBN4oBkxRi1zC+TpSma8+ErhcD9ifHgCs1ooDAHrUdZg/K3kdsGB3IJaZwkvejWai1vRMk3fRDsJbb2FH31Q9tl1ENf3Rfd56C7x1FWfXlaG+KXOytQ+xFqaF+K1OylF/pQKOcrD7o7i01Op5qs1DiRm+OVs/pfLgqXqTbNeHcKRsE2D/O8c9nAA5ZTj99DNMqd6HQqnlIH6ClUXI57hzCeWPBMeb0sg1Qw/cy+UEZWUT0NF8mIHp5tk71C6gjZcKE7VtOzM877XinPo5AbhU8yYt9EPKftZcM/cCUb08vbNXqg/AsOLgusTpmb/w1kaAb8bJaXmH3k7PbP4zzQ0k3xn8GTC9tzVkST9exPPXFZ05sJQPMuhhJeInNCC0+Hv5RAuqZmeLbQk4FC+ixdbVcwumfgmxqXyPH+qviRNviLm2EC5hHRuyEMTW7ZSbU3rtI7p6RMqPWgCPNxxyV4XxXYufm78FbwKzmRecQkQ5BL50/6ig4pUdUWSQRbcjOBSqUpGepCg9GdFSUVAyEJnfLCoTrFoc4OvJiVKBL1xyiqZ9a2T7H1B7456Ks0pxffNX4XGZmhp39dmeDcZHFMlK0H1AvldzoXoOcKN197ZG8qTAyBFZcMqTXUYS7/TwARfzW95w40P/+noyk4AjVJakkJSS8oDgznTmhFYOyrZyfT132jj/4tHSFAw6lfhU/5tiBusEWcFHyVmBXJDP07oWvPnoctOLZik gET+MyLl kq7f9eFpy5W+TiNreXMTHv0X6RqtTs+3Qz/7qYgjCdtbXbK/6Q+4G+ccaCzn5IMFq+SHel26mKcDMbp0uo0/FWS/UnAOhnnPBNOs7qKgZwWqg8Y5pFRIaiGpiPxvdgJNJs1FSRatwF3eXHc2maKyn/WC4jpy8qeSIXmhgIyU9neerRLIM7R+kAFFcsHOfJ7gpX2k7fsgsDyo+VHDCTiStq0OABmdWeGEujw5lJCNtu0Zpbdlh7FahWvu3gKFmlS3+RM2o8myJFEbDxx3b9gTo18xbEWOvxxYFIm3C4yxMAgCnRDXAOM3b5uyK0OQgVKm3yULGYoU6od8WCaeeA8/r0/bwShWlIjn3QnNQHgwSrZuQbMcfpuQrvUo2zO0Zj1oJC2JrCpNYes8RVcLgHqxYUrpBjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/24 22:38, Suren Baghdasaryan wrote: > Use __GFP_NO_OBJ_EXT to prevent recursions when allocating slabobj_ext > objects. Also prevent slabobj_ext allocations for kmem_cache objects. > > Signed-off-by: Suren Baghdasaryan > --- > mm/slab.h | 6 ++++++ > mm/slab_common.c | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/mm/slab.h b/mm/slab.h > index 436a126486b5..f4ff635091e4 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -589,6 +589,12 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > if (!need_slab_obj_ext()) > return NULL; > > + if (s->flags & SLAB_NO_OBJ_EXT) > + return NULL; > + > + if (flags & __GFP_NO_OBJ_EXT) > + return NULL; Since we agreed to postpone this function, when it appears later it can have those in. > slab = virt_to_slab(p); > if (!slab_obj_exts(slab) && > WARN(alloc_slab_obj_exts(slab, s, flags, false), > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 6bfa1810da5e..83fec2dd2e2d 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -218,6 +218,8 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > void *vec; > > gfp &= ~OBJCGS_CLEAR_MASK; > + /* Prevent recursive extension vector allocation */ > + gfp |= __GFP_NO_OBJ_EXT; And this could become part of 6/35 mm: introduce __GFP_NO_OBJ_EXT ... ? > vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > slab_nid(slab)); > if (!vec)