linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Huan Yang <link@vivo.com>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Brendan Jackman <jackmanb@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/1] Introduce vmap_file()
Date: Mon, 31 Mar 2025 10:05:53 +0800	[thread overview]
Message-ID: <02ba63ed-ef1c-426d-b469-09878c5f03d7@vivo.com> (raw)
In-Reply-To: <20250328211349.845857-1-vishal.moola@gmail.com>

HI Vishal,

在 2025/3/29 05:13, Vishal Moola (Oracle) 写道:
> Currently, users have to call vmap() or vmap_pfn() to map pages to
> kernel virtual space. vmap_pfn() is for special pages (i.e. pfns
> without struct page). vmap() handles normal pages.
>
> With large folios, we may want to map ranges that only span
> part of a folio (i.e. mapping half of a 2Mb folio).
> vmap_file() will allow us to do so.

You mention vmap_file can support range folio vmap, but when I look code, I can't figure out

how to use, maybe I missed something? :)

And this API still aim to file vmap, Maybe not suitable for the problem I mentioned in:

https://lore.kernel.org/lkml/20250312061513.1126496-1-link@vivo.com/

Thanks,
Huan Yang

>   
> Create a function, vmap_file(), to map a specified range of a given
> file to kernel virtual space. vmap_file() is an in-kernel equivalent
> to mmap(), and can be useful for filesystems.
>
> ---
> v2:
>    - Reword cover letter to provide a clearer overview of the current
>    vmalloc APIs, and usefulness of vmap_file()
>    - EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL()
>    - Provide support to partially map file folios
>    - Demote this to RFC while we look for users
> --
> I don't have a user for this function right now, but it will be
> useful as users start converting to using large folios. I'm just
> putting it out here for anyone that may find a use for it.
>
> This seems like the sensible way to implement it, but I'm open
> to tweaking the functions semantics.
>
> I've Cc-ed a couple people that mentioned they might be interested
> in using it.
>
> Vishal Moola (Oracle) (1):
>    mm/vmalloc: Introduce vmap_file()
>
>   include/linux/vmalloc.h |   2 +
>   mm/vmalloc.c            | 113 ++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 115 insertions(+)
>


  parent reply	other threads:[~2025-03-31 16:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 21:13 Vishal Moola (Oracle)
2025-03-28 21:13 ` [RFC PATCH v2 1/1] mm/vmalloc: " Vishal Moola (Oracle)
2025-03-31  2:05 ` Huan Yang [this message]
2025-04-01  1:50   ` [RFC PATCH v2 0/1] " Vishal Moola (Oracle)
2025-04-01  2:21     ` Huan Yang
2025-04-01  3:19       ` Vishal Moola (Oracle)
2025-04-01  6:08         ` Huan Yang
2025-04-01  9:47           ` Uladzislau Rezki
2025-04-01 11:09             ` Huan Yang
2025-04-01 16:43               ` Uladzislau Rezki
2025-04-01 17:31           ` Vishal Moola (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02ba63ed-ef1c-426d-b469-09878c5f03d7@vivo.com \
    --to=link@vivo.com \
    --cc=akpm@linux-foundation.org \
    --cc=jackmanb@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vishal.moola@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox