From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109FBC433F5 for ; Mon, 28 Mar 2022 14:16:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E3778D0002; Mon, 28 Mar 2022 10:16:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8923D8D0001; Mon, 28 Mar 2022 10:16:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A448D0002; Mon, 28 Mar 2022 10:16:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 65A8B8D0001 for ; Mon, 28 Mar 2022 10:16:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1D210182693D8 for ; Mon, 28 Mar 2022 14:16:52 +0000 (UTC) X-FDA: 79293996264.18.81C9586 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 1221C80036 for ; Mon, 28 Mar 2022 14:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648477010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B4R1I/hCcAQyQZ62VKidYDJvIMBja7RGHE6ljlNOv9w=; b=aPsD2ZEtRIX28uns6XTmIRMx3JrIInO2N/eRtXPYtjlhSJQRqIx8z1zAYm6fLaFoB73zMi al3UoQyATzTa92w+4aJBrPn4G40euMBT/qDFovbL9Eux22GsTKLZAIky+lk27oPnXl1Y7k eBlJVBE7M09RGQBO4+tPegljkMdRqvY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-397-pVdbAVBoMp-7i_CChTRiDg-1; Mon, 28 Mar 2022 10:16:47 -0400 X-MC-Unique: pVdbAVBoMp-7i_CChTRiDg-1 Received: by mail-wr1-f70.google.com with SMTP id q4-20020adfc504000000b00203e15159e8so4353772wrf.6 for ; Mon, 28 Mar 2022 07:16:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=B4R1I/hCcAQyQZ62VKidYDJvIMBja7RGHE6ljlNOv9w=; b=0w936tMCoPu12TDOeY/ZyRKAQAL8JH0XGB8PfB6l6JCg3R6300r69aaRwIjUFTXWXJ 441IV6zB365bs0KibRyiJAMM70G35R/9QAhXDOqSNDAKG5x4sA4I6Szl8rYaqLALx/IB 43b+Uu6dmHizxs3vpm+3TVJ6EW3Hj6m/fDDcGQhx8uC+9g/Mz/iEHfnkwcfTqMOhNIyx Fk9cYYih9FWDDh4bdNO53weWX1McCJhpXqWnKLLzBbL+Lu+crLtak9GSzp+U25iMsvSe pVnDuOF76nB71boHt9FTvSWEEuD+uH4hP8/MCaV3nrhqi6530HYPf6hyHPyznpOOtlqf ySug== X-Gm-Message-State: AOAM532aYQEEsYsTNvpaR/ehNA2a6Mekgd7nlxKbngLdf781JgDQtcSG TB2rcBqH1oi6B0cex4ItcAiufXVcrnV32LaCUNooDGTJQBuvGwivaN0FKr9FY5gto3ySDCx+vfW rxDeZxhV1s34= X-Received: by 2002:a05:600c:4f10:b0:38c:ae36:d305 with SMTP id l16-20020a05600c4f1000b0038cae36d305mr36616784wmq.34.1648477005960; Mon, 28 Mar 2022 07:16:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM/wkx2pd1yQoAPHFS3vBpvM7gEfUh55GK9MMKNDNabHDPAdxAyQh1rCMVvya/5AbYTk3taw== X-Received: by 2002:a05:600c:4f10:b0:38c:ae36:d305 with SMTP id l16-20020a05600c4f1000b0038cae36d305mr36616748wmq.34.1648477005630; Mon, 28 Mar 2022 07:16:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:2200:50d1:ff5c:5927:203a? (p200300cbc704220050d1ff5c5927203a.dip0.t-ipconnect.de. [2003:cb:c704:2200:50d1:ff5c:5927:203a]) by smtp.gmail.com with ESMTPSA id 3-20020a5d47a3000000b0020412ba45f6sm14367828wrb.8.2022.03.28.07.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 07:16:40 -0700 (PDT) Message-ID: <02a7f297-b9fd-1c32-b4ea-92779dfe56ab@redhat.com> Date: Mon, 28 Mar 2022 16:16:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/memcg: remove unneeded nr_scanned To: Miaohe Lin , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220328114144.53389-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220328114144.53389-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aPsD2ZEt; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1221C80036 X-Stat-Signature: qu5c95c1twxcrmy66eur6wg1x3pd59cx X-HE-Tag: 1648477010-865605 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.03.22 13:41, Miaohe Lin wrote: > The local variable nr_scanned is unneeded as mem_cgroup_soft_reclaim always > does *total_scanned += nr_scanned. So we can pass total_scanned directly to > the mem_cgroup_soft_reclaim to simplify the code and save some cpu cycles > of adding nr_scanned to total_scanned. > > Signed-off-by: Miaohe Lin > --- > mm/memcontrol.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b686ec4f42c6..79341365ec90 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3384,7 +3384,6 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > int loop = 0; > struct mem_cgroup_tree_per_node *mctz; > unsigned long excess; > - unsigned long nr_scanned; > > if (order > 0) > return 0; > @@ -3412,11 +3411,9 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > if (!mz) > break; > > - nr_scanned = 0; > reclaimed = mem_cgroup_soft_reclaim(mz->memcg, pgdat, > - gfp_mask, &nr_scanned); > + gfp_mask, total_scanned); > nr_reclaimed += reclaimed; > - *total_scanned += nr_scanned; > spin_lock_irq(&mctz->lock); > __mem_cgroup_remove_exceeded(mz, mctz); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb