From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7EFC4829A for ; Mon, 5 Feb 2024 04:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A7BF6B0071; Sun, 4 Feb 2024 23:23:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 257866B0072; Sun, 4 Feb 2024 23:23:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 145F96B0074; Sun, 4 Feb 2024 23:23:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 048C26B0071 for ; Sun, 4 Feb 2024 23:23:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6BEBC140859 for ; Mon, 5 Feb 2024 04:23:51 +0000 (UTC) X-FDA: 81756457062.12.E803E0C Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by imf25.hostedemail.com (Postfix) with ESMTP id 3EFC8A0003 for ; Mon, 5 Feb 2024 04:23:47 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b="B 6huAXM"; spf=pass (imf25.hostedemail.com: domain of gehao618@163.com designates 117.135.210.5 as permitted sender) smtp.mailfrom=gehao618@163.com; dmarc=pass (policy=none) header.from=163.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707107029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2LFTVn7WS/MIzy0KcPbm4wL9w8tNkmOOp85qZt/+6+Y=; b=VY+T0hFTcb9Hm/SXEHavXYFy2HsJXmS9uo2wUKncNA58iZavM2BTEM3YnjPPgdRUOMiE5s aNxpsLBEdQo70R0UeCz804OD4fUtw2lhhAjbMXgDipFHpaHJGHo7vfokG3fKzyEb8tmOpB KWLQrTc2jR2By0zflHMcAOy8DD1IqVI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b="B 6huAXM"; spf=pass (imf25.hostedemail.com: domain of gehao618@163.com designates 117.135.210.5 as permitted sender) smtp.mailfrom=gehao618@163.com; dmarc=pass (policy=none) header.from=163.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707107029; a=rsa-sha256; cv=none; b=flc1jsPiXmjuwzL75zYtHyqBBJH6vA4S/gmFA2W9t0Q9R+Lm2P7qrls7NR+VQGP+RAs6zz DhTfB2fP9Bdl7gW033JImx736MW5XWl4pWivfyeursV5xxwNUXYTPeanMklQZVONf9X9B0 R60Wofbc3kmYhUwyJUzFSUHZmZDTAqM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Content-Type:From:Mime-Version:Subject:Date: Message-Id; bh=2LFTVn7WS/MIzy0KcPbm4wL9w8tNkmOOp85qZt/+6+Y=; b=B 6huAXMfAUSL0i8SUCNvsiF55dWx/TGNSCcOgnfYlUGVMImVeSO8eeamlXU2aatbv Hotas5yzDXrGWQK4I9NYaX3cxlfr+qKdIFQ4Fui1h3ihMzX+8uUDwDfWei56fBGc 8RMHZtJOqAKLQwj5F3I5steBj8Qfk3hcIsnLDF79uA= Received: from smtpclient.apple (unknown [175.2.42.150]) by gzga-smtp-mta-g1-0 (Coremail) with SMTP id _____wD3X8bOYsBlQ2pUAw--.1130S2; Mon, 05 Feb 2024 12:23:43 +0800 (CST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Hao Ge Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] fs/inode: Make too_many_isolated return bool Date: Mon, 5 Feb 2024 12:23:32 +0800 Message-Id: <02CFAD55-0733-4765-9160-153409AE050F@163.com> References: <20240205022825.99061-1-gehao@kylinos.cn> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20240205022825.99061-1-gehao@kylinos.cn> To: Hao Ge X-Mailer: iPhone Mail (21D50) X-CM-TRANSID:_____wD3X8bOYsBlQ2pUAw--.1130S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFWruw1kWw48WFWDCF17ZFb_yoWktFXEvF W0kFsa9r98GF92kFn8Cw1UXF4rWF4q9r17Xr9YqFWaya4rC34ktrykKr9rCrWUXa15Gay3 C3ZxuryFkr1IvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_eHq3UUUUU== X-Originating-IP: [175.2.42.150] X-CM-SenderInfo: 5jhkt0qwryqiywtou0bp/xtbBdRB7FmVOAkGY8QABsI X-Rspamd-Queue-Id: 3EFC8A0003 X-Rspam-User: X-Stat-Signature: aq1xqe9k4gs44q7xx1kxpn1k8x4hctrk X-Rspamd-Server: rspam01 X-HE-Tag: 1707107027-589249 X-HE-Meta: U2FsdGVkX1+hSFbcC7KNUdVaWdkE6TFySqrG0BHfgOtq5nNEPit2rULJeAJ+sH7I1ksmYjzF2IAfwGYKg8DGvmrdJQ4g4JQk7jIrY8GLj9aTAMPCmnY384Ucg/xUuuoEDdjkE4ml81+yABp9r5nI6Gm1W8hW28mpvChkczVlkaH2ADpcuxG/7WdlNMd2HkyaoV4xusPyZz1uAFty1dB8Q1497RmRMqsliE2XMOdekU5qCKtbeFvobh2BGfdib7YMSflq79sVQaWEeaEheiTVCwMQBNN7dveaNFwWDOIuKMpQ9dt5b99jv1Zpogwoh50ZdquLE6ZNqX8+et4rsojg7+ghMPKY8+VoVigcPHqi+CS/5nDhcNT6FP+r4QkPgDc0ka3EH1YxDX1VIQnkbyRqjQKOeD2fQQy+IPh3V8Lo9bbTAXjUzxXaV1djkylOvmVWim4FLn3vzLISBBltmuF96+3sPD9Zb/1pgbioPZAkkp2b/aYvuXLhC+tG6H8RTFk3C1VKrGCpnnylhnGnktDtXHCbKE1gtT6U54NiHiGyLxuRpdSCUN4XrUlb1lXLCH6ARGd+TLBWBmoUWRV+Vs42oln9VqYdRb3FnY8KRXPz+eGsKjTonKqPUGwlbQw6QU3gxQoG1MRIGFivoNSL/p8JTMpJTad/O8NBhCA8xEIBMLEuK9kl0Fl7MZlom91McndQbcPiElhyR++NJhLKHb/HD1YflRBkWA5X0yE7JphhIybLoukRyX37BLFzmO+Mhk1DQRD/jDyeqxuXnryJWB9uU6mLEFIFUV/2LSoUVlUc5aC+hPCRyPycBtMv8UhtnWKeYbqZQ22dw6ybUNw3xcpkru2zdF1ZXRtoF0A4JCmfTG8THzdejTDmUPMDdkZw9ZAv6Dj6EqFrx+n43Tvl3Wwz/56InO/YfWw7w+G+8lQ+8KmclOoswLjHqU1sgEnt2PSGAc1jXdSuurTgZV+aabW D1icWnT3 PV+wxwXKrB1hAkhorcUdM4mLbs9GjP5JPi4E+4UdBqgq27/my7TeQyw8z51iOgid4XQMiUR2Ehok8zlNbhd0vc+vPnbxWy3MSIW7nTDGpenLAYLHmQMkLkNk4KQh+Wxh0lAcLRIf/qaEoQfm42tskdrdNQiaOsdjOzJE47biGmy14QF4BvzbIuX2ZnkdAmt8ip+FuwJU37UMJi+entkNqgZ5Br2bbIP1SxKgU4FoZHgMJNv5BQ3EM8IJmndtzNlsqqbpcbEfwuDy2B/CPdVlQDncTzeIcdRmoim5AVEqnZYkfp75U7MvQyTtdvXUO274HyveFlvcEVvOHz3u2EzlJDS54GLDVZeZSb7cb3QOnpUI1TS0bEQJqk9fF0CBDvwkiKL27QjGyRZ6Yd7mNolu2PUcpQC7DE4ydD5KsmkQ1bAezv7DuXEcssgn/oQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sorry, please ignore this patch due to an incorrect title. I will resend the= correct one > On Feb 5, 2024, at 10:28, Hao Ge wrote: >=20 > =EF=BB=BFtoo_many_isolated should return bool which with the same name and= > similar functions in mm/compaction.c already returned bool >=20 > Signed-off-by: Hao Ge > --- > mm/vmscan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 4f9c854ce6cc..143e4b8e8821 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1744,17 +1744,17 @@ bool folio_isolate_lru(struct folio *folio) > * the LRU list will go small and be scanned faster than necessary, leadin= g to > * unnecessary swapping, thrashing and OOM. > */ > -static int too_many_isolated(struct pglist_data *pgdat, int file, > +static bool too_many_isolated(struct pglist_data *pgdat, int file, > struct scan_control *sc) > { > unsigned long inactive, isolated; > bool too_many; >=20 > if (current_is_kswapd()) > - return 0; > + return false; >=20 > if (!writeback_throttling_sane(sc)) > - return 0; > + return false; >=20 > if (file) { > inactive =3D node_page_state(pgdat, NR_INACTIVE_FILE); > -- > 2.25.1