From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F21C3F2D1 for ; Mon, 2 Mar 2020 10:37:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A96F220863 for ; Mon, 2 Mar 2020 10:37:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A96F220863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 433246B0005; Mon, 2 Mar 2020 05:37:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E2E76B0006; Mon, 2 Mar 2020 05:37:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D1416B0007; Mon, 2 Mar 2020 05:37:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 161AC6B0005 for ; Mon, 2 Mar 2020 05:37:41 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EBAC8173DB for ; Mon, 2 Mar 2020 10:37:40 +0000 (UTC) X-FDA: 76550071080.20.mice45_4304dbfd8dc2a X-HE-Tag: mice45_4304dbfd8dc2a X-Filterd-Recvd-Size: 4023 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 10:37:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CD7531B; Mon, 2 Mar 2020 02:37:39 -0800 (PST) Received: from [10.163.1.119] (unknown [10.163.1.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9969E3F6CF; Mon, 2 Mar 2020 02:37:25 -0800 (PST) Subject: Re: [PATCH] mm/special: Create generic fallbacks for pte_special() and pte_mkspecial() To: Geert Uytterhoeven Cc: Linux MM , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Guo Ren , Brian Cain , Tony Luck , Fenghua Yu , Sam Creasey , Michal Simek , Ralf Baechle , Paul Burton , Nick Hu , Greentime Hu , Vincent Chen , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Guan Xuetao , Chris Zankel , Max Filippov , Andrew Morton , alpha , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , linux-mips@vger.kernel.org, nios2-dev@lists.rocketboards.org, Openrisc , Parisc List , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux-Arch , Linux Kernel Mailing List References: <1583114190-7678-1-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: <02997860-9374-28b9-8703-dc9b62b3f8ff@arm.com> Date: Mon, 2 Mar 2020 16:07:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/02/2020 01:49 PM, Geert Uytterhoeven wrote: > Hi Anshuman, > > Thanks for your patch! > > On Mon, Mar 2, 2020 at 2:56 AM Anshuman Khandual > wrote: >> Currently there are many platforms that dont enable HAVE_ARCH_PTE_SPECIAL > ARCH_HAS_PTE_SPECIAL > >> but required to define quite similar fallback stubs for special page table >> entry helpers such as pte_special() and pte_mkspecial(), as they get build >> in generic MM without a config check. This creates two generic fallback >> stub definitions for these helpers, eliminating much code duplication. >> >> mips platform has a special case where pte_special() and pte_mkspecial() >> visibility is wider than what HAVE_ARCH_PTE_SPECIAL enablement requires. > ARCH_HAS_PTE_SPECIAL > Oops, will fix it. I have been juggling between too many HAVE_ARCH_* and ARCH_HAS_* lately :)