From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B14C433E0 for ; Thu, 28 Jan 2021 01:59:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3189260C40 for ; Thu, 28 Jan 2021 01:59:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3189260C40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 604A16B0006; Wed, 27 Jan 2021 20:59:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B5086B006C; Wed, 27 Jan 2021 20:59:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F2C06B006E; Wed, 27 Jan 2021 20:59:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 3A3306B0006 for ; Wed, 27 Jan 2021 20:59:09 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 064608249980 for ; Thu, 28 Jan 2021 01:59:09 +0000 (UTC) X-FDA: 77753526018.01.roof66_5a060b62759b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id DA4D210049F0F for ; Thu, 28 Jan 2021 01:59:08 +0000 (UTC) X-HE-Tag: roof66_5a060b62759b X-Filterd-Recvd-Size: 4334 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 01:59:03 +0000 (UTC) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DR3WV3JSXzl9Qm; Thu, 28 Jan 2021 09:57:26 +0800 (CST) Received: from [10.174.179.117] (10.174.179.117) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 28 Jan 2021 09:58:58 +0800 Subject: Re: [PATCH] mm/memory_hotplug: use helper function zone_end_pfn() to get end_pfn To: David Hildenbrand CC: , , Andrew Morton References: <20210127093211.37714-1-linmiaohe@huawei.com> <9e15556f-8535-d8ae-d5b1-db264d377c20@redhat.com> From: Miaohe Lin Message-ID: <029811ed-4988-769b-a9f4-7787cf0779c5@huawei.com> Date: Thu, 28 Jan 2021 09:58:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <9e15556f-8535-d8ae-d5b1-db264d377c20@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.174.179.117] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi: On 2021/1/27 17:40, David Hildenbrand wrote: > On 27.01.21 10:32, Miaohe Lin wrote: >> Commit 108bcc96ef70 ("mm: add & use zone_end_pfn() and zone_spans_pfn(= )") >> introduced the helper zone_end_pfn() to calculate the zone end pfn.=C2= =A0 But >> update_pgdat_span() forgot to use it. Use this helper and re-name loca= l >> variable zone_end_pfn to end_pfn to fix below compilation error: >> >> mm/memory_hotplug.c: In function =E2=80=98update_pgdat_span=E2=80=99: >> mm/memory_hotplug.c:448:32: error: called object =E2=80=98zone_end_pfn= =E2=80=99 is not a >> function or function pointer >> =C2=A0=C2=A0=C2=A0 unsigned long zone_end_pfn =3D zone_end_pfn(zone); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~ >> mm/memory_hotplug.c:448:17: note: declared here >> =C2=A0=C2=A0=C2=A0 unsigned long zone_end_pfn =3D zone_end_pfn(zone); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~ >> >=20 > Please don't talk about compilation issues your changes introduce in th= at detail, that's just confusing and looks like something would already b= e broken. Please simplify to something like I will keep this in mind. Thanks. >=20 > "Let's use zone_end_pfn(zone). We have to rename the local variable to = avoid an identifier clash (variable vs. function)." >=20 > With that >=20 > Reviewed-by: David Hildenbrand >=20 Many thanks for review and reply. >> Signed-off-by: Miaohe Lin >> --- >> =C2=A0 mm/memory_hotplug.c | 9 ++++----- >> =C2=A0 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 710e469fb3a1..0483db52b85f 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -493,20 +493,19 @@ static void update_pgdat_span(struct pglist_data= *pgdat) >> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for (zone =3D pgdat->node_zones; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 zone < pg= dat->node_zones + MAX_NR_ZONES; zone++) { >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long zone_end_pfn= =3D zone->zone_start_pfn + >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= zone->spanned_pages; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long end_pfn =3D = zone_end_pfn(zone); >> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* No ne= ed to lock the zones, they can't change. */ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!zone->span= ned_pages) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 continue; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!node_end_p= fn) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 node_start_pfn =3D zone->zone_start_pfn; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 no= de_end_pfn =3D zone_end_pfn; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 no= de_end_pfn =3D end_pfn; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 continue; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0 -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (zone_end_pfn > = node_end_pfn) >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 no= de_end_pfn =3D zone_end_pfn; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (end_pfn > node_end_pfn= ) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 no= de_end_pfn =3D end_pfn; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (zone->zone_= start_pfn < node_start_pfn) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 node_start_pfn =3D zone->zone_start_pfn; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> >=20 >=20