From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E088ACDE022 for ; Thu, 26 Sep 2024 16:35:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DC416B0096; Thu, 26 Sep 2024 12:35:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38B9C6B0098; Thu, 26 Sep 2024 12:35:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DDC46B0099; Thu, 26 Sep 2024 12:35:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F1C3E6B0096 for ; Thu, 26 Sep 2024 12:35:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 95C17120A5A for ; Thu, 26 Sep 2024 16:35:32 +0000 (UTC) X-FDA: 82607440104.16.C6BF35F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 2A80F40013 for ; Thu, 26 Sep 2024 16:35:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eH2QITYb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V+DehV7d; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eH2QITYb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V+DehV7d; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727368369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RoDKZ2gwU3+3ZFoRhCswkZtms50amy9gvTc08Ex4MXY=; b=FjnVVV4WdQLh7Id5iFdaEy4KnVo39X52cyLoOFHgjPIlijAhwrn5bm2pfTpfywS7uk4Xvd V9fVtKJBsrnN/uzHHjZkPgM9a0KgTCFDec/ZPO5BnzO/DcoVWoVm5PHwXfwHQhU3/8pzDe sSBtVniTkT+hZ7ix2W6buf457G1gkOw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eH2QITYb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V+DehV7d; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eH2QITYb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V+DehV7d; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727368369; a=rsa-sha256; cv=none; b=NR8Ci+JkchXsG0AnhnuV/FZTSIn72azBEVOJynhkfOZqdR4zDSp544wlXnkbjznTTsS6yl l2scoQEfawphcBXzBbBp1EPR4lt7Xy93lvfh3TDkYH0b3BO20mIRgTzk0bxUlKveIG6bRO fIssHhYUQRKxMjIIOtrMU2CI/hZSJrI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7407D1F804; Thu, 26 Sep 2024 16:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727368528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RoDKZ2gwU3+3ZFoRhCswkZtms50amy9gvTc08Ex4MXY=; b=eH2QITYbG5LO29oBHWsHKc5cTjAX0JuSoGA2ZlN4CPEkcbccbOudJ4SqC2xf2NBnp2/Fv2 xReZ70tPJhoXdrbafpNVIbSXO/tI80zK54k4M6xGOrzqRdeCPVjCpYC7Dh3DIwEAZ0z/cE H8ob63brYl904+xhD20sguHuMrdSvYE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727368528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RoDKZ2gwU3+3ZFoRhCswkZtms50amy9gvTc08Ex4MXY=; b=V+DehV7dM4eDR5lcXZdST+5Nd75Eg/iBCdR4LubJ6PPnMdAKbGuHOpAZiehFrYgAHjQW32 SxTWSxWrvaKVCoCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727368528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RoDKZ2gwU3+3ZFoRhCswkZtms50amy9gvTc08Ex4MXY=; b=eH2QITYbG5LO29oBHWsHKc5cTjAX0JuSoGA2ZlN4CPEkcbccbOudJ4SqC2xf2NBnp2/Fv2 xReZ70tPJhoXdrbafpNVIbSXO/tI80zK54k4M6xGOrzqRdeCPVjCpYC7Dh3DIwEAZ0z/cE H8ob63brYl904+xhD20sguHuMrdSvYE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727368528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RoDKZ2gwU3+3ZFoRhCswkZtms50amy9gvTc08Ex4MXY=; b=V+DehV7dM4eDR5lcXZdST+5Nd75Eg/iBCdR4LubJ6PPnMdAKbGuHOpAZiehFrYgAHjQW32 SxTWSxWrvaKVCoCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C90F13318; Thu, 26 Sep 2024 16:35:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TU5eElCN9WYeHgAAD6G6ig (envelope-from ); Thu, 26 Sep 2024 16:35:28 +0000 Message-ID: <0295538a-4b79-42bf-b0e1-5a905749de1e@suse.cz> Date: Thu, 26 Sep 2024 18:35:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] slab updates for 6.11 Content-Language: en-US To: Uladzislau Rezki , Linus Torvalds Cc: David Rientjes , Christoph Lameter , Andrew Morton , "linux-mm@kvack.org" , LKML , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christian Brauner , RCU , Shakeel Butt References: <8d6c5d10-5750-4472-858c-eadc105453be@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2A80F40013 X-Stat-Signature: p7udkeggboe89y7w6utac7pzspjirjkd X-Rspam-User: X-HE-Tag: 1727368529-119948 X-HE-Meta: U2FsdGVkX19z3Hx+2ZcIqG+DC2fIz9FPDLZbGWPRCGJIB0vKEreTZQF81Jl0SOBXB2+oN4BWIymY8wwwErwaldU0Ez/FklgpNfGe5p7YgMWfcNFLjwrEE1GbWsI8mo42dq9x1/Lrm9QuFiYZaJivmKpz/NXg5MBAIEC6fJnTLXryyaFUEMOwz0mIKb+OpN0f90FY9H9r2aHtMdxuiLb4XZHWxoOOpVtNBFE2VFyWTX1rtItk2Ipmv00r679Xo6avVESIrcf50oWtQ6Z3rAEGcSgUnljGriV0SiHIy9iK+hWuawrLXigK3LJssMgxVIiEbOQU0kPOvDNIeN1x8Dl3lTasxeaZOV+ekJjGoRs0NKIZf5aB6tjt/aFhjoGQqZvVRuv2uQki3XoRKfuoN6HZ2WKDsZ+R+bFiNErWd/AHyEa3hYFlLCXFUgOvXfA67/Yq2cNsB7S31jiuX9ja+TsRylNj0ZRBqUI3cfQ8fEgxo3OATimQUq9rciMs/m0vG1R8ALPV+dRfD17cbgndHWN46Ar8Zd607AkZr22LT0YtfIiW8iveQzlwSEaQnwDUeEfg4b/qXIKp9R4dWm1KA1ri5bwN7xyowx337s2LRLOf55/3yMOtl5fRBZWxisnWT8GM/xqOX0vyuSq1l5M1DLvWFAkgM3TjZPNOnJLuBuCpUgqOYCiS8qSlp18Q8CCLYWrEK5VEHwGOuQOpetTEcUNq9bN/YvMc3ycnKh08/FiFD7VnJikspwsmSU7Ob5Fd5PsDR7baM5uY+Z3uRgUIpckqSo87RVm5QoVEWTbIBO8QWEXHiTNYmp5AvpucumjF3eVHOs4SyHwTCWhw8LUre8GiTt2FhT2Lt2xwgopveKZ2pQbBQJXQV+fDNsW6YozPJxiYxzCS/QAGGaetviOXrGuVF/4v6BI0iwomXvsVW2T/paemt84MdLz/OkEN43vzQemUQSyX01rKllY6nETcyjK NP4wIQBJ cRl64PHzd8dbj/tugIpuGpC1sp2QLRXMBnlkQf6X3h+0Jpgv6acFyR8598waIobQutTtt2MZH9vLs8fuitrm8tInaB9qL9I7oAzir1vNfr3SOaQwGVqtBEgq3NTrzNje5VwXzGbGkNQILA1CVROeNbxAFHooaHhkjqjy/RhIgGEMM8Ngw/F2HATdQ45GKletJDIqpREDaxDL5ptoTeUQOmJNCdorfSz0fXTOL02fzhqm7Z9J/a2tdWu2Mp67WQvgMayuobgWFxyp5qnae6Uw1V1Ky2Cus/YKvY47yVYdBLUFkoP/rbE5EX98ou61iefq8bkGqBZxiV+wbPaid9Qfa8nng2hC3QekD3n80ucjqbnu49YJvIMTRXA6+IkitKwxFjaQfq4JzaOHgkMHPaFaCWR6k+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/18/24 16:40, Uladzislau Rezki wrote: >> > Thank you for valuable feedback! Indeed it is hard to follow, even > though it works correctly. > I will add the comment and also break the loop on first queuing as you > suggested! > > It does not make sense to loop further because following iterations > are never successful > thus never overwrite "queued" variable(it never reaches the > queue_rcu_work() call). > > > bool queued = false; > ... > for (i = 0; i < KFREE_N_BATCHES; i++) { > if (need_offload_krc(krcp)) { > queued = queue_rcu_work(system_wq, &krwp->rcu_work); > ... > return queued; > > > if we queued, "if(need_offload_krc())" condition is never true anymore. > > Below refactoring makes it clear. I will send the patch to address it. Looks good, AFAICT. Can you send the full patch then? Thanks. > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index a60616e69b66..b1f883fcd918 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -3607,11 +3607,12 @@ kvfree_rcu_queue_batch(struct kfree_rcu_cpu *krcp) > } > > // One work is per one batch, so there are three > - // "free channels", the batch can handle. It can > - // be that the work is in the pending state when > - // channels have been detached following by each > - // other. > + // "free channels", the batch can handle. Break > + // the loop since it is done with this CPU thus > + // queuing an RCU work is _always_ success here. > queued = queue_rcu_work(system_unbound_wq, > &krwp->rcu_work); > + WARN_ON_ONCE(!queued); > + break; > } > } > > > Thanks! >