From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD30E7716C for ; Thu, 5 Dec 2024 15:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6734C6B0103; Thu, 5 Dec 2024 10:19:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F0E6B00CC; Thu, 5 Dec 2024 10:19:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C84176B00E0; Thu, 5 Dec 2024 10:19:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0FBB56B0088 for ; Thu, 28 Nov 2024 07:58:45 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC9BA121981 for ; Thu, 28 Nov 2024 12:58:44 +0000 (UTC) X-FDA: 82835507916.25.5BE1B4B Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf19.hostedemail.com (Postfix) with ESMTP id E54201A0011 for ; Thu, 28 Nov 2024 12:58:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=C8Bumpu+; spf=pass (imf19.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732798717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+vP4jRIW/scQLgDo6yiVzbWB+2Xrjyu4I+pVdj7iaCo=; b=WZXz3AwWVYNzz+DMMh3JnkvFFPRbkihx2en9eKIV48pvn4MNi7yUVoHOcrY3CY4PXmp6Ga ApYTGVc5QQ7rZtF2ia8WYjiHMli+Sy6J6CICjIsS/KbqthQT5xgKjvq7RQQXj+XlxfgpZT L3pGKaZ8I8DX9yyGGxAxRoYqSqGmYz8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=C8Bumpu+; spf=pass (imf19.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732798717; a=rsa-sha256; cv=none; b=3uyDtdvNYeJItmpDyS2CSG/1TQJf/hhnzwyfBIswQvsTJYNIYwKd/+Y8dvD/25eq7gNSdB 6UzhhMoIdjSOlUq7sM24OBJE9ud5jwalLRrULX2p+TjAsusXUUVPnL6HcrwTS8s/u5CB/y ztLNddhtIsZ2xk8Y4QFAEqK6Kv868E4= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AS7WIG2019105; Thu, 28 Nov 2024 12:58:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=+vP4jR IW/scQLgDo6yiVzbWB+2Xrjyu4I+pVdj7iaCo=; b=C8Bumpu+gZ/j08L6sz/4m0 IFvAYUueFJjZjQTDfbvugLiwXrvb55lgCUsKU+XbmpUiob8Y/UTYqP/8sbQaCmHF O5V0eu6qSpcJ4F6KSyVzeFsjkZJAjK8ObyofFUIxx5pRuMzu+Cb37oIJKK+C8glp qoakBDVlhkN8fdD8iQjYZoqGYL/D7yw+probTmEPeDtftaVXfkkrYXyvqYWBR4fB QCiTu3KtI3sLhK/xYkKiKh7fxYo0p+vyblg9scNuILBe/vG7KxKBqY0WCYrMsp6l IHIEKK3pVXCFx5sJ+PTqndiJqClKTTyAErMsQ4OYH/SplhMylheYzuwKXSP9gxfw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4366ywn181-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Nov 2024 12:58:37 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4ASClQhN014163; Thu, 28 Nov 2024 12:58:37 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4366ywn17q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Nov 2024 12:58:36 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4ASCopvo002445; Thu, 28 Nov 2024 12:58:36 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43672ghrnu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Nov 2024 12:58:36 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4ASCwZVd25690712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Nov 2024 12:58:35 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5235258043; Thu, 28 Nov 2024 12:58:35 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFC5858053; Thu, 28 Nov 2024 12:58:31 +0000 (GMT) Received: from [9.171.2.153] (unknown [9.171.2.153]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 28 Nov 2024 12:58:31 +0000 (GMT) Message-ID: <0290e481-48b2-48c5-acd1-66b80af66575@linux.ibm.com> Date: Thu, 28 Nov 2024 18:28:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: hugetlb_dio: Fix test naming To: Mark Brown Cc: Andrew Morton , Shuah Khan , "Ritesh Harjani (IBM)" , Muhammad Usama Anjum , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241127-kselftest-mm-hugetlb-dio-names-v1-1-22aab01bf550@kernel.org> <8174031c-b9b1-4e32-806e-28f1b2c1dee0@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: _U24e7_TUcdr63VY5czgIxE2DkFXuqEG X-Proofpoint-ORIG-GUID: kJVN5rkCMhHjMS5aSPhzuXziSrldDySe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 suspectscore=0 mlxlogscore=679 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2411280098 X-Rspamd-Queue-Id: E54201A0011 X-Rspamd-Server: rspam12 X-Stat-Signature: famw9mnekd5toqs6riq6uoyt7zysasbi X-Rspam-User: X-HE-Tag: 1732798713-388576 X-HE-Meta: U2FsdGVkX1/95SjX//cUoFigPOZgeQbRH2eN9QmWYO1194nWPYAwUtDtlrzJ0pS5X/gb7qXrowY0mjPKKk3SEQfM62EfG90U0ZbnbWMQpAc+cc5BgrtuDBIUw1nyz8QEaAfFnqaMxR/rRLI73bauQG5KDA+BgSnYm2FPEv9wFbMuyVZ9iBAQrH6bJdnM7pzm+rqtZdfJrWzyk1fM6W6dJpjshNJbSVphKq3A65XeVSvpdvXAQtwsPzgdbFSoO9rQUGBOq+ar9wtm13+g6TQ6uLN+1CXwAINXE1ZnHghK1wi5UvmuIUpf9wN0KLzCsw8iwkLZKr6Wl2iqchanT0b1FEwYPq/dv0nAKjPNifqP3so1DtSpeM1BGnAxTMorXEKtOwt9Sdc6tbj+LAMSOQBV/tsNAgNQhLw0O0hX8WsXGB201QgoCndKqeO+NBD3xf1RUcK5VTPI14hnlqF3wDcARNdp778XBzX/YN4IUemrxe4JXY9q8GlGLAckOksehyh8SEOVYolxk1iqcI6C6ow/r6VVD+sXgoaaMChfEaRqehsRBvN02nDWrWt/ZwasY6888GTSNJTxJaMNxxt5vffPKvEKv7zegK8Kjt4TF9Uk4vPAAA5yLkV9WyAWZXjXxQVadfC0uA17YhkqeGiAXGcKfF4DJZXmVt7HqLcQLBAEjY+ReW5syIw9BObYZwpA36DoaWFhSB2CM6NpKcyfLYXFuWVERZmQpeKPCR8KqbaZdhfuA/ix+RERm7az/OAEK8APdm5WY0zCSF3n23WElLKW2uTA1xUZ9GxqDr8NRfxMTVgTl1uNWCfyijnaCIRAF6BqMxTE7vBYWLNGCc/9gLpqIfC9c5LEhBb1bYKfqkrP32oEAtTkk1S47CX5lOhw5fwXtcHgMPgsxFkorROJExOpS3CMaPXsJWs+jd14JgakBrRLRv/MapNQCY177E/bkBEyiODZfmHzrbGSXDLNmWL /rzN9UV4 lEHh/5fj1Kfd1Ui1MHLWX6M3boq2ohMMJz+WsolN+tL5poZM5e4yIqYPq5xtR2PqLb+vKJgsmqYGRqpFxWtS00cnOwpE6jdw20FRauCOlJ82ujZuhHm6rlN63GPJ17YqhzglYhX2xqH7MAZedVc6wxOI8rNNBPR6B8bLrJ17Z3RDA0uECzGBchq5CPRR0sfaQYfSvSmSEqWzF97fxOfnEgAPYS/+2gsPn6lUHVd/Ef9I5PhQnz93cxgV+BNfk7Zu6kDx2HWRJUWNq6zps6kMROgBhlx9lfyivR7WzHhJ/m+h1RJJ4ch15d1qUGPXNWY/86nz8mKuB29uC3X9jr2HV1UetOSBOexgyVnRI8cYgxqTvXErak91dxK2mpn80w3sfBLJZOMNI5prd/KOELbMAgXQ8GrMGFg5V3sQjoKSjWIi+N+CsOXWddhzyin5ty8xM6l2xtTd7ehSVwc3SinRYib/Qog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/28/24 18:14, Mark Brown wrote: > On Thu, Nov 28, 2024 at 10:46:56AM +0530, Donet Tom wrote: >> On 11/27/24 21:44, Mark Brown wrote: >>> + ksft_test_result(free_hpage_a == free_hpage_b, >>> + "free huge pages from %u-%u\n", start_off, end_off); >> This test allocates a hugetlb buffer and adjusts the start and end offsets of the buffer based >> on|start_off| and|end_off|. The adjusted buffer is then used for Direct I/O (DIO). If I understand >> correctly,|start_off| and|end_off| are not free huge pages but rather DIO buffer offsets. Should we >> change this message to "Hugetlb DIO buffer offset"? > Sure, so long as the message is consistent it doesn't really matter what > it is from the point of view of the tooling. I also noticed while doing > this that the test doesn't verify that a huge page is actually used at > any point, I was thinking about doing an incremental change for that > too. Sure. Thank you. > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to.