From: Donet Tom <donettom@linux.ibm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftest: hugetlb_dio: Fix test naming
Date: Thu, 28 Nov 2024 18:28:29 +0530 [thread overview]
Message-ID: <0290e481-48b2-48c5-acd1-66b80af66575@linux.ibm.com> (raw)
In-Reply-To: <ed5c2cd6-9090-444e-9da1-9d8c7376a6e2@sirena.org.uk>
On 11/28/24 18:14, Mark Brown wrote:
> On Thu, Nov 28, 2024 at 10:46:56AM +0530, Donet Tom wrote:
>> On 11/27/24 21:44, Mark Brown wrote:
>>> + ksft_test_result(free_hpage_a == free_hpage_b,
>>> + "free huge pages from %u-%u\n", start_off, end_off);
>> This test allocates a hugetlb buffer and adjusts the start and end offsets of the buffer based
>> on|start_off| and|end_off|. The adjusted buffer is then used for Direct I/O (DIO). If I understand
>> correctly,|start_off| and|end_off| are not free huge pages but rather DIO buffer offsets. Should we
>> change this message to "Hugetlb DIO buffer offset"?
> Sure, so long as the message is consistent it doesn't really matter what
> it is from the point of view of the tooling. I also noticed while doing
> this that the test doesn't verify that a huge page is actually used at
> any point, I was thinking about doing an incremental change for that
> too.
Sure. Thank you.
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to.
next prev parent reply other threads:[~2024-12-05 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 16:14 Mark Brown
2024-11-28 5:16 ` Donet Tom
2024-11-28 12:44 ` Mark Brown
2024-11-28 12:58 ` Donet Tom [this message]
2024-11-28 7:14 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0290e481-48b2-48c5-acd1-66b80af66575@linux.ibm.com \
--to=donettom@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ritesh.list@gmail.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox