From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76DFCC27C52 for ; Thu, 6 Jun 2024 22:28:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6C86B00A5; Thu, 6 Jun 2024 18:28:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B769E6B00A6; Thu, 6 Jun 2024 18:28:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F0636B00A7; Thu, 6 Jun 2024 18:28:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7C0A86B00A5 for ; Thu, 6 Jun 2024 18:28:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DC8E2A1C5B for ; Thu, 6 Jun 2024 22:28:47 +0000 (UTC) X-FDA: 82201904694.29.C7AB852 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 7AD7BC0016 for ; Thu, 6 Jun 2024 22:28:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aH+fgtkI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=qnEMc8xF; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf10.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717712924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0GVHqT+cinUqqWBoYBZnge4lnlMVnzqAGxoR8FeUGx8=; b=c069lFGE2mvLrvrPuJWo8clqR1MC+Wr+zvhlSp5xW5x3gXQ32+iOLorUdD3unnNHO05HTX A3pRBvWuPBjkyt38j2koHeT6QijHiWA3C6OO3U5wHipgijile+f63l6U+db1Qf3SR0qzGi 55cVyB5o3aDEVZhb+RYyvwrv0yB/LDA= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717712924; a=rsa-sha256; cv=pass; b=QnfQgnGfuWSvciIe8EPr6Izniy/WaQS+tPj8gZEAxVaB4DVBr8ATsqXzcKUdzSjndnVW3m wtsIsY+QE8gG/iFxF2Upw8SWn8Ziuz77g9NclZnKYuQllJH0rWV7JZDtehPmyA51D1UlEl XOaZrpwgULDFdgk+NjTC1AM8aIlOnCg= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aH+fgtkI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=qnEMc8xF; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf10.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 456Hx9kC029612; Thu, 6 Jun 2024 22:28:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=corp-2023-11-20; bh=0GVHqT+cinUqqWBoYBZnge4lnlMVnzqAGxoR8FeUGx8=; b=aH+fgtkIJOa7QBd61Z8/eHm4O1Iqfgos+Icif2YCJKPB4x4z+dAx6+G6LfqWgZjYoaR3 A5fxbpmX8QIhDasrEIUjNCYU3hins4ScHnGXqx1FKCzM9fSRZaIcKRndYRmC7d8X/KzV SKRL+aW9uY3t9u4AWqU3yOskm7hJNUD4at+TBsMKIV3K1VX6Ukx03qp7EYy4+cpAULvB 37t7foS43zAK5MqrgegpKGTi5o1aQ7FQQbhj2w8ytwJ4Y/zzb/3MrSKxAGKrYiAe3RKt cJwCkwpBwScZ1qqfZ7eKK8jaCQ7PmLucg12+2TiHiHfOEelUCjcCLwUwThOXmWI/LSB4 JA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yjbtwch1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jun 2024 22:28:40 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 456KEWxL025019; Thu, 6 Jun 2024 22:28:39 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ygrtc8amj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jun 2024 22:28:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R7C/gFSPegNKe1tv1WkSuwzAs6vkwSuxoZLR3v7VQvm+T/CTxDEjNCTWos9LcbhRbQVJbPyetB5A4n+BVzQjREbHEMqmXah/CGm1vC085oGvRZHzArhV5ndIaCFPyGi7Dft9tpBPxUdMJkPtNftbg/tDpd+Jhwj21LgRfM5Qk7OS3zpT9wbP5IJx6Xr+tCmUW4qU3rKiVUBwkEgmue58tZYT/BWA+BMAnEg8EcErPUnB5OWdm5acp3FXZ7iyAe2WU8XzyyG0tZmhsKHzOPNzkOyGBi+ZdX9w47sDzcbwFTym4+yjlS+Q2Gx65nxDVWwG1D41MGf2rHKwcUqIRsyWhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0GVHqT+cinUqqWBoYBZnge4lnlMVnzqAGxoR8FeUGx8=; b=iMvb4FSRFf6kTZeEqVLWpjiuB9I7UWbz+p1+HGvo8txCijpi5uHeEzsTUjP822jNQrq4kIJGGWOtmFfkMsuDG0+Pfj/O03ntYK9R52XDfN8/ms6muit/4wSg4dwvEaD0Bxyx4MgKylQeJLJ57qCq4/UwbPsaxl0c3AtUBIdiMUSuNJ7BOTgAFWfanxaGA5gsMTJi+TszL1bAtIRHG77rox8h/9vTQBuacIUc2q2Gs5J0klxGnDhjFzFkfaP8+dE+qxoT7K4K5Z2ELytrIFvIegKpRz8IXZf8aQvsEdku2t6PJBLWtQv7XaVQcN48LmFO0cI+L63Tq9ToUwbfgT6jqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0GVHqT+cinUqqWBoYBZnge4lnlMVnzqAGxoR8FeUGx8=; b=qnEMc8xF9Ypg/V2E15rAg1GjiypX76A7SyfAyFQPxrbc5Dt4KjDKI8YzvUwT9Vrq5FfJYmDcWFQC/TNj9zI+GalL1jRhJ9UAZKz3ksqt9W/B6EyB+OxqsdTv5THUNaa62jQ/mI3HxsVJc6bmFVsXPIH4ySg623cS1QazmMSGY5A= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by SJ0PR10MB5860.namprd10.prod.outlook.com (2603:10b6:a03:3ee::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Thu, 6 Jun 2024 22:28:37 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3%6]) with mapi id 15.20.7633.021; Thu, 6 Jun 2024 22:28:36 +0000 Message-ID: <0290a474-39f4-4549-9fc8-06ccd6321d5d@oracle.com> Date: Thu, 6 Jun 2024 15:28:33 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm: migrate: support poisoned recover from migrate folio From: Jane Chu To: Kefeng Wang , akpm@linux-foundation.org, linux-mm@kvack.org References: <20240603092439.3360652-1-wangkefeng.wang@huawei.com> <20240603092439.3360652-5-wangkefeng.wang@huawei.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR22CA0021.namprd22.prod.outlook.com (2603:10b6:208:238::26) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|SJ0PR10MB5860:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b4801a5-c8a7-486b-db08-08dc867801e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MkI4ZnNGMjg2L0J4MEZ3OXExM0hOY3FyT0NEcHVmYWo3YlpWL2N2RXZzWUpX?= =?utf-8?B?K2RyYlRPcThucjhtejV1NmRTRHpUbG5YL0lBVExuSHFpY1FYRTFlTjdtWUVh?= =?utf-8?B?OFRIaXR5cGJpLzhPVStqOVlkUGg3czVMWmJEVk1lTFh6M2QvSVkzOEFMYWF5?= =?utf-8?B?UjlGYWtkMkxOS1Z4dlUwS0xUdzdZNXhya3dZM1EyUlBTSkp2QW91R3JpMXRE?= =?utf-8?B?dzZMK3B0UDYxUW92NFJXS252N0lscUJGL2tDZGNhcHNiM0RSdmNhcjhNTTJV?= =?utf-8?B?MGhxeEZIV1hqSjR5bzdsV3ZEL2NyNm8vSXdqbXJQMzh4M0tXUTFBUGdCOTBv?= =?utf-8?B?YXQ4ZytZTE0xU3g3U1hJWHFnSU90SnVEeFR0VGFZc1ZBS2dJNHNUN0lVbXVI?= =?utf-8?B?dW9TNm5IWDE2V1dtM0NTRWwzRjZ2RDVhREJieURrQ2FlaG1pcVlySEJRZW9w?= =?utf-8?B?NGRMeWt6TDNJZlBXczJmaEVTcXhTM0RTZlVlTUszMisya0RPaDE5dDl3cHNz?= =?utf-8?B?N29URDVVSWJpcmNhSVFPamMxaXZ0U2R2ZXptV1NSM0ViczdSVFhqR3BmTkhK?= =?utf-8?B?Z3A3V01vRzZSWEJ5RjVaTG44VGlEYVZ4eVV1elRDdSt3TjJNRzB0bjV3blFa?= =?utf-8?B?Z1Fla3htMXFHazhCaVgzQXE0QmVFdDNJeE4yd2dUVmE5eXlnSUdxc1RoalRR?= =?utf-8?B?eVlweThHd3hpQk9YS0ZaY01zbFF0Vi95NU95NW11VTZCZWNVbGY5T0NGMGVk?= =?utf-8?B?c3h1djhod1JVUnNTM0lLcUdrdXRVUFNyMWd3MUhEQ2VLTGFPMFBaQ2hYeVpn?= =?utf-8?B?RVU0NXFYV2ZTKzROQ1k5OWZnZ1duQmtSNkZwRDRpM0IveEplWENFU1VyNUZ2?= =?utf-8?B?L1F6OWsxRHlORVZGT0Z0M3U0Z1JhUEdacHN0ODJkZTlDTUpJK3I3VTU3TzZ1?= =?utf-8?B?RUtLeDhMUWVhOVkzT0lDdmVKR0hqVEsyYTE4SFVFeVBqYVg1U3FnVlpZNjRF?= =?utf-8?B?MERWZExRWDdGUjZHYnh3S0g0N2wyZ1puK1MrbkVlMWtrM2dRSUpxTVVrd2NJ?= =?utf-8?B?c1V2RU9saHZYL3dmL2ZDSEhnSk1MZTcvTXI0OTV6R0k5NklWcGlXTDVyOFkx?= =?utf-8?B?dHpYNkdHTlUzWm5Nd3dwYU5TVEFVbnpxVTBKalBkcGZ1ZDdzT0xXcEEzNVpB?= =?utf-8?B?YUQwb0ZyTGFxZkpzMVYrT21TdThuZ1pTd1g4YTdNWlh3Q3pTN2dJYWNBUFFC?= =?utf-8?B?MVlpSFZEM0pFSG1UWFcvTVZ5U0JRQ0VTYzFyS0dybVBEK1VnbTN5S2YyNHh3?= =?utf-8?B?S0tOcExDVVFza3ZRanZ4UlpxRnRhcTBkbFhOTERHVGp5RVM4b2lKQ2oxb0VS?= =?utf-8?B?S1NscStJWVduVkxqSmRjM0lOU043VEYzbXljc1YxckpTU3hidEdzT09jY1Rq?= =?utf-8?B?WitDalI2cEVOd0Zyb1pYK0N6S21sS3NPbWFib3Yzdy9OMnZMM2Jvbzl4Vlhn?= =?utf-8?B?ZXFEbjlMbEV1NmlpQnB0b3h3QjR4R2VySVp1NDJ5NjErVHp0bGVFNVh3STl3?= =?utf-8?B?RnE4R0hjV0RvS25rMzFIc2M5cjlHRUNpVkh6NGFNTmo4RHd0UFlXTWd5Z2p1?= =?utf-8?B?SVBOZDg5TS8rcGNzTlRXbWxkMnJFeEI0ZDE4YU5CL3dLaitLazc1dWtpUFF5?= =?utf-8?B?dk5PZmN1NlYzTmJYRUtXaVFtaTE2QStsS3dhaGdLb0htMEJLdEZUYjdlYzcw?= =?utf-8?Q?sh9yY/F9tlu/FOkI7VGmTxZuo6/4J1kkS1bbPoz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHB4WFl4eVBneWNQQitLVXFTaWdtbWtiZHk2Q0NTNFdlS1E1eXJJMVdyN2hv?= =?utf-8?B?VXN4bjVmTFpqM3B4YjRCTWtwTUUrSFh1aFBiUmhTQWtGb3I4bG9CTUVGN1Jq?= =?utf-8?B?MmFXdUdleHM0cFA4bldsN05pSlgrTU5IQmdIdENxZGVOcEppcXFVVnZVMkJV?= =?utf-8?B?RXZuVUFVU0tvcFFiNUowbkVTT0pabFFTUmhoZVp2ZncxUmVqMk91eUFCM3cx?= =?utf-8?B?Q0FLcTVlVjRqL3pRb2ZpWmZrOVB2Qm94VUFBY1lzZFJ0Ylc5dWg0bEdveEU2?= =?utf-8?B?YjQ2czYxcHlFM003WUVzNmZGU0FwSGpON1FUVG55akFVNmt0Q0RZWGY3UG9B?= =?utf-8?B?ZS9RZytObEVVS1dPTnJoVDBGdmZIVm1qcDdRZ3QvQlB5dzZQZm90eDFrazdk?= =?utf-8?B?Y1hicE53L2wyTVMxZk5ha1NnSnZ6MjBlWWdQN3lPaWc5R05FRmRvVWpUb09P?= =?utf-8?B?aFRvWUc0czlGejMybi96bkFkRFEwRWtiWXpjRCtyVHBjbERxekdPbkk0VXhE?= =?utf-8?B?a2ZFYVNSSytSK3hicGxBQU5FeWtTTkZUVkx6MVVBS2dONmNYQnlKMVp2UnNk?= =?utf-8?B?cWJySGd6MkZEdElvSzQ0ZDdjNTE4REhRTjYzQzdNMjNsbk4vWi8rSVNHZTFa?= =?utf-8?B?VytEQ214ckVYb25mTEVlakVSTHFEUmNZY1lNdGNmSzV2UmU4aSs4cUJXT1lG?= =?utf-8?B?M2NwNk04MENLNHgxdjR5d01TSnNCZXlncWo1NUtWQlBYK05SZXhIRTZGZnBD?= =?utf-8?B?R0djZUFrOUovQ2ZBcEZ2WDZWUW1MWENRQ2c3aExkSE45NFlDR1pwbzRUZmY3?= =?utf-8?B?a3dCNEYyRHZZNndtL1hXUWJDRGhDQzQzUkV3YVRML3ZQUmZ2aUZKRXJSS2N3?= =?utf-8?B?bkFEVzk5Mzg3OURkN1FnOE1aYVY5MzR4aTJxbDRxOGlneHNqWVB0bURCWWpv?= =?utf-8?B?OXVuZm1GWFVMNDFWV1NCY1l0TmxZaDNEL2VzZGxHQmpqL1pYZXA4eEtCOGhu?= =?utf-8?B?WjVLbE8wODJuVno0NW1iMmVsMzNoNm4xblpOcG1rM05MWjdFWHpTL3VHQ0F0?= =?utf-8?B?MUdGY3pUYWFkbjZQaUxrNG5TazBCcFh3c1FGVTVzMVl3dHRQdUFMZkUzT3hw?= =?utf-8?B?andXVFFjL1B5d2VsZzIzV1RGNjcvYmcrUUFWVnJjN1Zzd0Nhd3h1RW9Bby9a?= =?utf-8?B?bk1Ta2RLUTNiOTFRY0gydUNBNWZhY0wrMUhwU3QrZDg5UHNocVBIQ3ZzZUZy?= =?utf-8?B?V2RnMnVxVVVELzk3dkRXUHJSVGlId2VyaWJJRjRxMjgrMmI5UUhRV3Q0SWls?= =?utf-8?B?VUJPNTdkWG9SZU1GdUwwaUp1OE9MWVl2cWl6Ukt6MHdhbGdodldndGNiRG5z?= =?utf-8?B?c01tT1lxVTRUbnl5cjFvUnF4U1B5L2hkTnU5b3NvUXppaUdYSk9mbGlhNjZJ?= =?utf-8?B?Rm9SN1ErYUh4dFQ4bmEwYlFLenMwNU1jMkJ5RXJUSndWbjNXcElkODVFbmdu?= =?utf-8?B?bGVWM2VxcS9GRjRnYTZwTXBtblRaU3FmZGw2SXdpb3dGNXM4dk14SDJwc1JE?= =?utf-8?B?aWlwWWh4blBCVmQ2MFROSHRsK0pZdFlGdXIyMDRvRUgrcWtmRjFoaC96d3pG?= =?utf-8?B?RHN4Qnp2eXl6OXRvMlVkK2ZseXB3ZG1kZ1gwU3VlSmtKcUhFV3g2QlE3OVZU?= =?utf-8?B?UFVoVUlDeHRQSWNyVXplOGFsNnhHTlFWYjB5TnVCeFFWWFNMd2dLcEtkOHdZ?= =?utf-8?B?S0tWTFltazJaVm1KVEFzdk5GY3dKOTRGSUFhUm5Ua2hiNmw3LzhWM0J6SEJ2?= =?utf-8?B?WWY0SUt5dFpnT3ZzdVE4eEFYOHZRc3kyZUtRejZDQnRHemlGNnNEd0pKeHk4?= =?utf-8?B?eFBnZnhYK1V0cUwvSVBqa2JUbTBDMG05dkxzcUN4S2NiUExiL3doSTNjSnVG?= =?utf-8?B?bDB0aldxQnJ2Zmg5SVEyRXFZZGQxaHNGYzhuWlhBOXJBclo0cmkrZDB5UGI0?= =?utf-8?B?aklvOXh1WTUva3hLZ1Y3b0FmbjZGVXhYRENvdTVIeXBnNmFwK1k5NFR4U294?= =?utf-8?B?UWVhdVM5TGVJRUZIbXp1TGY4cUx0NlJlM0VVUjZRdXdaRG5qMUxDR2t0L1ZQ?= =?utf-8?Q?SXegQef3FftRIr1BskJNBQ/2f?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Avg70SGdBeK2YJP+wxKgaW/Ou0dDn15yJp85jb+DJgTp36A/VTva+OeqNGX2WPrgfq3ITHJyuvCfBEZQxJegSaQ1H5gMfGcy8RBtvaTulHLZH1526DnXm2rCpF7bixQA59wpIOMUs2SNTreQQC96YbUMU2AUxWMUPaRXs0idUj4OghWyYFGGOcyv4/9kZ+N4TxZv5HXm69QXg0sMdVQj8TOxCuQfCoe3CykVhEuTG7hmzCVj//s8VtnAKFggXSFoZzLBdTBd1IV/sPT466322ErU00gJ+xAYy/c2lcsQIwOv0fJHFj/VZzUKrqH5+UnRRZzBPGrX4q1Vx8Pas5/0CxyhnWYE3XbqRIr89hvabq38xECK4LCsQm/VaQDKgUVwjIRfjvVcpNy3uZ3UxmO6Z2WR7kS4UGlYn6iIeIjCslmrO3WxnuvMNx0vxbh+iaf7Jzm//b+5JMcIRLMX7nTz8hba0pgugsMDI73ggxt6XtZ7QS8XxTWCPMU9LSUNRysZ66hEYn8Kna60I9JY4V5nDVc7CTZp8tkEwDQN4KOx8d6VpOcKMeCoRIiw/071JpwJZuf1g5ms1EC8t2MTbfRIiFS59wjVUG3n5uR//kL5r38= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4801a5-c8a7-486b-db08-08dc867801e9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 22:28:36.7987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zTe05z+ekwMV1fiY5/JipCcH/tuMl2kG0JOzIQI+bEQhd2e7HWBBXcDxt81upX+j2dvIdBh0pmU7iUTLiz7jMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5860 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-06_18,2024-06-06_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406060155 X-Proofpoint-GUID: gYWEEYqI8m5U7RVXSGofFX-ZiSmjKBI8 X-Proofpoint-ORIG-GUID: gYWEEYqI8m5U7RVXSGofFX-ZiSmjKBI8 X-Rspam-User: X-Stat-Signature: d65bymyuunz3zocrnwqehinkj3kzebsm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7AD7BC0016 X-HE-Tag: 1717712924-693334 X-HE-Meta: U2FsdGVkX19HaOYBzgxVY/RZVJEx1z97RzEvwLDlhxECvtNYf+0M7PPJbAGtfYr/Zq4Jz9LMlGe0Ah3ky2rigc3VUlEbIdBx5SXnLa/MB+r8CrHOpIjdgR6IU1DtCw7S+lnWELQh9/Y2OBvF+WN1lcfrLnzz1+Lzrc1567DTLp99zClNUrql17Cy1sgncbqbOvQS2MapNQORrhmmwxkEJHCr6Gy64hIZ8Y5gCm+c35H+Zu0Aq/BxY/KSAcizlDpBSpJoT7FQECKinhAObtPwUjwSZHWKg/ef5kcoDxt2vHChXoA3uvLReKDRl2+ujiMD6tIhPrN4XMaGeIzK7fWGYpL2fMi+sHh/wIPusEMFgEOQ/8xp2OT+cnVUM/QdAVBQJjgn9wol0/TrI/WPwr2dk7wi97s/JZ7HrsYBTQdXL0nkgupB0G8Kla2fmeQ/+JJ59qbIS3kOU6vKC7BO6kFwo8WVSg45Jzs4gB3O9hVvEi77CTxSCMZ/gS8l8IXL4WUg05mex+aJUirCWF4SBSBiHUAQ9gr9aWRCrOjMDAAgAxKKLGqF2CsLY7hABwVYqLliJHjS6peCKOAkZ4PxyEoywigsLOP0GB6QhCjd7Wsitr+vCWzgEOglA8ErZ/NbTX0lg9ZdFb528sHv+whVoXulAh+J9lO8rYepxh42XpIdr6LGW47xZa3qfP9VqSR+woebdhAkn+LhpiGJMjzme/JKmE2tAQOs5W3wQc/QjbblhYJScZfuhQUbyKBbsASgNuECE/mWKRP4qZRdm442p7Xthlhba7EYGk0adru3nyiUjH2o2wC2WQch24d3cDGKWJNZawkk/GrD5CdRgKPto8MHIx4YaYU9WcLZ2SVQFezyzzAUrhYirVXyt6gKI/0atg0Rj/oN/XfbkgZEY7Fmr7QFZCDVNWdyIfEM7Qc8/K0yDanCPhgjELs8+2gqPjNf1q50bjnpEiIHPOF7XGm35zy lS6GyV/q ztcgBjuyt/eo6OOtustx1sYdVszB5Ns4bWCsuB7SNCYX7DRB5vTX/eeinWkLbyslxAxoykJ3vPzi+YWd8VD1CTe+wHczbpBS0bPhr4BOZGvMSYjf2TdkHatzW7q1mIyc0Tt+BAuT2yJNrauN6ojk8DaCsXhVy7S5yFtLJV/3lOiwjBqQ1Gft7rXaBbjLXziIy8lq9rmSKBWy3ONAwkYsA+cahJx2YwOpL/0s4YnaQznC0eLrEjUrj5QKtRb0ld00702ZTeH8NGK6UvX99jgmvqGpW2O3x/QNZCa6gi9PY7V/s3IEPpBbS7bAwr3X1wA3LWeWlXWngFUZFfOlf2dcKDRrrIo61kn9+gEhghcuHLzN1XmlTPwjYrXylU9UCMhq0xRPHWN/MzbbAraYOXMCRt+h7skAD7P9a18aNmZtfG1sE6auyR2bfwbpJmE3IG9G/4av+RY2h6n3mppJz1QejRiGRWRT5X4kjRQGM X-Bogosity: Ham, tests=bogofilter, spamicity=0.010295, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/6/2024 2:27 PM, Jane Chu wrote: > On 6/3/2024 2:24 AM, Kefeng Wang wrote: >> diff --git a/mm/migrate.c b/mm/migrate.c >> index e930376c261a..28aa9da95781 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -663,16 +663,29 @@ static int __migrate_folio(struct address_space >> *mapping, struct folio *dst, >>                  struct folio *src, void *src_private, >>                  enum migrate_mode mode) >>   { >> -    int rc; >> +    int ret, expected_cnt = folio_expected_refs(mapping, src); >>   -    rc = folio_migrate_mapping(mapping, dst, src, 0); >> -    if (rc != MIGRATEPAGE_SUCCESS) >> -        return rc; >> +    if (!mapping) { >> +        if (folio_ref_count(src) != expected_cnt) >> +            return -EAGAIN; >> +    } else { >> +        if (!folio_ref_freeze(src, expected_cnt)) >> +            return -EAGAIN; >> +    } >> + > > Let me take a guess, the reason you split up folio_migrate_copy() is that > > folio_mc_copy() should be done before the 'src' folio's ->flags is > changed, right? > > Is there any other reason?  Could you add a comment please? I see, both the clearing of the 'dirty' bit in the source folio, and the xas_store of the new folio to the mapping, these need to be done after folio_mc_copy considering in the event of UE, memory_failure() is called to handle the poison in the source page. That said, since the poisoned page was queued up and handling is asynchronous, so in theory, there is an extremely unlikely chance that memory_failure() is invoked after folio_migrate_mapping(), do you think things would still be cool? thanks, -jane > >> +    ret = folio_mc_copy(dst, src); >> +    if (unlikely(ret)) { >> +        if (mapping) >> +            folio_ref_unfreeze(src, expected_cnt); >> +        return ret; >> +    } >> + >> +    __folio_migrate_mapping(mapping, dst, src, expected_cnt); >>         if (src_private) >>           folio_attach_private(dst, folio_detach_private(src)); >>   -    folio_migrate_copy(dst, src); >> +    folio_migrate_flags(dst, src); >>       return MIGRATEPAGE_SUCCESS; >>   } > > thanks, > > -jane > >