From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014A4FA3755 for ; Fri, 13 Sep 2024 14:10:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D5C76B00DA; Fri, 13 Sep 2024 10:10:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887B86B00DB; Fri, 13 Sep 2024 10:10:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FF7C6B00DC; Fri, 13 Sep 2024 10:10:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 51FBF6B00DA for ; Fri, 13 Sep 2024 10:10:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A3DC581FB5 for ; Fri, 13 Sep 2024 14:10:13 +0000 (UTC) X-FDA: 82559899506.14.9692A5A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 360EF180015 for ; Fri, 13 Sep 2024 14:10:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wbdFFwYi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8otsO+nQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wbdFFwYi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8otsO+nQ; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726236525; a=rsa-sha256; cv=none; b=4ELvcmv75gzIrYqwJyJKAgzaQOQg/GUqm9rv3wnm3FH93oB+RArEHKwPVugFPxbswK/SLy DSyZHU/U/onHItoik1t7vG+jcF053nRuSQGNQZsfwqLo4bNDDZH/PdfGIz8d7WoQr7pigE b3xeh6xaNQKav95vXiEI7AI0YAqlmSM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wbdFFwYi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8otsO+nQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wbdFFwYi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8otsO+nQ; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726236525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H2P1J1ksk9euax2Bu6daSipLCx8flOfu5u5SE133Wmo=; b=D5jygfUd0Ko1QKXYWCzrV6N+AwzTb9iXmAG+k7ZzbL3fjXyisaN9CfzHx2mbC4lde0BQBl XRdbiGeDHzwesoVNIu5YTw9kV1TC+uwb4+4OLPMLWQ7epmaAcjhmwsGaiGHymMv2Paraoa HhrzhhJpYIItehDJ2CWN2VI5BqrPpic= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5EB7A219AF; Fri, 13 Sep 2024 14:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1726236609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H2P1J1ksk9euax2Bu6daSipLCx8flOfu5u5SE133Wmo=; b=wbdFFwYiQH4/Uy3LK+Ofivo/xfTYGv0/fkQ8cTa2OLfzyxNEAu6+wyCOiGg7U/ibi5eAUI KyuoK5Nca2tOxHkBnpO7GYKKfP1S6ZHAQHUm8LjTPXFbzN8vhpvecLputi0QKVMRc5q1MX 3oY3Py5eQ8PrRsBAZLiBbSimik6+d+c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1726236609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H2P1J1ksk9euax2Bu6daSipLCx8flOfu5u5SE133Wmo=; b=8otsO+nQL0Z8+nZBWtqvACsDwOaUqbBwmhz8+ZIrSu1Dw/6zsmQikEYxR38wJpOpe5k6bj hbYCu6fxANhQvnBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1726236609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H2P1J1ksk9euax2Bu6daSipLCx8flOfu5u5SE133Wmo=; b=wbdFFwYiQH4/Uy3LK+Ofivo/xfTYGv0/fkQ8cTa2OLfzyxNEAu6+wyCOiGg7U/ibi5eAUI KyuoK5Nca2tOxHkBnpO7GYKKfP1S6ZHAQHUm8LjTPXFbzN8vhpvecLputi0QKVMRc5q1MX 3oY3Py5eQ8PrRsBAZLiBbSimik6+d+c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1726236609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H2P1J1ksk9euax2Bu6daSipLCx8flOfu5u5SE133Wmo=; b=8otsO+nQL0Z8+nZBWtqvACsDwOaUqbBwmhz8+ZIrSu1Dw/6zsmQikEYxR38wJpOpe5k6bj hbYCu6fxANhQvnBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4387413A73; Fri, 13 Sep 2024 14:10:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0Uj+D8FH5GZiMwAAD6G6ig (envelope-from ); Fri, 13 Sep 2024 14:10:09 +0000 Message-ID: <02820eb8-0b8f-4aa8-9315-85368e9c331e@suse.cz> Date: Fri, 13 Sep 2024 16:10:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] mm/slub: Fix memory leak of kobj->name in sysfs_slab_add() Content-Language: en-US To: Jinjie Ruan , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Liu Shixin , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20221112114602.1268989-1-liushixin2@huawei.com> <20221112114602.1268989-4-liushixin2@huawei.com> <3780a622-03f2-4cfe-5705-0e9d0be61d57@huawei.com> <68b86f66-cd00-bb7d-b8bb-5a94e8dd1ea2@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <68b86f66-cd00-bb7d-b8bb-5a94e8dd1ea2@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 360EF180015 X-Stat-Signature: 5ajbcwix9qk59476tkx61tcrbtprzewe X-Rspam-User: X-HE-Tag: 1726236610-33639 X-HE-Meta: U2FsdGVkX18lA7/XTGEgMSghfTox1PLd7IrV0cvigQnCwMFBukbCq96WQa3tiE3X+hSJipKYwLID30lIWqXP8jfUzrFocDhs8Kgn6KIYcHT0eqJqsDgAru7bfMOdVp6Kz9GPH19jLSg+G7DAGlkKu6k+5C+3qin1ZmT86CDiXDcT7NQ0YfTsZeYOOHa3NR9kNYdIehzizrGNqnZ3ekzW3RFt0zfVT9O10hPKi3ct207ifekOYvV4c5tZmvtLePQSCwZqnve4fA38WsEnGqbd7vYLmM2VAUx0G8qE+ZBBWuj+7DW1DOE60ks1ToBOwnvra6/Aya9UMZbWoWqp86g5yEZx8KrVvi3Qh9l8IQ5eK0RgbjkefmEil6QE0wF8QQau8+hYZAZmXb6qVJ7ACj7zX43j1ibNIPdf4p8SweWsTi0UmUI7U/FUSUl9QLO8hXukQeSrXd0UW0ZypjHznqlFwqWq+ETv6d+SVBGROD2zVI3s97aZdHwrbbKuAAhvij911jgt/+C17bIbjJs+JB/70MifXfkmhIpPlrcaZ+2xAbuh/lSTtDhHHg9al6xbsr19mUF6DvtvVb3l6Ofh0+1ecP98Q2uPme5EtIAkQAQfd7eCCNPAnKVpWqvieWPHr+vdapf5EFttTnt40E127yZHBUtKJW4Faf+aCwUdEy0wr9Z//eHNPb8mGXSbNdyi4FstPExfRPfYhsIEAsYY/WvVnhVnyLjWVW5WmjJ/gSwBAB78lcIsEFBkHGdcFNz8PsWcz3wXkTA7Mm+E+iYrIJGKygbqHjkRN/6nPjCxnrybcuUqcA9tHbdlqu1BRE77MC2UfHp1BfYMx7G9SowXAn9VlIwaNNgUzsXknEB9O4BwfyYv2SAX3vpLfZD7kQy9+pfIkTZ66rj2kohlA1p+BONW474m6Rc7r4xORsN0bWZTgHhFKMA1/dOdA7JPjR2VjrIwhvmeaqKuRHfpPblFu1h pF+aMeUm 3Yf7oexw+QRQEzkaqANmkkhE75o9QrzcLbrOQ3CKCe6xqD++HXokkPq+Gp5lIjbSnAqCWjfkR6Bmx0BZK2jUw5gwFL3fVB0nBQiN8T+SKu8hJf4Mgi4/wsjh3kEt9M/KDJHT4CXe2s6Eg98fJhzwDSjjPJ0+JvSif/3vbRoo1HnWG5ACtjnD7KlxZP/BG2StphGsGtVFmvUbATNzOHHiW826azh4zXTjj3TDexyeui5N93N6p6SVPymeEPAB8reoeLPwQh9FTo77gxtvbcJagH0NvIvcAhqzoscPf3XYEjaErixC2nhV2AT5GH+QL9S87sT3FZ9eyXdZ76GP/3vT6Ezv9IHUQCD28vHfHb80FWKfpzi1ouGlBgtBqB8KbaFF6pW35jkJLDPrfHrK+Kc/sdKs1+RwSZ2KlDpY23lBCzP1M0+U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/6/24 10:10, Jinjie Ruan wrote: > > > On 2024/9/5 21:59, Hyeonggon Yoo wrote: >> On Thu, Sep 5, 2024 at 12:41 PM Jinjie Ruan wrote: >>> >>> >>> >>> On 2022/11/12 19:46, Liu Shixin wrote: >>>> There is a memory leak of kobj->name in sysfs_slab_add(): >>>> >>>> unreferenced object 0xffff88817e446440 (size 32): >>>> comm "insmod", pid 4085, jiffies 4296564501 (age 126.272s) >>>> hex dump (first 32 bytes): >>>> 75 62 69 66 73 5f 69 6e 6f 64 65 5f 73 6c 61 62 ubifs_inode_slab >>>> 00 65 44 7e 81 88 ff ff 00 00 00 00 00 00 00 00 .eD~............ >>>> backtrace: >>>> [<000000005b30fbbd>] __kmalloc_node_track_caller+0x4e/0x150 >>>> [<000000002f70da0c>] kstrdup_const+0x4b/0x80 >>>> [<00000000c6712c61>] kobject_set_name_vargs+0x2f/0xb0 >>>> [<00000000b151218e>] kobject_init_and_add+0xb0/0x120 >>>> [<00000000e56a4cf5>] sysfs_slab_add+0x17d/0x220 >>>> [<000000009326fd57>] __kmem_cache_create+0x406/0x590 >>>> [<00000000dde33cff>] kmem_cache_create_usercopy+0x1fc/0x300 >>>> [<00000000fe90cedb>] kmem_cache_create+0x12/0x20 >>>> [<000000007a6531c8>] 0xffffffffa02d802d >>>> [<000000000e3b13c7>] do_one_initcall+0x87/0x2a0 >>>> [<00000000995ecdcf>] do_init_module+0xdf/0x320 >>>> [<000000008821941f>] load_module+0x2f98/0x3330 >>>> [<00000000ef51efa4>] __do_sys_finit_module+0x113/0x1b0 >>>> [<000000009339fbce>] do_syscall_64+0x35/0x80 >>>> [<000000006b7f2033>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 >>> >>> >>> Hi，every one, >> >> Hi. >> >>> I found the same problem and it solve this problem with the patch, is >>> there any plan to update the patch and solve it. Hmm looks like back in 2022, Hyeonggon had some feedback to the series which was not answered and then it got forgotten. Feel free to take over and send an updated version. >> What kernel version do you use, > > 6.11.0-rc6 > >> and when do you encounter it or how do you reproduce it? > > Hi, Hyeonggon, > > Thank you, I encounter it when doing inject fault test while modprobe > amdgpu.ko. So I wonder where's the problem that results in kobject_init_and_add() failing. If it's genuinely duplicate name as commit 80da026a8e5d suggests, 6.12-rc1 will have a warning to prevent that. Delayed destruction of SLAB_TYPESAFE_BY_RCU caches should also no longer happen with 6.12-rc1. So worth retrying with that and if it's still failing, we should look at the root cause perhaps. >> >> -- >> Hyeonggon