From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57A3C4332F for ; Wed, 1 Nov 2023 12:23:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393408D0060; Wed, 1 Nov 2023 08:23:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3423B8D0001; Wed, 1 Nov 2023 08:23:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20A438D0060; Wed, 1 Nov 2023 08:23:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F0BF8D0001 for ; Wed, 1 Nov 2023 08:23:33 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C80CC120CB2 for ; Wed, 1 Nov 2023 12:23:32 +0000 (UTC) X-FDA: 81409301064.04.53BA1C9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 8EF751C000E for ; Wed, 1 Nov 2023 12:23:30 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JV59Akw2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aQJ5z1nE; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698841410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gPsifyV8shqMQXEa/4w4t95u3kMaNN4UM0BOjLt3aZg=; b=RxDo7tElOsT2BlLJA2LLH1Bo0hL8ustA/NEFcER2JuOqGloidU6UFUagUzyfauPm9fXxQC yklSf7jCDKvTAejY5Fsm/0iolsaVxk25I5p+M4BgQIckPMVUblx3YXSl++/dOdgW70NTD1 UBG8Jge8HWA6y+0cXONRSn4wuFGJbfk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JV59Akw2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aQJ5z1nE; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698841410; a=rsa-sha256; cv=none; b=jAOLeIADezRjnGvJeOza8zrCcDwmEpGj2Ex94wx6xmVt0AqwdB4Ejnj5y5z0qBOQTqLguH raklGUsSNDkZOYK1YUuxwJj91IQ4EU4zQrqqcZVOzUJQe7lcKOMn/4QaoT5roxs6CnRvgy TuSM6e0JytoT1+/Scv3EPO9LXpuVA/U= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 55F021F74D; Wed, 1 Nov 2023 12:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698841408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gPsifyV8shqMQXEa/4w4t95u3kMaNN4UM0BOjLt3aZg=; b=JV59Akw2KvxeTN3uvAXLU2aWY4Uq/ShszP+FSw5xt+ry24V/9mVFBPxAeQp4ZtIteTGG+4 Y7yTPCCC9vHbyqU8Qa6rDQJXAryCDxEzQsizGjZ3m0kPu2nniTdWqAAOEjMXzb7KbsgCYA lSonpR3N/1wmfgTfjqpZKTJMhfASHvs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698841408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gPsifyV8shqMQXEa/4w4t95u3kMaNN4UM0BOjLt3aZg=; b=aQJ5z1nESWyjdSY5p0JtF1SchC+0JMTIkOBaHxP1pJCjoy4pC9zb35Utk7c97g2fKXWM0P FW5hIfsZ4OXsRhCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 250521348D; Wed, 1 Nov 2023 12:23:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y/4vCEBDQmX3UgAAMHmgww (envelope-from ); Wed, 01 Nov 2023 12:23:28 +0000 Message-ID: <0273835d-5aac-f8b5-7675-7c7aeca3cb4d@suse.cz> Date: Wed, 1 Nov 2023 13:23:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v4 3/9] slub: Keep track of whether slub is on the per-node partial list Content-Language: en-US To: chengming.zhou@linux.dev, cl@linux.com, penberg@kernel.org, willy@infradead.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231031140741.79387-1-chengming.zhou@linux.dev> <20231031140741.79387-4-chengming.zhou@linux.dev> From: Vlastimil Babka In-Reply-To: <20231031140741.79387-4-chengming.zhou@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8EF751C000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tc1xtarxeqszpt63ddruktyj4wqs5cwm X-HE-Tag: 1698841410-167174 X-HE-Meta: U2FsdGVkX1/jUPaT/RNYzsedebsAnTElK6qTM3Kd7DfjXyw7gdelBURolnqp6qiiLhfbPpcsQ7/SKzStcp7cnCrlfP50MDdEXHYJEHdHVq+OXBbeeN4wJiMTSwW3qs/xRf+kmnCB7iYuUnONo14REdhaKPJBsU/slyAGf3wIyEm2WeureyGJaE1ghA5jyyg4mP7f1+WPFZUdrVWAfL6HjokDgb7ycksVRqgLndEYF/3FaYRE3jA+3MTYlNxNbtJYXPCzavNUkCt7zdl6WU5cE2SCf5GdiZvKFsCiBhkDcySnNWVGsVi9qVJ+rPuR6tIAIeeJe6vyNgc3Q5KyvmsGtRd72dRFdaY98hzrDlZ/FZhHAnTH63BgXp8/Rl82qbg9pMDJnYmYw2vFsK6JVFXEPk/QZEvoB4Nmrt5b6RT8Jbzg17Oq2gRLg3g1OhDk7NoKtU4hE3VvsNLh/fPMGb3xChsMT7RpZ5sy7bfPBHoszVPwv+GwWBXFh8wCgRJFToj6PpEG05tgjd8MIjrlqQq47HFjzeGObkC+9Av0n85Hf8OBdL+TC7EHORTDQNbRHflUtFCzaL+4B2yqHuqyBI7lsMZGG4tl1GuWxDmSs5/HF7rB5HJq0WDtJ6DGedy6rzjk2HeMgkeLThq+yL2EscaxdQLOz3cz0ijpwm1NNhwMh80pAeeWPMpNWFAN4hUEhE0YF60xNc4XVz3k649HakzGbGgk7+oI8PyHbNIsLdOLX4Icex50bUmT2KXq2/ig32sk8b5jM9/BBFczYXTd5Sm0ETC3x52vjeWAcUdMOgOChaJ2uY0X8yfjZ8Y8ddrEnlvb+tp/n4zifLzzVG5df1NbMFZO6gHef9QtwcpWrWyBhX3AntpDruYQauEBBLnrsYELVlMXxbFZKhVm5gRH4KNo3q9NwbCaCBXab+GCEdoGgU8A4yE9ftO5RacZg+5h+Lll5p8o8SnjiyDLL2h7l5W +AjLvTpP gLUgZgZtNzoKNzX2tkAYYtFrYiOA/lTpNPi0XR0RHTCsgJDiSXWfJQHeiddrsE5f/pgU/dzpDV13ROgPvBI9kUJAc1yB19wmY4FxHVjR43/eVKNCKGwv8czVHUy862ve3utWEmS7ecnUTc0k9YhH6PZJNBN8D02FyAWk8GwM7PeHP13/hf8LBUhgb+nN8133KbiY2Y6WDeCDDWMwZyea2M7Vr95+yHvmPYudN/5q0Tx3y4VydUK2iHUy4RWnLEGaL8R+m8DWgxkUXFS8xU28yY2nftBN9YH6f8S2AsjurH223NDwUooVqI+1qti2DwlQZ7goLjxDegcg3qLHlCrYSA+6+pCNbRpfdUtPFDQ7pEJ/8i4Dj2QnJRpRvkUhVjXZ7xarj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/31/23 15:07, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > Now we rely on the "frozen" bit to see if we should manipulate the > slab->slab_list, which will be changed in the following patch. > > Instead we introduce another way to keep track of whether slub is on > the per-node partial list, here we reuse the PG_workingset bit. > > We use __set_bit and __clear_bit directly instead of the atomic version > for better performance and it's safe since it's protected by the slub > node list_lock. > > Suggested-by: Matthew Wilcox > Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka