From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D78E77188 for ; Mon, 6 Jan 2025 06:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E8F06B008C; Mon, 6 Jan 2025 01:12:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 099EF6B0092; Mon, 6 Jan 2025 01:12:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECB076B0093; Mon, 6 Jan 2025 01:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CBF706B008C for ; Mon, 6 Jan 2025 01:12:34 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7BC7912126B for ; Mon, 6 Jan 2025 06:12:34 +0000 (UTC) X-FDA: 82976007828.06.5E535C9 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf01.hostedemail.com (Postfix) with ESMTP id CD85740005 for ; Mon, 6 Jan 2025 06:12:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736143952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XIU7FNVbxN9AvbXsFVw5krRzGV8h1HNeljXv2pzCEZU=; b=qc0GBAp/IpBPQ0lQG+RakVBiJBLM8NVZIu9bBpsRhBMP6BG/hxlMUu5DrQRagcs0ZAkVTI jz63wYXnIOyDs5oZzTSFdtg6wEtyRpIKDhh+D2mM6S2YMq7ZaLvyILb8GUED+41zk96TcC ezUW+auDyVuOmKSAjE6+J5U+VGvhKeA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736143952; a=rsa-sha256; cv=none; b=TyZRQz3EFd7NCM7YFjJba8LbsrJeNHUKaPkdFHXWUxbaRz48kUjgbEnzKYYtsguXGGvJnl tsr06Pgo+2UhhW8QaMaLHmBVfhYLNi219bsIjy1zQLn04ESNpbFcps1fTU91Pevf4bpkSB HBAWK/soY+BAofCRDl83ZnssKG1OUZc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4YRP123LY5zRkxQ; Mon, 6 Jan 2025 14:10:14 +0800 (CST) Received: from kwepemo500009.china.huawei.com (unknown [7.202.194.199]) by mail.maildlp.com (Postfix) with ESMTPS id 5CFC31401F1; Mon, 6 Jan 2025 14:12:27 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by kwepemo500009.china.huawei.com (7.202.194.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 6 Jan 2025 14:12:26 +0800 Message-ID: <026f56f6-f299-4cd8-b430-042755cb0141@huawei.com> Date: Mon, 6 Jan 2025 14:12:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hugetlb: fix NULL pointer dereference in trace_hugetlbfs_alloc_inode To: Muchun Song , , , CC: , , , Cheung Wall References: <20250106033118.4640-1-songmuchun@bytedance.com> Content-Language: en-US From: Hongbo Li In-Reply-To: <20250106033118.4640-1-songmuchun@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemo500009.china.huawei.com (7.202.194.199) X-Rspamd-Queue-Id: CD85740005 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: jt9niyohjou38azfk7ws7krrq1d5kf9m X-HE-Tag: 1736143951-827698 X-HE-Meta: U2FsdGVkX18M5NyZMVbmlRTexiolz6NacObskKTLQXeBkDbU1kTYnitrRnPWR3Jr2cVSi29vKoorpuxsNaD8GHdveOv8RjZtY4L7TgwNYXnCJs+D0RW98fqN2/69GR0cUAq1VV8JhxKgryPHMJlKntczurB9LYhqQFjHZ+K4c1d7yaI5vQvH5XZWi5Wyc4UJMKFYFgO91vzHb1gcNjHmsSVEYLVnj4cG23xEif1UvtrqzLAYGjt17g8sVUVOesJOWHdA64baWuQkDEBrUgwQcxet+BQbKflRZd7JPs4ibfjrdg9MMOlsEN6xMsCg/1WieqhebhauQ+fr7TSNF5e//TDoIiipQLXRQQzTPcFkqKpevQrC5qLgzKa81TVKAEng+l7bgoikkBe5KPXbzG5f5WjR+p1rykx1CfZdvZrCAkC8g/xhrASMNTyFOTL/dP4sBrDLi3VGd9TzJ+2/xt7AG2Ywdwzb7K3x4vu8AVognksjQZOZcmlf4MybeDMRzAuYsFR2PEAaCGFJenkDNHHPCcZ2cBQp32q1LLmraMoQ4V0EGcE2tMj1LtADJrmcK4wCsbXy0h3O8We/hqjzAM3dIFR7ZAHSzkT2FTyXx8tvyzIYcsCj7w8p2AV/V/EYpifAqCWYciVxQ+OUTV8xYTttIrb+1/WynwsVZnJWkRMfv7QuNwC6WjWq2ujhT6HwHKoh4HSZqPk7hWlq8LHv7FZVIPAYr5+mnN41Ye1nsqtwfZANodOFw4Y/tK3x4M79vHXkfGiyGnwz2oT5QGW2LFqlJ4qxKLMp4nUHEC7WYY8IpmX9lBk2YG/aDacZoYMuNHC0jFqEmmEDn3xfkYAEYg85+EPpuAZZutDzUDKgiBmqo4E/np5CR1bOQ0BCRa0zNpRJ5Lcff6ZQOSP/Os/4b+JuyYolDEwUa/d/5d9zSoHVy0l4Js3bjp3v4MveHlL9+criTUgyxaN6ryg1Kbb8IaT aF6oY8Ky RUiwSLVYpTT07gGXYpErnb/xI4wgt+PQkbLSDTQZTUoUQAq/TT2qPcrTWsy6z6IaVUQOf/kmgBOQDJdXnKgjVMHZ7vYgrtrJocFrIMtL5UmtdxTWanGer0Q/BijzSwcpaUqKWKB2R48EWhK5cc4QSTSHEIcjQGRApzIO+Jw7dboefJYhEfTvN3T0ieR0uHWm1hXqVURKaTnbnl8OEIiNUiPAWUZ9cYNR7hYTJ9PxxARnMOWzNnSHWWcl4eHw+Noyf35Gg+Rte3HxmYKOrElW89Un/S5FokFDbidHu+yEpJd3ChKI52IRXXaSmomxQ2Xt9MdrvVJLZr1rHcJD556ZK3AxWYe/yHuOXfBcpq/kioVCNRaUulPM42cHa/+XxgcCyyZW9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/6 11:31, Muchun Song wrote: > hugetlb_file_setup() will pass a NULL @dir to hugetlbfs_get_inode(), so > we will access a NULL pointer for @dir. Fix it and set __entry->dr to > 0 if @dir is NULL. Because ->i_ino cannot be 0 (see get_next_ino()), > there is no confusing if user sees a 0 inode number. > Thanks for fixing! Reviewed-by: Hongbo Li > Fixes: 318580ad7f28 ("hugetlbfs: support tracepoint") > Cc: stable@vger.kernel.org > Reported-by: Cheung Wall > Closes: https://lore.kernel.org/linux-mm/02858D60-43C1-4863-A84F-3C76A8AF1F15@linux.dev/T/# > Signed-off-by: Muchun Song > --- > include/trace/events/hugetlbfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/events/hugetlbfs.h b/include/trace/events/hugetlbfs.h > index 8331c904a9ba8..59605dfaeeb43 100644 > --- a/include/trace/events/hugetlbfs.h > +++ b/include/trace/events/hugetlbfs.h > @@ -23,7 +23,7 @@ TRACE_EVENT(hugetlbfs_alloc_inode, > TP_fast_assign( > __entry->dev = inode->i_sb->s_dev; > __entry->ino = inode->i_ino; > - __entry->dir = dir->i_ino; > + __entry->dir = dir ? dir->i_ino : 0; > __entry->mode = mode; > ), >