From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB60C54E64 for ; Mon, 25 Mar 2024 03:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1966F6B0082; Sun, 24 Mar 2024 23:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 147326B0087; Sun, 24 Mar 2024 23:36:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 034426B0088; Sun, 24 Mar 2024 23:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E8BE76B0082 for ; Sun, 24 Mar 2024 23:36:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 838A1A093F for ; Mon, 25 Mar 2024 03:36:57 +0000 (UTC) X-FDA: 81934150074.30.341143A Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf08.hostedemail.com (Postfix) with ESMTP id 83EDC16000C for ; Mon, 25 Mar 2024 03:36:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711337815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M9xh50bxftX/1cq/cdNcLDv2owfKHA5WZMUgvhsX/X0=; b=RZz+VdClw8qwHmWv/YTdZGNsHohG2qsNcw6DR0oNdLfyYTEjN4oRrdyGQrt5Sjc7dcSGiN HptP+m5VWyWtkDNWgJwAPCIRFF3PF7K+7pMAZssVEtl2Pfv44rIzSBa4NKlzwByYO+yjPj NNqa1H9mBg1I5lRh4h1DckTNgRPk0Hg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711337815; a=rsa-sha256; cv=none; b=5ifpUrgnWksTYhQp/Vm4Qcabuo0fslB9D49lMZsOAqAjP1LoPpgtGODEIGVdLKYRNugbFQ Ls7x1YNy8TzoMaET6bos3lwnoWh3vjNlI12iZPwk+l14VvmHGxL8RVnbRxSZHhxj8nvIaI t+OGmZNz1Ef01F8HdxUYgH60L/SX2Ms= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V2z7S5nsKz1h3fw; Mon, 25 Mar 2024 11:34:12 +0800 (CST) Received: from dggpemd200004.china.huawei.com (unknown [7.185.36.141]) by mail.maildlp.com (Postfix) with ESMTPS id 2A3421A016C; Mon, 25 Mar 2024 11:36:50 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemd200004.china.huawei.com (7.185.36.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Mon, 25 Mar 2024 11:36:49 +0800 Subject: Re: [PATCH stable-5.10] mm/memory-failure: fix an incorrect use of tail pages To: Matthew Wilcox , , Greg Kroah-Hartman References: <20240307124841.2838010-1-liushixin2@huawei.com> CC: Andrew Morton , Sasha Levin , Dan Williams , Naoya Horiguchi , , From: Liu Shixin Message-ID: <026db58d-feea-8191-616a-3e6dca592786@huawei.com> Date: Mon, 25 Mar 2024 11:36:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20240307124841.2838010-1-liushixin2@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemd200004.china.huawei.com (7.185.36.141) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 83EDC16000C X-Stat-Signature: f7j3fesdiyn3xdicw4jurr4xxake9bm1 X-Rspam-User: X-HE-Tag: 1711337814-690576 X-HE-Meta: U2FsdGVkX19nJJlQTlqGagYsbJE4D6nCmyQ/dCHwICrnpH5rsmFORYlgn/VdknpwzDgWcMhVcPGdbnP74yKLZ4QF5UMcqz+6e+Y54F/KsaqMPi84CqTEMXE95DElnIMEFml9P3l7E5KFrV7cI6zfw05XcFOVhH3cYGzTANUz+PgHXtwSiFUgrwGBX0ihqx3+bkzCjb1DitlspOJlVep670J7+AoF2pztg/jeV2u1swuFb189bK1ZbYIFyPv7yZjlKFr41/rJ/8KdzgBZTHaq5G8Ky+Llcl6RgQiibtCp0zAeJFNdd1se6B9OQoQWvl9fwaNjVc3RjHnyRPLRKA+s5rj3NkHn6PsrY7kpcG+VAXo6LeWdbOART6rDNOlmmOXV2/ljkZOawNi1kerqkSB5lDUOERcppUebovt3QBbCRoq7jgIBmi+yKtamsFD30jieif67zJLMaX81sH9nSXxC1xhfku3I3S0c5yxTTEqf9tRIw3BDgS6q1+S2ji1HVqolKnn7ASvN3UiU/QNmyU1crVlilmRjCNYrsVaBJU/kF7v7UM9Ad2SJbduBpHeG6lkdov6IAidoDivzKCTbMMREu/dkYW3UB1Z3RthfCRwbKFcUp82DH4wHz5v4H0Vq7TupRBAGkIlMFAk3/Tamv0X41T7P1t7HILzaM+lMaLnl/gkgC3SwPVvReVsDfJEX93HuU9bKJKttOZ36DDcpip9tFJt5jp3ordsC1/RWyLkoVa24jtPZH0l2gxOno6QW6EjKgjupmHzm6dLcyPgQ7Ek+By8v+O0ljSfB2CtrFXB070aDYM5kjuvHIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, After backport commit c79c5a0a00a9 ("mm/memory-failure: check the mapcount of the precise page"), I got an error message as written on the patch. The problem can be fixed by the patch or just revert. Now I prefer to revert because I think it is related to folio and no impact in stable, or maybe I'm wrong. Thanks, On 2024/3/7 20:48, Liu Shixin wrote: > When backport commit c79c5a0a00a9 to 5.10-stable, there is a mistake change. > The head page instead of tail page should be passed to try_to_unmap(), > otherwise unmap will failed as follows. > > Memory failure: 0x121c10: failed to unmap page (mapcount=1) > Memory failure: 0x121c10: recovery action for unmapping failed page: Ignored > > Fixes: 70168fdc743b ("mm/memory-failure: check the mapcount of the precise page") > Signed-off-by: Liu Shixin > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f320ff02cc19..dba2936292cf 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1075,7 +1075,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn, > unmap_success = false; > } > } else { > - unmap_success = try_to_unmap(p, ttu); > + unmap_success = try_to_unmap(hpage, ttu); > } > } > if (!unmap_success)