From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DCF3D1AD3A for ; Wed, 16 Oct 2024 09:56:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 963FE6B0083; Wed, 16 Oct 2024 05:56:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 913966B0088; Wed, 16 Oct 2024 05:56:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829666B0089; Wed, 16 Oct 2024 05:56:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 60EEA6B0083 for ; Wed, 16 Oct 2024 05:56:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 653A881B06 for ; Wed, 16 Oct 2024 09:56:45 +0000 (UTC) X-FDA: 82679011338.15.085A91C Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 4948D2000B for ; Wed, 16 Oct 2024 09:56:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=gSjMnAH5; spf=pass (imf13.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729072538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rnszya6EHQM6AQ4/YRC+ZygvroVabaRKD1faRhw01hs=; b=Y8uc73pabJnuNHWnlO8OrH7pQkVEO9Yd5Mvd0NvavghEpTdE8yTa0j1z9PI1sZ28qUkZj3 O+1Fy0dX+6BYobhLatayyK2jbb1rnx33xJ+I3lmbjABiC20juutXfy1aGHWdv6aXnPJbKB 86692pOn0J7qsVWRTeIxwO2tgyQJP/w= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=gSjMnAH5; spf=pass (imf13.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729072538; a=rsa-sha256; cv=none; b=58fvEw5cfpFEU3gu6zP99h3uInRMNwOeC1/ANNfVDTm5E9R8VvTbuIM9G7kmId7fuPGS7H N1asrKjbfCeN/WS8FHmFAFZriO97V8ZVpf7jNq83NOLgGd2ohpikpKH3ArYqyeGczGj3Sr /WPo+EU8JiCs4POpx370Mf7Gy6xwpcE= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729072606; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Rnszya6EHQM6AQ4/YRC+ZygvroVabaRKD1faRhw01hs=; b=gSjMnAH5LRxb2VLKr3JzSH7Gw15ZxqE0YOcMnvO2RedFomGq0qZFrixa6tJACvuPIgMsCOJCZE1pUXiIlHoeCm09IBNWYKRcv5BelZ3W1Z5Sfr1uP7Gjifs/6K1WCHssmk7FdCaInbDbLZ5Ey27jXBXgY2rWoo7GnwE8Jms+u6A= Received: from 30.221.144.185(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0WHGyZ3z_1729072603 cluster:ay36) by smtp.aliyun-inc.com; Wed, 16 Oct 2024 17:56:44 +0800 Message-ID: <02544610-05e4-49b3-a477-3ee35c0701ed@linux.alibaba.com> Date: Wed, 16 Oct 2024 17:56:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Miklos Szeredi , Joanne Koong Cc: linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, bernd.schubert@fastmail.fm, hannes@cmpxchg.org, shakeel.butt@linux.dev, linux-mm@kvack.org, kernel-team@meta.com References: <20241014182228.1941246-1-joannelkoong@gmail.com> <20241014182228.1941246-3-joannelkoong@gmail.com> Content-Language: en-US From: Jingbo Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 4948D2000B X-Stat-Signature: k99osf9ic1e89wufmz6qkgbd49een7ko X-HE-Tag: 1729072601-527976 X-HE-Meta: U2FsdGVkX18nLi+2Hu9GynWxX9EYZaVzrvjEJhaNSqwAmAX53rnouxrZob7QkaZlzmIEzkdVU6gTV2WzZXl22ifW1XRYkWjDIo20e8KSu432gwt3mJmYvWMYuN3bMcb0KWgow2BQp8w4rCRwC4fxfDZAEoAgTxuyzY+zA9UYi9b0pr9SIRenJCXvrWO8cyP7fBCH0IMGddRDfOJCiPXUqAOXlpSwarloh0JHpE1KdRGDEvjvLr3ivQbKvp2ywPzna3FzBYeLGpAnXlq/kZILNKlNMgPJ+/2nm4HvBzchKm1mfHUWdnlolIgR6C0HV2jlGtWxwpvZmGiUEpSTqwzODG38PYUDIbjh6bXrJM6j1BLKUwAJaCbwLn4yaVY/EDIrOFwNK/eWAI0t7ty3xFKrkqswlErPc1JdKxXnyZekRqQfkzaCGr0QbwU4jAi6QHnyrvL9+lm7R4UJZ0bNUgNdPT+7Kmoj25e4yUj7UJLhaNKiHVP9dkNloRxspJ07Hn2sh88IYlM1VmEF6x9EfZB2nUh6GkCV5Ko7/GJATuKvqcoz1TGSgLtF25Zu9JrpEYeDK9XxmEpq6Q4flxvuzwxkN9nmSMpxSqvQ3n+6bZ78k7DHTvok3AiH3fZmhe2WoXgi/OnWJ7awkvtMHo1FHcYQwJmYUPv2xU2mpwTKfO2WAqjsSBrcEJ7UeQUWUlFoxvdXnos5/Ry1nxBpR9u+ZX/rdSbyplcAymqoxbBufCukE/umASbX/kNcJVvSKnNeD+IA2Rx1u3QwvBirpYYc9lQOM85IJTLY3QhqHzhnHqwXfFvSTGlSZHBsJAeokPh+eh/YW/XVSEB6LjDXrbY6UtfwIcKEL5BLn77q8fj8m1gOa5URY5SrsBKagOCOP0GcH1wDsmQ9J6uqSzwZ/OEeCpKI2WRW8Cc9TnAEAkT5ra8P5qfm4pp8zxmBFRW33ZKC8hR7SrpoAbSsOrbdC26YttG 5BB4nB9Y HTzQhYfgONwO4nj3ZbS0mm6Ld2vWa7MzUryGw1IU5xSAZvieAa1ejHs22O0Qw0hQTuBCQFZYVeYc0fKKiGAihgKRXIOJCQPm9zbXCCRIx8atbSKirKpZxlxQsFcF3MrYaDFsrk7Sz1IfYSulbQczBdvYdlnfc3kjOwoft5guwXbI1VVVKzX3hrUMZ7ISQV91q8wd5fb1Y1nFOmYxAZ6sgv5mXMO9rgNhmpe+zjg0iQMh9msam3TT0yQ71zuSPqRb+5b6siZrFw0BZAev9Cr31IQ4voTThES5h57UqYqdLCt+fl07NDYWNMl2dS+niWvYZ1dmkQlVisG2NVL3jPL/Ghpu0NJfS8hDafPGBvV+WvHC7AO0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/15/24 6:01 PM, Miklos Szeredi wrote: > On Mon, 14 Oct 2024 at 20:23, Joanne Koong wrote: > >> This change sets AS_NO_WRITEBACK_RECLAIM on the inode mapping so that >> FUSE folios are not reclaimed and waited on while in writeback, and >> removes the temporary folio + extra copying and the internal rb tree. > > What about sync(2)? FYI The posix sync(2) says, "The writing, although scheduled, is not necessarily complete upon return from sync()." [1] Thus hopefully it won't break the posix semantics of sync(2) down if we skip the waiting on the writeback of fuse pages. [1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/sync.html -- Thanks, Jingbo