From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF05C77B7A for ; Wed, 7 Jun 2023 11:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47FEB900003; Wed, 7 Jun 2023 07:39:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42F618E0002; Wed, 7 Jun 2023 07:39:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F841900003; Wed, 7 Jun 2023 07:39:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 227698E0002 for ; Wed, 7 Jun 2023 07:39:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CCB4840241 for ; Wed, 7 Jun 2023 11:39:02 +0000 (UTC) X-FDA: 80875755324.21.1B6E0A0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 93B59C0008 for ; Wed, 7 Jun 2023 11:39:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dJzz83yi; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686137940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xl5lF3cd+Vrp8y6V9jsp3fA29TQ9zzWfur5sh5x50ew=; b=jTuLqmPuZuSMmWNH2pUWgJWm4CUNQaq23db4VH+yl7tu6/O6GNeJxqeG8Ex9RRvdivlxr9 NvVDpg50A19CVP5VXqcG/d5xQXEI4JmGyfry3vUYL5gWtE1BmxRwfv/UOXt2RW/r1QTt3f PqGBXxPbQnQVN4n2QMumQHIEAf2DwLU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dJzz83yi; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686137940; a=rsa-sha256; cv=none; b=HokNeTreQGsrBoxsT9QyDoAYWuM+uqRz5y3TSNtEitepj4TaeAqWzZLe7mjuqs1AomrNa6 C7Wgeo08wpsam3NKk9l+iPgrdvkate46n2Dci+OKtgI9m7vqhT/psaOE74VSaal3xWH+ub sqIHI0iBo7Mt7U7hmpcUhLqZyqlfnNQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686137938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xl5lF3cd+Vrp8y6V9jsp3fA29TQ9zzWfur5sh5x50ew=; b=dJzz83yieToRaLhR6cNfuV8Ij4QgyzLFEU2efBfmqDwd/DB2kcPYXq7fjUNmm9+GQfQ/y4 0x6OAW1nWLEoHNgVCmNTltJ2hNo/JrVbErWyn7ERgm2Ka/a3zEQhSRJZ+P/YmUikeQCX97 h3+/TyqGVu6Mvw3G7Ggcm+rMuLQNqJ8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-Z2rPiG4_Okawgg84Dc0Nyw-1; Wed, 07 Jun 2023 07:38:57 -0400 X-MC-Unique: Z2rPiG4_Okawgg84Dc0Nyw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f70f9995aeso34843895e9.0 for ; Wed, 07 Jun 2023 04:38:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686137936; x=1688729936; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xl5lF3cd+Vrp8y6V9jsp3fA29TQ9zzWfur5sh5x50ew=; b=W3qjgxNkqCn5CDDdRcvSdWwTVXdV1wKDmE/qVGWeGKX+JVv/UGFTEDnqvyWWsGGX0d TLyOR3HEc9OWQiD3MulXcvtrED1cJN3I7sS6axbtUxh99LbbpyIM25B/QsAZmfF1NavP mCyLg63jqOwncPt+47jL9Bc7ZS7sAeoC4Y65OcqKDBKVOf6o4EF1yLYe/sSYgTall/6m qNC+eq6eMQjmQxSEoFBVaKIqhyyNHvNUmKA+3iN0jxZzM1OFpc7Nx9Ip3Ni21adFGAa9 90mw4ZqEG6rQ/n8QIpyTuIFffgWHPLTc9QKYtXQaazOPe/grDM7cmyFJpAd1t442MT8N m8SQ== X-Gm-Message-State: AC+VfDxytL1abSGtPbxTl85LnAMY9UfCIfTAvVN3MqfPUewG+Vaex+G6 1auBr53QIFHlczCls7VPxJ+vRDMj1lbikUam9MvWR2XTNJO7cOkpM42PgGfmMJeT6rEV4hbIHOl Yu502F1Lgins= X-Received: by 2002:a7b:c3d7:0:b0:3f7:34dc:ed0d with SMTP id t23-20020a7bc3d7000000b003f734dced0dmr4483086wmj.25.1686137936132; Wed, 07 Jun 2023 04:38:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5heuZue0wi0O7bnqMLQBR9c8uR94JGVv45Gz/7/fo4uIweaEn2r+seNTp712SXWXulwH/kcg== X-Received: by 2002:a7b:c3d7:0:b0:3f7:34dc:ed0d with SMTP id t23-20020a7bc3d7000000b003f734dced0dmr4483071wmj.25.1686137935825; Wed, 07 Jun 2023 04:38:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9c00:8d26:3031:d131:455c? (p200300cbc70e9c008d263031d131455c.dip0.t-ipconnect.de. [2003:cb:c70e:9c00:8d26:3031:d131:455c]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c470a00b003f1978bbcd6sm7140839wmo.3.2023.06.07.04.38.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 04:38:55 -0700 (PDT) Message-ID: <02418a3d-ce8f-0f00-ba93-06ceb3531490@redhat.com> Date: Wed, 7 Jun 2023 13:38:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 2/2] mm/mm_init.c: remove reset_node_present_pages() To: Haifeng Xu Cc: rppt@kernel.org, osalvador@suse.de, mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230607025056.1348-1-haifeng.xu@shopee.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230607025056.1348-1-haifeng.xu@shopee.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 93B59C0008 X-Rspam-User: X-Stat-Signature: g9gat3r16hupoxs56qsgtwyxtegipa7t X-Rspamd-Server: rspam01 X-HE-Tag: 1686137940-540298 X-HE-Meta: U2FsdGVkX18h0Nn2i8hGoa1frDFM1LTAj97IIt47RY3pANepQBBFk0oJptqQ9Flh/dhTctn8Svh3buf4Ht0tz2Mbqn3okqjP+KJPWshUpZ14ey0X4B+tXt/8rsoutTIAXzKog4ViieE5qIBF0pwgVPN2f82bQqrVUIlSCqA9zbnDegPK/h3P7qHQ+Hj+8d8x02xO8ksttO2g1OFg0qxLcBcxiQFcJf1RXesGL3od1yzp7kIKliYLzn1XaverRNk7ws4Woeq/uIgr2hn1QnGEOTtLqOgct2qHW40AyGtvYtvx6ni8+8eJxP8SP9lpW+LkFDx61tTPS1g4ew9MSxjsWMJ8owcR1Qra7OndSROHY9tF3MuTkwpqE9YtE1oTxdC2+Fz3WUnFb0lerC71fsC+qRrFeDv9GaYE5uzh66pg6qWhwygOccjI69oAqARCq5z3sod0A6moH0jHGPHhaKKMIwpra6jTRlDGIWf/49jhwrWIt7rNNNArBs1Dt0wGuwX7CL65m0A2YGOBvpPREgIwhG34lChjrfb2c8rw/com6tlOSAe6KtI4c11k4lQcA3WuWJ81pD6GWK5LhP9nHob4in4wd6FdQFvEiU3h+l/U+LiX5SGoxMcQAZJEAmHE7YIBYY43xI+EwZAja5rfyvPqD6HFU0txi8kRphLyt+HyxcoRwL/E34QxFow8BB48PmRHe2QrWZo98/d+HQiDWMVFQpturLSkhQk1I76i0Lr00RJVydXPaYnZWv+jgDk0CsRfgdnsgrBrFekZH5wl0RTpfkwxsDrDyEvRUILClf0kIgob3wqRDWO2LTQ+KnR8nMzQUSd3mayKUBH9vbywSM4yShbj5ZMusNIfT9UVfyoUDqXTje6Gq5acxdk21hWZzp274OvynyofRB1EqnJeAdXvUYTIF1OeY0WpK2NlxacNqvELWEcKSt5Ty7dIuwM8Ksf7ukVMmGWNM8+Lvl7X77J SZGWmHAl JH+25TmTiQUuLMOxlE1rxlPm5gxX8wn+6OAu+H1VCp5Jy7sTaUJhYSiM8gU7ILhgRTbCfgYmdlUzSgbpnnMcT0pAKU/dqYkVy2i6HVrPNVKHj2oMUHde0JaHsKrv0qmV4NoR3vJb1YKos7E3Fh5luteAtmNldeR4CkjoRV1FiG0TU4z8+/WPWAMXicVYCnJCc0uLY8daXXBeG19E5l16CwhH2cmFCjuksGflyAOV/W3jIAsEl68UEuq91FgldUXP+CKIDKudPticrqOXfk4Wj0xhbDheHBpC1+iqFZR1q1WWzTFpOqPGJqE0uN/ZuZc9AFM57fVV+etRIKA07LlUpuvhnltYQ9fBpP1S4UdyzRh8+xBTCB69Rp7u+AxwjrVXpcLkgw6AGdn/oNLLgWp+KSj4dG3pcs96y/Wz31kX7yGYBMJlM+735WRpHHOIJRFcWWHxRctQxEQJ2fGZD2/dKjzKJ2X4ygIT0ANyboVgZ+8A6mgRxNoFOZYKil5nEPEtCPDi+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.06.23 04:50, Haifeng Xu wrote: > reset_node_present_pages() only get called in hotadd_init_pgdat(), move > the action that clear present pages to free_area_init_core_hotplug(), so > the helper can be removed. > > Signed-off-by: Haifeng Xu > Suggested-by: David Hildenbrand > --- > v2: > - declare 'struct zone' within the for loop > - fix comment layout > --- > mm/memory_hotplug.c | 18 ------------------ > mm/mm_init.c | 15 +++++++++++++-- > 2 files changed, 13 insertions(+), 20 deletions(-) As Michal said, we could be clearer that this simplifies the code (and removes a TODO). Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb