From: David Hildenbrand <david@redhat.com>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: rppt@kernel.org, osalvador@suse.de, mhocko@kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm/mm_init.c: remove reset_node_present_pages()
Date: Wed, 7 Jun 2023 13:38:54 +0200 [thread overview]
Message-ID: <02418a3d-ce8f-0f00-ba93-06ceb3531490@redhat.com> (raw)
In-Reply-To: <20230607025056.1348-1-haifeng.xu@shopee.com>
On 07.06.23 04:50, Haifeng Xu wrote:
> reset_node_present_pages() only get called in hotadd_init_pgdat(), move
> the action that clear present pages to free_area_init_core_hotplug(), so
> the helper can be removed.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> ---
> v2:
> - declare 'struct zone' within the for loop
> - fix comment layout
> ---
> mm/memory_hotplug.c | 18 ------------------
> mm/mm_init.c | 15 +++++++++++++--
> 2 files changed, 13 insertions(+), 20 deletions(-)
As Michal said, we could be clearer that this simplifies the code (and
removes a TODO).
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-06-07 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d92273f6-28be-dc37-3ca5-a9579a75f8c4@redhat.com>
2023-06-07 2:50 ` Haifeng Xu
2023-06-07 10:33 ` Michal Hocko
2023-06-07 11:38 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02418a3d-ce8f-0f00-ba93-06ceb3531490@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=haifeng.xu@shopee.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox