From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF2AE7717F for ; Tue, 10 Dec 2024 11:05:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C91636B0177; Tue, 10 Dec 2024 06:05:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3FEE6B0178; Tue, 10 Dec 2024 06:05:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92D96B0179; Tue, 10 Dec 2024 06:05:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8ACC36B0177 for ; Tue, 10 Dec 2024 06:05:34 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0148D4190C for ; Tue, 10 Dec 2024 11:05:33 +0000 (UTC) X-FDA: 82878768126.11.7A325B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 99B75180016 for ; Tue, 10 Dec 2024 11:05:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I1jAJcKU; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733828721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fZcVe/5zuZ/V5Y6RxXliwxtDw1Xl/IijHe7b33hj10Q=; b=3VJlMKWj8rD/VBGudekNkJc9qR6zY4e6C0pLrQGJ+MLhQrMOna6OCC9LW+JKr1OKvketbg xqQ0Od6lyK/+GuNr4YVzGakWcXvtlO5zCDog6XUDctMD+tLh5VL5vUm8WavgJhu7VZEnXs DOH3aVIAuUK+GFMTRTv562VWGojrku4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733828721; a=rsa-sha256; cv=none; b=p+spFGpQmaSh0usSELCVKtp5W8ZuRMKZd16uaNocKpq9eIQEfuuELxg//bcjG7TGZF/OsY kYzgA+x0UJuf+xa40q/Y+hS75ph9YNQwkZYxn1QwohQGvH/VCbZl85hlfC7+AgjLXhXbww pVOXAc0e+pkNROPHEWFchrI+Ind/IRg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I1jAJcKU; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733828730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fZcVe/5zuZ/V5Y6RxXliwxtDw1Xl/IijHe7b33hj10Q=; b=I1jAJcKUDC4gKMsucPPeBAjNhbWtIZHdThhwUYLgDE6D4ICbHGdBOO41KbfMyqQWEBlgCV QKGGKMu31IyiLUUpSVpC8VejgDAoM5a3F0xNhel8o9oC6HhtB21fwM8jvLHk5/lnraqXyB BF47hjHDKVzSOeFglLlorm7MUxbiWvc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-odKCoOyaPiC5K2dvgMLIJw-1; Tue, 10 Dec 2024 06:05:29 -0500 X-MC-Unique: odKCoOyaPiC5K2dvgMLIJw-1 X-Mimecast-MFC-AGG-ID: odKCoOyaPiC5K2dvgMLIJw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4359206e1e4so4565135e9.2 for ; Tue, 10 Dec 2024 03:05:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733828728; x=1734433528; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fZcVe/5zuZ/V5Y6RxXliwxtDw1Xl/IijHe7b33hj10Q=; b=jWkwy9ukmXEG6fm03Le+dVC+fMujssvP86qfy2V9weqAl7QyxRXCEBDeTW5sUe3mwH L8SFlDFbNQFzRI0rN4ZD7zBlSWENX0j2FxgXKGOxIKFDvzlOS35DDY7Kq+QUmTbWJjxk 0t6Gwd6RAEQp2dPZngU0qM7G5et6X7bqA5Z47spXvx7exByZFdnwQqo2/vbe0duy7vul aOTmG81aSA+tQIwULJ/tBJ//tLCBFb0327tFQrUcROF6cmbmCLO4OMhSiaexAcYerIWT AxAWnq5r8pygpbSDgvlgh/prR3QF5fM0cVl9EqmmSrIOoY3bC2NTR5IRr7ChvRE0FwvB DnIA== X-Forwarded-Encrypted: i=1; AJvYcCUGBUJEojuq9+3TPdQ0hjo8Xol2o40BQ5NFQXr8iMaVCtn5v9L9iZw6xd6UzguHRyPHWlllJx/qgw==@kvack.org X-Gm-Message-State: AOJu0YzemlH5kSTqkU4NLpLiD/hY5CNxkY/VgehqqAK84KB8XVMhWugg A6AmM8ZKjjwqOunmIdQVThJeaZ2nIZBYotm6D9yggh+9MjeiwmpeYkGNlV0j6nscUF9SMvL/KQ+ yVqAeW8xdPBg9bL/z4wgJtudSlw9ioUQZcweXYAhPvN12PpUbDpg/5AEe X-Gm-Gg: ASbGncv3nquVfcdZmfBJnGk4QHo6Ywwb7ow2CCOg4O7tF1ODtepn/CFzY1mP0Qr3otp eOsZcTxjIQLhn8Dz3+1MaaWveVaSQlTXg/pkj6zsY2Zq8JLdNkcgB63x4f12aH5O7G/XgxSEFhX lk9r4aqUdru0H/wTp1uvyrxV6U+RY5YNVLsv3VQS4GWTKtxHpnfSXGjTqChNtOX1GOn9oHr1m/k 0AIBHIGv4X/68e5szhnp5ISP5jxr415NBQNTza+wN8oiXTzPb0FWfoKBmmkcOpw9/pSIPlb5Cuy Bm9W3OdqanmgobYFdh7kP2uTn2hv9yjM11zO2kl6/WgoQdixkaUB+/ZzPM0AznFz0WlA6GRWQ9k gzSZjIQ== X-Received: by 2002:a05:600c:458c:b0:434:9ec0:9e4e with SMTP id 5b1f17b1804b1-434fffba059mr44053865e9.30.1733828727886; Tue, 10 Dec 2024 03:05:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmMiNJbY1TFcSyI+tm1/HJE4vK538VL1akxE/9NqvyW5iMwBw380e0W+Rgkka8ZcfpLKokug== X-Received: by 2002:a05:600c:458c:b0:434:9ec0:9e4e with SMTP id 5b1f17b1804b1-434fffba059mr44053235e9.30.1733828727234; Tue, 10 Dec 2024 03:05:27 -0800 (PST) Received: from ?IPV6:2003:cb:c723:b800:9a60:4b46:49f9:87f3? (p200300cbc723b8009a604b4649f987f3.dip0.t-ipconnect.de. [2003:cb:c723:b800:9a60:4b46:49f9:87f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3862190975fsm15434782f8f.68.2024.12.10.03.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 03:05:26 -0800 (PST) Message-ID: <023d1c53-783e-4d6d-a5e9-d15b9e068986@redhat.com> Date: Tue, 10 Dec 2024 12:05:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Removing page->index To: Claudio Imbrenda Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-s390@vger.kernel.org References: <20241209183611.1f15595f@p-imbrenda> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241209183611.1f15595f@p-imbrenda> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qGbt2S2flSGX2sK5FypETiEmmX6_vE5gcvAlUAHqqwU_1733828728 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 99B75180016 X-Stat-Signature: 37sfc3brpjiyotfejxnz79a3dz1qicz1 X-Rspam-User: X-HE-Tag: 1733828728-354289 X-HE-Meta: U2FsdGVkX18X51esV1vsrDrUdCFG3eHys7rQKeWR8CtSCaVBn1WkO8CFwA17ieqSGLJWmdHkEzbbwZBIw5Ann1tZarHW3XyYV+8PH8eaUuOrH5Z4+LNdYXlcgvjISvpxn5xr8xUEwNX8QvFrn+zXj015P7nT1BC7KWyHkUlWckKQa5Ohu70tCPUONuZxQcwjlpGGSIYioKRAaovQUj1vZfHRAey8noyZLfawqfwZJPPPl7gE4wmrPrI5VL9sS4CyviRSb0eFpjyNcokJNRyG/20jArTQPEiDhGeKOGdRzF9xUH/H6BWxQawkrx6bnfnKDjmCQ1wfC/hmM4esILpb89UCz5IPuRH5oU+lqSZRc7luo0xaWgUz5pmA0kpPPXyPpsxLmt7r1FiXyV2Noz8kGEMps2bUTwec6Zkvklco0hAutiK/4PlQ7Oe/fuIgdMlWCer9wdOSXIr4YehpIOm9gdra1FbjdCrZB9CT/JQwRcaIa2UdiN9G0sXDPkc0p/LqDwfi59OIWoSLlQ8mprHvJCwahOXHYirlOrGpSG/eb0Dii+7ev3cU4yWCn0je/43LVztUk962wlmGZgBaYfE3c2bFlcYE+7IGr2EMoYQx/8WVnoEyyCTyuxiRcb8IJkuICh++UZBY0FMflkvu6suigWSmQjzlAFEeOLL4y/WnJVH+/PgiU5e0gvXiyL1JfznnX+tAdpNV68alrw2Lwqo7kV5JrB7vNU1C+czt6VDtrsGFTQTHgxfgAkIqG+BVJQW2mo3UY86uJaE1wmtXF7mplGw06VhmTmFKsnvzdyInuo046oTtrU85Na5yiwp6K2+abSxW5JXXtpqdPtuQmHbXN8m8SEfUJPGZP1ZZbo7A9a8lA6NJ2bHVwRMBhmP6Ta8k4BpVSOtW3q6TsKPsjM3S0jANijywPlYa040etiwfaNOmPKUV6+QCLY8BSyytsXlKXKM2BVR4vsrCNAIDnSD hewel5lY nfEdf7q1EiLFxmoRAs2Q6juq8v3+1wE6bYrXM3x+JDlaoyxFAOUtmjNm0iN7FK7fGk27syXDpKSdn2J6bqMPdEFxgRcLj5YRZGWAWxBUAs0FC7UP/w3RdK9CJCW6K8aXwm22MK+U57DmVef2iRdvwF8l5zPdyVRy2VtmsjlWytT0/qrFxvcfEjnLGQOtG3b/ce+CxOZm3MYPTpfqaPu+bYEmgZv4+te8Xz1rT5S9P6aSf6s45xWoTN964a/luurIB5rxFslfCOmwMWllDjvZKQA7UfXGYZ0EFthgcKFcEoP4gipyEhrQ5UTBTEGyMWWkeoZcxaOWjAAKsvepZbrTBuo1336yslOQYWH+ROoP3EyoePy6ElqqN78ls5pmrETMJ44kb0OanaTauQw7R/PRKQ/5OdfdCkcUUIzQA19PhCoyg8aoCJu5dmTuP2diWGKOMTbF4uv/F8vtgvAqs46KiuSP066iTUXcZmJ4z X-Bogosity: Ham, tests=bogofilter, spamicity=0.035424, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.12.24 18:36, Claudio Imbrenda wrote: > On Wed, 4 Dec 2024 16:58:52 +0100 > David Hildenbrand wrote: > >> On 03.12.24 20:51, Matthew Wilcox wrote: >>> I've pushed out a new tree to >>> git://git.infradead.org/users/willy/pagecache.git shrunk-page >>> aka >>> http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/shrunk-page >>> >>> The observant will notice that it doesn't actually shrink struct page >>> yet. However, we're getting close. What it does do is rename >>> page->index to page->__folio_index to prevent new users of page->index >>> from showing up. >> >> BTW, I was wondering how often we convert a page to a folio to then >> access folio->index / folio->mapping and not actually having a folio (in >> the future). >> >> I suspect this will need quite some changes to get it right, and I would >> count that as "less obvious". >> >> Calling PageAnon() on anything mapped into user space page tables might >> be one such case, for example. >> >>> >>> There are (I believe) three build failures in that tree: >>> >>> - fb_defio >>> - fbtft >>> - s390's gmap (and vsie? is that the same thing?) >> >> Not completely (vsie (nested VMs) uses shadow gmap, ordinary VMs use >> ordinary gmap) , but they are very related (-> KVM implementation on s390x). >> >> I know that Claudio is working on some changes, but not sure how that >> would affect gmap's usage of page->index. > > After I'm done, we won't use page->index anymore. > > The changes I'm working on are massive, it's very impractical to push > everything at once, so I'm refactoring and splitting smaller and more > manageable (and reviewable) series. > > This means that it will take some time before I'm done (I'm *hoping* > to be done for 6.15) Thanks for the information. So for the time being, we could likely switch to page->private. One question may be whether these (not-user-space) page tables should at some point deserve a dedicated memdesc. But likely the question is what it will all look like after your rework. -- Cheers, David / dhildenb