From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF80C3DA7D for ; Thu, 5 Jan 2023 12:18:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E03C8E0002; Thu, 5 Jan 2023 07:18:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 367E28E0001; Thu, 5 Jan 2023 07:18:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E19E8E0002; Thu, 5 Jan 2023 07:18:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0FE9F8E0001 for ; Thu, 5 Jan 2023 07:18:46 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E04BA120D6A for ; Thu, 5 Jan 2023 12:18:45 +0000 (UTC) X-FDA: 80320649010.29.2F6EB19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id BCF901A000A for ; Thu, 5 Jan 2023 12:18:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K0YLJJup; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672921123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UpuMYEsePXzx9kv6GFcWl6NcxTKfD6zAAzJE3ZeIEQU=; b=H8ED83YkOpkBtjFUMz6iPE6pbQJ2r+SZStlXM9bYtO22/lEL7FJC7lmO3m+ho6Dmu6bvzY qvu5LVlHyqljz0uMuLaQwy5B2BL3av1Sdgg7BG/cNnE8wOZ+2LwDo7vBkJkM4bDp6XHsNQ DM6mXJTG9d+sq5fm3Pn6infM+fVa2TA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K0YLJJup; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672921124; a=rsa-sha256; cv=none; b=n6SY+90D/FUAPFc0zN+48tnfA6M25qqvB8RoWrzxiDSWIkb8YMRhD3Q9Uc9z+dQBJm/ref TvLyVwiF+sWXZPt5f+MBt+sik1p0iHZN4Zr6F8J7XoCWw8vw9KMncZmUgByg+SHOcsLAlV QMHj9egj8C7vIta++8o3TX4T7uCB4K0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672921122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UpuMYEsePXzx9kv6GFcWl6NcxTKfD6zAAzJE3ZeIEQU=; b=K0YLJJupxBrAqJROa62g98AZ8E5BQjNnsQe/FAUCltcibStAtuWKlBhObPdn3rwN4gx0+w R70lH5UZoIS/5Pev30WK6rP5KkY3p0u7stvWdlwxU7o/gISZfrtsMv9p0i9bAQ9plQjvEO XlGOLJcibwkNCaxjn7OJd/r7t8dTySA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-180-EEg3yjm5Pl2ctnnS_fjuHg-1; Thu, 05 Jan 2023 07:18:41 -0500 X-MC-Unique: EEg3yjm5Pl2ctnnS_fjuHg-1 Received: by mail-wm1-f70.google.com with SMTP id l17-20020a05600c1d1100b003d9a145366cso9479813wms.4 for ; Thu, 05 Jan 2023 04:18:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UpuMYEsePXzx9kv6GFcWl6NcxTKfD6zAAzJE3ZeIEQU=; b=xFS3Q8UcadxMriu7L1M1YdVMDHI+7wEdjmJoADxYvFgPdx8tysZPl5ojGQJWM5Q27v tmWzZlxJ8v7Yftqfw9Gzl79ZuY2s2ghsOuzweaP6HMF/0SU+/NdKAFaQmYJqevGplyQP g5EOJm43f57dh0fPaqeTKQ1xfMpvqE80YntMOuU6CzOSY4xzbVT4/COu0qsQRmGV87ZB VPClAkjLHjOMN6bZCF+iyYGtchil23BeXUVd3umRv5NmmVCXQeXsP6adSgtDaAPuHZDJ BWupLnLt4Qr/yfyCoJzYQ9FqHuiwc+umZSvak1p2hZlZK8RDeLVq3f0BZlZOwGM7mSLE iQZw== X-Gm-Message-State: AFqh2koMun8wj55F44nBh2i0aiFVbYujzXqGbCidHVvkTFlmJXePZiPe nr4jHVSfLO1NAw6LKT305pSP4lemsjqfwEu/GHrwqnnfF9ayZzHjkfAJFeaWs6h02mtLSqvonI8 9k0b+B6c4xQM= X-Received: by 2002:adf:e19d:0:b0:28f:29b3:1a7f with SMTP id az29-20020adfe19d000000b0028f29b31a7fmr15595033wrb.36.1672921120492; Thu, 05 Jan 2023 04:18:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXvq09fSoIEeG5qGPLrKcrVN6jrNUhwHquWZJZyMNzUSQSucWjIritMW8MPP8tUoPSh+7mQ1vw== X-Received: by 2002:adf:e19d:0:b0:28f:29b3:1a7f with SMTP id az29-20020adfe19d000000b0028f29b31a7fmr15595018wrb.36.1672921120215; Thu, 05 Jan 2023 04:18:40 -0800 (PST) Received: from ?IPV6:2003:cb:c707:6e00:ff02:ec7a:ded5:ec1e? (p200300cbc7076e00ff02ec7aded5ec1e.dip0.t-ipconnect.de. [2003:cb:c707:6e00:ff02:ec7a:ded5:ec1e]) by smtp.gmail.com with ESMTPSA id d14-20020adfa40e000000b0029d9ed7e707sm8462775wra.44.2023.01.05.04.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 04:18:39 -0800 (PST) Message-ID: <02312607-e399-b859-ffc8-ea65a560fe3f@redhat.com> Date: Thu, 5 Jan 2023 13:18:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= , Suren Baghdasaryan , Andrew Morton Cc: hughd@google.com, hannes@cmpxchg.org, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com References: <20230105000241.1450843-1-surenb@google.com> <20230104173855.48e8734a25c08d7d7587d508@linux-foundation.org> <22aab888-75c1-ffad-d72b-f87c9d9d80c8@applied-asynchrony.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <22aab888-75c1-ffad-d72b-f87c9d9d80c8@applied-asynchrony.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BCF901A000A X-Stat-Signature: qg1ikpigczj5ajm1dyuee9m46bdic8d7 X-HE-Tag: 1672921123-204006 X-HE-Meta: U2FsdGVkX1+LeuhaVMyT7GdZF2MMQ8y7Q1SCYcjJ9lYoP9Mf2e8G83gVfbubw0H3pJmJ2BuXrCBGl6DCaxDg7qfjK2Lh8tN+Qoh+YbvIf/Jp+6xT8xDzpbPxkuR6Q2kh6/oy2ye7WZQcyqBw4Z//l37CB+dulQHa0jIPXaNQBkWVaqN8VV5TpYgLhc4ejaE4y8VMk23lmp1WyF1DjsWAbYljsr6PaYpyFw2s8na+2mFEHESA+NxWCUU7Bsj5SGIxbnMo65ef9vYzvFBTZYeHS8psK+zyeBb4YU6k0irDeeju5rbWoLhGPBfhzf1eF4WqELVAKAqCETxyWPtn7Tah2e3b1FKdKc7PmuA4OCNd0KF3ua2nM5qDRSF18XMukfN6cOD3L+OodELHhV2vuNeErlvt6msl/g3uYmT5B7JVQn/YhOY5HtpqlHl+2NkhqxOyx05ru4lQXMbEwBkCuUhEDKAS7qM3GBAZsr3PUluyaYNPUdJUR9bAg3/ztAVwQUCX52Y760HGNtEbii5ZC3DNvhXC/xF3VRa7c0w7w9F6RaVkFnhT3veEk6vNcGR3z+/Hd24sAMrqkCZ8zxNE/kAjNltmiJfF3dn8wdt0nj7uzGHQNNTvI7wMRu4CTkErsCvchFLl/PoHxx/Tqchya5nQfY3JOUlamX3t7PMlerw4nY6rASwmRqedhiZ0vCaAS5/sBarGKAG0q3WCaxG3hPG1ofQHv/p7BP3CtPvFLNKP31eM1mk0hu35nyp3q8/BtUrabW9Bkj7VACaSzpqjc5Yai7uoN8PvDot71lwQUTqGqnRuq6I5qiBmHucHb/JXlA8EqQmHp+skfBHZ8fpGMgDc4HRmXUM1UqM9NfM8de5qw+QgyYN/Iwdp4T31vQAUhKLH3avPCrZ3wjp4TYLwz/g9DNTxr41WzVRoe8/ZDfgR40OrRT0bbkUvUQZ2wcWgrKJY7rJCmQH/wvIPB/W62He 0xKRcYRs PGpv9ZWkhDXKorXIOxI2i5B/v4enkuEGoBxAbZZsWh/WRBia7kJR3m69fjlq0eHI785zTAwq68ckdriFSCVluSOwYM4wKW1DJ2P41KSMaDdwUXuppsdc6KI3n7V83itNooDqC9D3uNQHw9ttW6P4apr4f9TxObA87uGuoOF6s7FUn4ldtU2TytQnLDG9fnIcgW+hRwwKmRiKhn0Cejbeq6El34CgP/9DbVmMygtpw+z+pSPCiotS24hosc1IApmT2dWkYnlixpZX0DraIPZKTTi02oltXjviUFhLe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.23 13:07, Holger Hoffstätte wrote: > On 2023-01-05 10:03, David Hildenbrand wrote: >> On 05.01.23 03:39, Suren Baghdasaryan wrote: >>> On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton wrote: >>>> >>>> On Wed,  4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan wrote: >>>> >>>>> free_anon_vma_name() is missing a check for anonymous shmem VMA which >>>>> leads to a memory leak due to refcount not being dropped.  Fix this by >>>>> calling anon_vma_name_put() unconditionally. It will free vma->anon_name >>>>> whenever it's non-NULL. >>>>> >>>>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") >>>> >>>> A cc:stable is appropriate here, yes? >>> >>> Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC >>> stable to fix the previous -rc branch? >>> >> >> No need for stable if it's not in a release kernel yet. > > Commit d09e8ca6cb93 is in 6.1. The fix applies cleanly. $ git tag --contains d09e8ca6cb93 | grep "^v" v6.2-rc1 v6.2-rc2 Doesn't look like 6.1 to me. -- Thanks, David / dhildenb