From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 722D0C433EF for ; Wed, 11 May 2022 03:07:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE00B6B0073; Tue, 10 May 2022 23:07:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F176B0075; Tue, 10 May 2022 23:07:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A090F8D0001; Tue, 10 May 2022 23:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 90FA66B0073 for ; Tue, 10 May 2022 23:07:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5612021EB7 for ; Wed, 11 May 2022 03:07:06 +0000 (UTC) X-FDA: 79451975652.28.F4A4106 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf22.hostedemail.com (Postfix) with ESMTP id D2737C00A2 for ; Wed, 11 May 2022 03:07:03 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24B2xk4d024462; Wed, 11 May 2022 03:06:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=ZR4PDitwBlOB30CLl5g3l1oCfAfZLMlpjd+Q/6yae30=; b=l7THDnL6mzrqGsIvWW6bJEMlgk8FCA8Y5tQhJ+tejuO2pNF5TR9ysZ3yO9gtPyF4jlhy zH9GR5FMljrSMOlgwUq+TxBhgDNPB2JwkZTxT034kC/EacR8gEOVSgszxq8zA0hY0fws vxFdsX0v1sOEYPJvWHf982WbxTpb/0V80HVHJxVfiQGoxaE19fZ8YFYPMbfpRp1R9gay qFT0p4MLkmxr+MCAeAf51w3nrkzAdXdmUzaOfdlPySKHDE778DHvOLCrs4AgatKuLwDd hHuEI2bXNg3YsScP8DhZJDgMkElNFdz+9aaCYiDVbue5TC9RVaqIF1ImRM/1Oz2Urs7A 0A== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fwfc0reur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 May 2022 03:06:50 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24B354N4029517; Wed, 11 May 2022 03:06:48 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2041.outbound.protection.outlook.com [104.47.56.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fyg6e8g01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 May 2022 03:06:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YL/v7rA0VqcqSNzMsM0JP4pQ3DCPbaPQvXM72AGfsnLHR7K2EWBwNS/UlweUFsYj2VrySeb4TCMvCOps6JWiZZ1Qst34X83QBEdwCWJOjW0sS0JBnXg4B7xHUxTnEAggP87VHcBQwss30GSJDS4bzCB7yxVjUKyHQfa0v5CocgnP0rDXFXk5GYPjSX0D0HcIhTa2PCvQyPsjrRwu+Va9Vxd2v1qYvENLZlj+Z4BgcEBGMhKRa/AvIDSq8XuECG/nD4WRMdSXEnmZg4u7iMbIoiihRjdQJsUckanYHJz+UnbySrCGNy2fCqoZeuBd0I66QcgmsHGv2h+kpcxq0TfXDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZR4PDitwBlOB30CLl5g3l1oCfAfZLMlpjd+Q/6yae30=; b=YTfBNVR5TPPGwkAaCr1/eI75ttcodm0lIAFEmV679QPzNWUKUDHgQt1QrmazPaQdAdq+7+ORgyBDpDw+bv1C6E/4omKFlxyr9uUdgeRlJF6uZthZB6TIyzjKykVRozYit9ScBDmpV6V6fbgE9zhiqTgrG1qM6AkQeJ1DneNSb5Saxam6lNyrLmKbQHF6/iY6x4BQ0WrJVGQFuz6IDPZWD2yqYPsZtHSOtal+sGg6CjzuM5joc4HpLQJ/PPXfvXRB8sIw6bE1Qg/jTYEmusekEJAfPudJUJodRasE9agkkRI/Om1CjZwMWebZePkEGVbOWhfkQDzSFzzJ2S9d4AuOZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZR4PDitwBlOB30CLl5g3l1oCfAfZLMlpjd+Q/6yae30=; b=gLmIZVYnmtXHhj39cYRv89a+C8ZYzAzqTsF/YGCVFSufFC6XKLIAO4uQrAHmbcyFaQ6nUYCgNpi7g/mLVg6h799wLiAY8T0J2PZb5ptU2HJtmtEzCgFBD2+REUFPlq4RLh4P/JUI/LtOcR1p6S47aJfHLW3eCTGOXnyWQrYvHdc= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by MN2PR10MB3663.namprd10.prod.outlook.com (2603:10b6:208:111::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 03:06:46 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::9d76:7926:9b76:f461]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::9d76:7926:9b76:f461%9]) with mapi id 15.20.5227.023; Wed, 11 May 2022 03:06:46 +0000 Message-ID: <02285994-89cf-18af-2047-ca576fff9565@oracle.com> Date: Tue, 10 May 2022 20:06:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 18/26] mm/shmem: Convert shmem_add_to_page_cache to take a folio Content-Language: en-US To: "Matthew Wilcox (Oracle)" , akpm@linuxfoundation.org, linux-mm@kvack.org References: <20220504182857.4013401-1-willy@infradead.org> <20220504182857.4013401-19-willy@infradead.org> From: Mike Kravetz In-Reply-To: <20220504182857.4013401-19-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW3PR06CA0017.namprd06.prod.outlook.com (2603:10b6:303:2a::22) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1caccf69-096f-44f9-d67f-08da32fb48a5 X-MS-TrafficTypeDiagnostic: MN2PR10MB3663:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FHkTsvCrSIquoQ8EkmpJjkMtklq1r2eOn6OWlGhPBp9OD5DL8kjD4xav+MwDSQEGedL7tac8n8/uqPjcGRtbcxwxSgdPwYcJVTfjwDCX7Sgfe7BIjGBI2p3W22pwa3xZ8KM4Rg5GpFxU4g5vNsgyar+T2PVO9hDAZGwBf+JOgkOhcKnXPYdxks0GB7cYkIRDvrR1xYpNN1L5QN72Uv/UQqFwWpgx+Epv2w4/9l9aorle5vay9p6koe6REoagCBGtdCLstNKY5blmc73p/vwcbec8Mwgp6icybb7Hn2H2SCg6qjurWwZjKdPYT7NtT9dcT2bTBMtHsIaChNLTlW8lLq54q+DK2AZGhr5Qf9H+ZwUEQLABovpN340YgQXB8rSdZrFT6xjadDQI0MM4niprXyOwsMh6JhhN/RaNGBXtviDKOKXhLOBXV4rs1eIq5Gep670o+3Z4Uf1t1FrZFH7VHjCuhViDmI/PMeg+X2XeqUzoAcdwHthUO369YD1VPjfgFdTcS38FZE8HF9eYw4VifQA1V0MJkEI29w17wlcVHlOKCBjatLD/+MQv/HHr9bf9Lsf3+nP1Dsn6nFeEcSECAk3mooPrMkOoi0dl2KvGmPjwgeGsELaX3LFtA0rEWwX1bBc1hwkef51iDlIGs1MSdriUKkkrNVrfoKx4rr4weZbcjZjFoAh6pfLCzxkQZNczSKYmral1kDXibre6Kjv3rVy6H4x0PbPo7HDmjXh10vkNpbdQ07REKo2MukYwd0gR1VSOWYhBnJUEfZw4+uUCbw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(86362001)(8936002)(66946007)(2616005)(66476007)(53546011)(31696002)(6512007)(6506007)(26005)(52116002)(44832011)(38350700002)(38100700002)(508600001)(8676002)(66556008)(6486002)(2906002)(31686004)(83380400001)(5660300002)(36756003)(186003)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmJ0ejZOei9CbkpDYzlRbDI3OTc1WVd3QW5qMXEweURwK3lqckdneEQrWXVJ?= =?utf-8?B?Ly93WTA4UGJBSVYvSlUyT2trSUg1UDlzMFZNNmxyYjdvTzhZUXZvbmdHMFI0?= =?utf-8?B?NGpCd0dGUWtEbVd2SzBZTTBlWVMrWkVvcjlJeUVna1pPNUpBNnVPL2ZiLzI4?= =?utf-8?B?Nms0Y0ZNN3NQSjRqa2FXd2xPclYvZDI4VHN4M2RvV2FyS2dWYVhFY0xMOHRC?= =?utf-8?B?VWhrVkhjbW0wUER3bk5hcXloekQ2QkcwWEFJOUx1WEtibXlOSW9WOFh5Mzlq?= =?utf-8?B?SlBJR3JVZDRmUTZaOFRHUzNyQkF0ektFTjhkZGVraE1IdXU5Z1UxVnpQZjlC?= =?utf-8?B?M1NBY3QwK3BFME82NFAzbHJtZzhDYXF0VnlqaGE5MUVJb2hLTlB4TnBZdDc5?= =?utf-8?B?c3NWdkd3ODhiMFdwTE05WFd0cWtaRzIrS2RIdDJQVTV2aWFwL0xqa1F2enNR?= =?utf-8?B?MklEZUhKKzk2R3NEN1gxRDFYbkk3ZnVRa3pmYWJtL0tESEd5RnF4OWY1QWRB?= =?utf-8?B?bkJhbmlJUDJkU21mMlpIdFNyWHpFQUtBdThtUkNMWHRvYitoc1hDZ3o1QUY1?= =?utf-8?B?ckxlVUxZemF1OEJMaTVWQWxyVjV2NkhCQXZaQWUzc0drblFzZ2RXRk9nNUVL?= =?utf-8?B?WjQwMkxGTDNnejdSQXBoS080YXZMNG1UQXRwK3pkTGlhTWNQNm9ueHNSTXpS?= =?utf-8?B?bWkySEZFbDBGQ2ZzRzR2N0JGRVpXbUhXQ0lsVEtHQjA2ZjB2L1RPd0ZCcXNI?= =?utf-8?B?UzJPb0ltZjVaeHhENWJPTjl3N0ZaZ3IvOEVBNHZuSTVkMHk1T2srZENsQVNR?= =?utf-8?B?VG02NTdrNlRCVE9naStXUTVEMkRicFNIVWdHN2VFRGxjb2hCcW1tZXhLcHNW?= =?utf-8?B?UTlSc3BLSXUrekxNbVQ4RVEzb3RxZmJwOTBmbFNDcjgvWDloQU9WQmRpeHVh?= =?utf-8?B?cklVZ1JLME9yaTMwQW9ZUnpCaFl2SjNOTUxKdUZNT1VhblBvWEFnTjlhVFpq?= =?utf-8?B?OFNtTFpOQWloL1VUVjFHVWF6Q2dOQUNCejBBMm5VUHJ6SFFQU0lsMU1ZRDVt?= =?utf-8?B?SHEreDZLRmp3T2JuYloxUWc0OGFSOWdSc3BkTDc1RGk2d0JmNUcxalBIV1dR?= =?utf-8?B?UTNKY3FwUldyNVpqNGRxdG5URitUK2NaTk5XNWFsK202SlN1NFpvQlhOSHhv?= =?utf-8?B?WGxjd3ExMitxQlFBYzlENDA3ZElVaXprZTNsbkVZSFVoM0RnSk9MTjJKTWE2?= =?utf-8?B?bkR1WVdJZFRSVTYzS2lSV0R2N2lvZDgwSG5BMFRaaGlIc2s4ekRaRFkwQjk3?= =?utf-8?B?K004Q3NKeUQvR3RvMTIrTkIrUEx4Ti9GQXRLZEFxalJiNHVYNm8xK0VwOFAr?= =?utf-8?B?RXVoclFVVEM4UzhiT0xMbkE5c1Q2T1hQODJEVWhWdVJOZ052KzNYaFMyZVRs?= =?utf-8?B?T0xOc0VsQ01EM0RQbHptZC9iK0Q5QlUwSElmclRJMEwyeDNoUmNlcUJndHgv?= =?utf-8?B?bEsrc1pqbkpUaE44Y2JVcDRmMXlGUmp0RGxvQ2UwNWpEb3JrWmwxZnpVUERp?= =?utf-8?B?UHNQVWVidmJsZDJGOHV1bExxTHZVMm5kVWtjVi9RTHRPaWNFamM5N1dScnkw?= =?utf-8?B?QWlJN2NqUkExNkFCeTN0UUpBMEhQa2ZZR2FjSHNLT0RXK2kwRHBpdmowSVhZ?= =?utf-8?B?bVJubFRwK1daSGJHbjc5NWZCYzRhZFgvM1V3NEVLNlJUa3k0TlpUN1pqRC9o?= =?utf-8?B?dXdvS21XSGUwbnNNRFpHR2pqZGRJUUdkZjRVWWdmMGEybEdONGJMSVd2ZFFa?= =?utf-8?B?NHpFOFcyTnk3azArWHRndVhCTTZSYTVDbkJmUnVJQjJDM2RjeDR3eVV0L3FJ?= =?utf-8?B?bjkwTCtoUVNHd0Yvc2JUTzB3WldGVWNlaDBNKzhJNkkxcFRnK3RoWW10QlQz?= =?utf-8?B?cWtRUFBzRWZackxRV2hFTTRPL1JQTnkreUtyTktkY0xMZGpSRlZxRVAxU0Yy?= =?utf-8?B?VUhpM3d0QTFKd2Npb0lrSVdBbzVnYVRsZ3U3akY4RlU1Y2pDTDNPYzF1dE1v?= =?utf-8?B?cDluWHByQlY3dEJEUlBMam5SK0hLQzFLSEhKQXlOdTl4S0RnaVBySjVvakVL?= =?utf-8?B?YmxSRDRUTlYzVWV0eVhKdkxzRVl0QlZGeHVpdDBhd3BVa3dFZWo3QXVBeFF0?= =?utf-8?B?cmx2TEQvRXJOdERJaWRraXkycU1yTHlka3lLaHFjSVNkTzBqUDhGRFJ2WFl4?= =?utf-8?B?UDY2VktIbTFwRmJablNlNVpEWkxTWUZwS1FtdUxPK2xFbmhteDNiT2kydFY2?= =?utf-8?B?V3ZyNDZrSWtsM3ZiQmc2NC9TWWZ0RFU0RmZaaHQ0R1BvUnVRNldKWkp2cUdq?= =?utf-8?Q?EJIeAX7rY2YWaLiM=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1caccf69-096f-44f9-d67f-08da32fb48a5 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 03:06:46.5385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Aw7FZ8vESj/fKL3TXuyt0Ynxv3ScdSxDvQnvXqAam9fsHSM7dFHmc+QwF6PSnKHlsYP9DzXOeQ4S7kE99rQrlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3663 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-10_07:2022-05-09,2022-05-10 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205110013 X-Proofpoint-ORIG-GUID: TYiisP4DXBSgW_87o1blFmmOikIpNMX4 X-Proofpoint-GUID: TYiisP4DXBSgW_87o1blFmmOikIpNMX4 X-Rspamd-Queue-Id: D2737C00A2 X-Stat-Signature: 8b8up8ud7iib3epf5r3zkrbjh8ysx71k Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=l7THDnL6; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gLmIZVYn; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf22.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=mike.kravetz@oracle.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652238423-578 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/4/22 11:28, Matthew Wilcox (Oracle) wrote: > Shrinks shmem_add_to_page_cache() by 16 bytes. All the callers grow, > but this is temporary as they will all be converted to folios soon. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/shmem.c | 57 +++++++++++++++++++++++++++++------------------------- > 1 file changed, 31 insertions(+), 26 deletions(-) Hi Matthew, Was building next-20220510 without CONFIG_TRANSPARENT_HUGEPAGE set and saw this BUILD_BUG. Looks like it might be related to this patch/series. ./include/linux/vm_event_item.h:148:30: note: in expansion of macro ‘BUILD_BUG’ 148 | #define THP_FILE_FALLBACK ({ BUILD_BUG(); 0; }) | ^~~~~~~~~ mm/shmem.c:721:48: note: in expansion of macro ‘THP_FILE_FALLBACK’ 721 | count_vm_event(THP_FILE_FALLBACK); | ^~~~~~~~~~~~~~~~~ -- Mike Kravetz