From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00049C010A1 for ; Tue, 5 Nov 2019 10:19:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1A2E21929 for ; Tue, 5 Nov 2019 10:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1A2E21929 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BCAA56B0006; Tue, 5 Nov 2019 05:19:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7A4C6B0007; Tue, 5 Nov 2019 05:19:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB7556B0008; Tue, 5 Nov 2019 05:19:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 9679F6B0006 for ; Tue, 5 Nov 2019 05:19:15 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 4BFE28249980 for ; Tue, 5 Nov 2019 10:19:15 +0000 (UTC) X-FDA: 76121826270.26.sugar50_163b61e268420 X-HE-Tag: sugar50_163b61e268420 X-Filterd-Recvd-Size: 2844 Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Nov 2019 10:19:12 +0000 (UTC) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 7C982204E6E447042405; Tue, 5 Nov 2019 18:19:09 +0800 (CST) Received: from [127.0.0.1] (10.177.251.225) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Tue, 5 Nov 2019 18:19:01 +0800 Subject: Re: [PATCH v2] mm/memory-failure.c: replace with page_shift() in add_to_kill() To: David Hildenbrand , CC: , , "hushiyuan@huawei.com" , "linfeilong@huawei.com" References: <543d8bc9-f2e7-3023-7c35-2e7ed67c0e82@huawei.com> From: Yunfeng Ye Message-ID: <0220b5ff-bc47-9616-3897-52fa1c674487@huawei.com> Date: Tue, 5 Nov 2019 18:18:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.177.251.225] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2019/11/5 17:50, David Hildenbrand wrote: > On 05.11.19 10:38, Yunfeng Ye wrote: >> The function page_shift() is supported after the commit 94ad9338109f >> ("mm: introduce page_shift()"). >> >> So replace with page_shift() in add_to_kill() for readability. >> >> Signed-off-by: Yunfeng Ye >> Reviewed-by: David Hildenbrand >> Acked-by: Naoya Horiguchi >> --- >> v1 -> v2: >> =C2=A0 - add Reviewed-by and Acked-by >=20 > Note for the future: No need to resend if there were no code/documentat= ion changes. Andrew will apply the tags when picking up the patch. >=20 ok, thanks. >> >> =C2=A0 mm/memory-failure.c | 2 +- >> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 3151c87dff73..e48c50cac889 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -326,7 +326,7 @@ static void add_to_kill(struct task_struct *tsk, s= truct page *p, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (is_zone_device_page(p)) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tk->size_shift = =3D dev_pagemap_mapping_shift(p, vma); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tk->size_shift =3D compoun= d_order(compound_head(p)) + PAGE_SHIFT; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tk->size_shift =3D page_sh= ift(compound_head(p)); >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Send SIGKILL if "tk->addr =3D=3D= -EFAULT". Also, as >> >=20 >=20