From: Hyunhee Kim <hyunhee.kim@samsung.com>
To: linux-mm@kvack.org
Cc: 'Kyungmin Park' <kyungmin.park@samsung.com>
Subject: [PATCH] memcg: event control at vmpressure.
Date: Mon, 10 Jun 2013 20:14:13 +0900 [thread overview]
Message-ID: <021701ce65cb$a3b9c3b0$eb2d4b10$%kim@samsung.com> (raw)
In vmpressure, events are sent to the user space continuously
until the memory state changes. This becomes overheads for user space module
and also consumes power consumption. So, with this patch, vmpressure
remembers
the current level and only sends the event only when new memory state is
different from the current level.
Signed-off-by: Hyunhee Kim <hyunhee.kim@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
include/linux/vmpressure.h | 2 ++
mm/vmpressure.c | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/linux/vmpressure.h b/include/linux/vmpressure.h
index 76be077..fa0c0d2 100644
--- a/include/linux/vmpressure.h
+++ b/include/linux/vmpressure.h
@@ -20,6 +20,8 @@ struct vmpressure {
struct mutex events_lock;
struct work_struct work;
+
+ int current_level;
};
struct mem_cgroup;
diff --git a/mm/vmpressure.c b/mm/vmpressure.c
index 736a601..5f6609c 100644
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -152,9 +152,10 @@ static bool vmpressure_event(struct vmpressure *vmpr,
mutex_lock(&vmpr->events_lock);
list_for_each_entry(ev, &vmpr->events, node) {
- if (level >= ev->level) {
+ if (level >= ev->level && level != vmpr->current_level) {
eventfd_signal(ev->efd, 1);
signalled = true;
+ vmpr->current_level = level;
}
}
@@ -371,4 +372,5 @@ void vmpressure_init(struct vmpressure *vmpr)
mutex_init(&vmpr->events_lock);
INIT_LIST_HEAD(&vmpr->events);
INIT_WORK(&vmpr->work, vmpressure_work_fn);
+ vmpr->current_level = -1;
}
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-06-10 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 11:14 Hyunhee Kim [this message]
2013-06-10 14:09 ` Luiz Capitulino
2013-06-10 15:12 ` Michal Hocko
2013-06-11 0:17 ` Anton Vorontsov
2013-06-11 1:01 ` Kyungmin Park
2013-06-11 6:21 ` Michal Hocko
2013-06-11 8:49 ` [PATCH v2] " Hyunhee Kim
2013-06-11 12:59 ` Michal Hocko
2013-06-12 5:42 ` Hyunhee Kim
2013-06-12 13:09 ` Michal Hocko
2013-06-11 13:10 ` [PATCH] " Luiz Capitulino
2013-06-11 13:13 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='021701ce65cb$a3b9c3b0$eb2d4b10$%kim@samsung.com' \
--to=hyunhee.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox