From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2AACC02188 for ; Mon, 27 Jan 2025 12:50:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B335280146; Mon, 27 Jan 2025 07:50:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 063E628013F; Mon, 27 Jan 2025 07:50:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E45DE280146; Mon, 27 Jan 2025 07:50:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C3C4E28013F for ; Mon, 27 Jan 2025 07:50:37 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 70DFD16162F for ; Mon, 27 Jan 2025 12:50:37 +0000 (UTC) X-FDA: 83053215714.03.EC1E36F Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf25.hostedemail.com (Postfix) with ESMTP id 33B2FA0004 for ; Mon, 27 Jan 2025 12:50:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Bp5WmAJx; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of petr.pavlu@suse.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=petr.pavlu@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737982235; a=rsa-sha256; cv=none; b=Kyif5Y+FeRaLH7wjbG7uF2nbvBJxDi8bC30Jn/wDIid+KoTIvkiey0SltSIeWVOM5wLq+S DGkC1ci0xAtNSHm8WnLZ92gyHtK5B/ar6ujKHRpA/5qon0TznAZ5p+JbVxCOX2LphDhwUT Y4u10MrZ8mO7iQkEDbKGtyOPwcMH7yE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Bp5WmAJx; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of petr.pavlu@suse.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=petr.pavlu@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737982235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VG6M7E++/3Ce9GXj2tezC00IBdvh1kteyj5hzR0NwA8=; b=GZPM+lGOJGV76aNG8LfaWvwnYvK4Qpoe3cRNYrp6HOV5LJHhfz5QPndTK46WF0k/qsHceg yzj+46EOK0ZIvePkWzlNiJT9ry+kmu8quN7bVewZiij94amukymTgwE/hm8HoKSKg9MCP0 m/V/WtdmLDAcVli5n74ZwbDCSdKBhdc= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso30732315e9.2 for ; Mon, 27 Jan 2025 04:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737982234; x=1738587034; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VG6M7E++/3Ce9GXj2tezC00IBdvh1kteyj5hzR0NwA8=; b=Bp5WmAJx3gi72alrOVcIxb8aKV8+9JccfgPSls4nUmMYqjuCRoOREdyRvC7nA7HPXC jyFEkkEM+vLV/N7AqSyiZcQuK9iRLR+1pLDSWc1zxvIsohS203Dh7mG2vJhhN+fMRm2i PfYQbiuv/RdsvH5s4aBnG1biD5WUoO8wOJ5di/JgUByRQkelfbQJBjM2m/mtNxwr4rqA zS7w6wRWznZAgSP7a6Sk1uTEqu+aqQi1r66cyw5x9VfUwQ3d7S7Xm5kv4OYwqhlgNGgC CiJUIWzFOreffChjZj/E2nuDFBwcqbhzuuwJm7EQUmaS21rE/Fycq55cb1msH+cS5gV+ fQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737982234; x=1738587034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VG6M7E++/3Ce9GXj2tezC00IBdvh1kteyj5hzR0NwA8=; b=GWzi1qYG/MOr3O7Ruth5z9ZD7lwRZzrks4oyQgX132xzyRrIXm6vn2b3GcQ9T8fl84 cvJARRGRehzoPsiA3lggqLJ0yFdYM53o5gxglQ1m2ZroudWsyYUb399F1aDGMRnMRHtK WjfZ2gLakmrmCSpzGqbu20Zaa5bEDe/qnIIV+j3nP1yTcb04bdhXsidXvSrdCfcfHvrv zukF/0BtlHtwmJcJBSSMKv7Hhz6Ty/YPGTI8lFjB0WNfuhPFxSYabky+ebPIfQxpmAnw 6it5mhURaZyAseyHeNcJtxmQEBunIJgKVzQavyqw0A6OQqEBSUG8U4JwFXffNhCRF4av BiaQ== X-Forwarded-Encrypted: i=1; AJvYcCW7mEOBRpbMFE+qlvsZdNuuOZHO/BvyyLx7yPH92NsbzTTr/9PUiJ0+9e0cAbogXtp/tqawD34frA==@kvack.org X-Gm-Message-State: AOJu0Yxny0r6Xe2yRQeeS/saHenBiePorrcXD+s4Akt4bD2uCTqnIj54 YyNvVCZAOUak4RZEG1PHgXyVjl4dFt7eTBVGrgpIDA72BWAYVtrtoYbWt+tQXXU= X-Gm-Gg: ASbGncuygNAn2qsm1243ZAbXHI+iI5D5EtBGSaAfIlYFK8d1vLSVj7jpk0T4y6w7NvG GIbK4cZ2sVQpYxKfmVUSXkwdL/ALFqojlPj3ZjmHbCQNrzjk2ySiFtWGJAVKoeuMgxzJuEE9sag KYnlfKAl2m6q+T5vfRn6VNDOMgBLbIy6c+tpl0s6SSYz9G5VxCfabDvupD7k0Jh/XesKkgBuaVo qd9LWvyyQOHlM8q0YZIuI8j+flMghY7BIz5b8DiP6EFCBsUY/kjA0JyA8AypVavcPKRzoCBP532 wa6VdKSl X-Google-Smtp-Source: AGHT+IHGKx5XPAjKkuM8tLdY/iEmI+lFN9vw68MEGkVKzufCkr8AVUadSDTJkGDjd3qRPKQy8gyy+g== X-Received: by 2002:a05:600c:46ca:b0:434:a367:2bd9 with SMTP id 5b1f17b1804b1-438913dfd7fmr435221995e9.14.1737982233635; Mon, 27 Jan 2025 04:50:33 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd54bfb0sm128676475e9.32.2025.01.27.04.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 04:50:33 -0800 (PST) Message-ID: <021665c5-b017-415f-ad2b-0131dcc81068@suse.com> Date: Mon, 27 Jan 2025 13:50:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] module: switch to execmem API for remapping as RW and restoring ROX To: Mike Rapoport Cc: x86@kernel.org, Andrew Morton , Andy Lutomirski , Anton Ivanov , Borislav Petkov , Brendan Higgins , Daniel Gomez , Daniel Thompson , Dave Hansen , David Gow , Douglas Anderson , Ingo Molnar , Jason Wessel , Jiri Kosina , Joe Lawrence , Johannes Berg , Josh Poimboeuf , "Kirill A. Shutemov" , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Miroslav Benes , "H. Peter Anvin" , Peter Zijlstra , Petr Mladek , Rae Moar , Richard Weinberger , Sami Tolvanen , Shuah Khan , Song Liu , Steven Rostedt , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, live-patching@vger.kernel.org References: <20250126074733.1384926-1-rppt@kernel.org> <20250126074733.1384926-7-rppt@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250126074733.1384926-7-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 33B2FA0004 X-Stat-Signature: du9bczmqtccenq4ka86ytpeq9y6sf3ym X-HE-Tag: 1737982234-539300 X-HE-Meta: U2FsdGVkX18vdTaLm/7m/BZd5sp2Bxa7myULvHZBqIcTzMnpq8bv2ZH3aW7XOJjApxjFTHhusrlGrTlreAzbu/SDeb4pETRfAQl0y7H8+MrRQECxtfgA3fotE1G3ky+kQTuGEZhk/WTGKvVExnYxqY7eBiku1/6VaTesDWu/u9JNDbQ6n3B6WeCFDU7zU45JC5nvroFHnnsjXKgJodC7nNeq5lxEG/g9G99xMLLAAHPOiaRalNsJQfaXI74bC6cCmNffysO9QzwIxyj/ldiJ8VNim9vPYW43mBk7Zni2EiaOaozHjFXPVHB6ahg/u+JXsq/9AtRGzLv3kzGf7b2nJX1sW75y+ImrV2j1gcegkFbgP4C8Qt+7jA7FOzLUfM14fNF6mqKyt+eR+hKdRIcXqDYoLOyOgI2MQn9dwDSVI4XqwVybTo7kCNPJKPRi1m8dYXVoUrAvovFOmI4aidUBtFsA+2BpcPp2XPdtlShCtWcvQwhDp2mCKeAs2eUQD6p6bDpqKsGsSLweKHM3lhNyeLaaGN1EihdNmdvAoLyW54w+LIgWYlG+buLsp0SsIbb2Fb+GAG7X8pAfbBf2VRGa0mdlvPqkVMfyTiuvULE2ERhpgIBL3XzalYtpQMQEON4RPP7g13sfC8t1lAO0uJ1eLzxb2sHkXmbBCloAKa8KEaQTHMjZtLiwmBfTy95aHX5EDz3sGHZ6ZvFVv/14f2+wMnjyxRyW2OOOE+4plx27pdCuGjbucbfXTkhVSC0FBIT8NnQgKsN2lEhqyQIcuIyZv+g1cWpaB8Joo58bXtrcua7PK6oE46b0ZUcuw5Jg3SrkMV4FwbC5vvtFYAefCbTgRmu4K6mvUhmRwWMDhIL2+utk/3f1+QX44FF1d+da+mFa1eaweT5310/AGCjuqrhk4jbhS9/ryYfIiTZpRQkDAQDbJXHK9udsyYXYoCSuv/3+ywWyyOSlNmf5EsH0ZJD 3dRiKt6g N0DW0nM44dUU9jst161MGbrs+ehMZZzxEbYLP+gGurbO8+HHSWVrastiApmz7rqR074XkDP4x50txJ+u8rh61poOw5jwN8flMxIhTChqCwmyC5ikaDA0MSI1aD5XWEsGDZp3mQcUZWORHl8LT7veDNjN56hPiKx1lH3zabQCvTjvi5H26fwBfRQv59uXizmXGoyZu/fXYZIGA0z41YPxaVZKGO9CJaWus6AVZKzPJ7hqlcE/3fdepqiyyNhArIJ2IaRAHcULWor5nwLtfL8u++EMJBJLuCNaEtErsQDzq75JZf4JqICbaIHHVcVvtALVZCRG8YdZ2eTs24wbikspIqXXKFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/26/25 08:47, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Instead of using writable copy for module text sections, temporarily remap > the memory allocated from execmem's ROX cache as writable and restore its > ROX permissions after the module is formed. > > This will allow removing nasty games with writable copy in alternatives > patching on x86. > > Signed-off-by: Mike Rapoport (Microsoft) [...] > +static void module_memory_restore_rox(struct module *mod) > +{ > + for_class_mod_mem_type(type, text) { > + struct module_memory *mem = &mod->mem[type]; > + > + if (mem->is_rox) > + execmem_restore_rox(mem->base, mem->size); > + } > +} > + Can the execmem_restore_rox() call here fail? I realize that there isn't much that the module loader can do if that happens, but should it be perhaps logged as a warning? -- Thanks, Petr