From: David Hildenbrand <david@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-mm@kvack.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com,
christophe.leroy@csgroup.eu, Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH] mm/hotplug: Enable runtime update of memmap_on_memory parameter
Date: Mon, 24 Jul 2023 19:46:01 +0200 [thread overview]
Message-ID: <020d06cf-29ec-d292-8cf1-19a4af649d67@redhat.com> (raw)
In-Reply-To: <20230724103109.37e166fefa57f918492b1fa8@linux-foundation.org>
On 24.07.23 19:31, Andrew Morton wrote:
> On Fri, 21 Jul 2023 18:49:50 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> ---
>> This is dependent on patches posted at
>> https://lore.kernel.org/linux-mm/20230718024409.95742-1-aneesh.kumar@linux.ibm.com/
>
> It appears that the above-linked series is to be updated, so
> would it be appropriate to append this patch to that series?
>
> If not, please resend this once the above-linked series has landed
> in mm-unstable, thanks.
>
Yes, let's include that patch in that series.
In general, LGTM. Toggling it at runtime, however, makes it harder for a
driver to stabilize on the value. In the context of virtio-mem this
would get important (once supporting memmap_on_memory).
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-07-24 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:19 Aneesh Kumar K.V
2023-07-24 17:31 ` Andrew Morton
2023-07-24 17:46 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=020d06cf-29ec-d292-8cf1-19a4af649d67@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox