From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: 'Michal Hocko' <mhocko@kernel.org>, linux-mm@kvack.org
Cc: 'Johannes Weiner' <hannes@cmpxchg.org>,
'Mel Gorman' <mgorman@suse.de>,
'Minchan Kim' <minchan@kernel.org>,
'Andrew Morton' <akpm@linux-foundation.org>,
'Michal Hocko' <mhocko@suse.com>
Subject: Re: [RFC PATCH 2/2] mm, vmscan: cleanup inactive_list_is_low
Date: Wed, 11 Jan 2017 14:22:13 +0800 [thread overview]
Message-ID: <020301d26bd3$0c6e6a80$254b3f80$@alibaba-inc.com> (raw)
In-Reply-To: <20170110125552.4170-3-mhocko@kernel.org>
On Tuesday, January 10, 2017 8:56 PM Michal Hocko wrote:
>
> From: Michal Hocko <mhocko@suse.com>
>
> inactive_list_is_low is duplicating logic implemented by
> lruvec_lru_size_eligibe_zones. Let's use the dedicated function to get
> the number of eligible pages on the lru list and ask use lruvec_lru_size
> to get the total LRU lize only when the tracing is really requested. We
> are still iterating over all LRUs two times in that case but a)
> inactive_list_is_low is not a hot path and b) this can be addressed at
> the tracing layer and only evaluate arguments only when the tracing is
> enabled in future if that ever matters.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-11 6:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 12:55 [RFC PATCH 0/2] follow up nodereclaim for 32b fix Michal Hocko
2017-01-10 12:55 ` [RFC PATCH 1/2] mm, vmscan: consider eligible zones in get_scan_count Michal Hocko
2017-01-11 6:18 ` Hillf Danton
2017-01-13 9:18 ` Michal Hocko
2017-01-17 6:47 ` Minchan Kim
2017-01-14 16:12 ` Johannes Weiner
2017-01-16 9:29 ` Michal Hocko
2017-01-16 16:01 ` Johannes Weiner
2017-01-16 19:33 ` [PATCH 1/3] mm, vmscan: cleanup lru size claculations Michal Hocko
2017-01-16 19:33 ` [PATCH 2/3] mm, vmscan: consider eligible zones in get_scan_count Michal Hocko
2017-01-17 3:42 ` Hillf Danton
2017-01-16 19:33 ` [PATCH 3/3] Reverted "mm: bail out in shrink_inactive_list()" Michal Hocko
2017-01-17 3:58 ` Hillf Danton
2017-01-17 6:58 ` Minchan Kim
2017-01-17 3:40 ` [PATCH 1/3] mm, vmscan: cleanup lru size claculations Hillf Danton
2017-01-17 6:58 ` Minchan Kim
2017-01-10 12:55 ` [RFC PATCH 2/2] mm, vmscan: cleanup inactive_list_is_low Michal Hocko
2017-01-10 23:56 ` Minchan Kim
2017-01-11 6:22 ` Hillf Danton [this message]
2017-01-14 16:16 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='020301d26bd3$0c6e6a80$254b3f80$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox