From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE96C7618E for ; Wed, 26 Apr 2023 09:59:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 977546B0074; Wed, 26 Apr 2023 05:59:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9007E6B0075; Wed, 26 Apr 2023 05:59:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A1A16B0083; Wed, 26 Apr 2023 05:59:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 65A376B0074 for ; Wed, 26 Apr 2023 05:59:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3E58EC0272 for ; Wed, 26 Apr 2023 09:59:16 +0000 (UTC) X-FDA: 80723094312.02.C9D4C5A Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf22.hostedemail.com (Postfix) with ESMTP id 58C3DC0008 for ; Wed, 26 Apr 2023 09:59:14 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UChbCaTH; spf=pass (imf22.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682503154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RDQSmR3vhfuY5wD7//ZjiyUrNw8FfLpaCbF2hNAW7A8=; b=Q3VaZsDuL1z5FeAXUFKLA80VffsE26lij17wQhAXzBEBvKTSYKLtKap3si/iy+H3gbLuv9 ChliMOBSX1wwGOCPwhnN+sTo85mI/RxskPNeuSCVF8Bt+4iBgaq77eZ8kYhiaLo0lF8Mbt MYM/qgjChioyPtb+nrbiGUjZuC20JDU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UChbCaTH; spf=pass (imf22.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682503154; a=rsa-sha256; cv=none; b=gmOHL7+7Hlvf48TABQPKY/B2TxDdXo2TvVl9/xDvdMGTku/usKXM56C5T/ViTMeRYvFVfc DXgllk4ZH7Ix/FhJt7OHEhKrVQidmTSWvNocHyGNgZgFJscygUy6luNANt00PKb0APH9dt ZLzmWE674MegJREDssFWZAgGR+Q9i/Y= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-63b60365f53so8476278b3a.0 for ; Wed, 26 Apr 2023 02:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1682503153; x=1685095153; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=RDQSmR3vhfuY5wD7//ZjiyUrNw8FfLpaCbF2hNAW7A8=; b=UChbCaTHDh1zDI2Mpv3WMMKP3U0l8VlU7gu+cMaGz9dE0Ei9Mqykvs0cihczEstdSy EY6QxBuqPazZbWYrtzpfOSF5gw03gCVV6SUCR5SM5PIv9prj07Lfh2/MJuzyE1gxj0Jt V6RS7HCRVD67MT55J4G4zun3lz2NZrFz1IslSwhqrUdrhonOzjGNrgZXTkrsMvh6fdT8 6QufwBaCnR6dhFEiy1Om0maCKqoOtBjEF6zepJ87py6o5eIztsaoZl+dFdV64ZQjOOS/ MeblJzB2WrcJjKLKK8vPB/3V9TltmzAL3ZCrtJHIoM7iYYmlDXH5Vi1Cx9FCFSvZY4qR j2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682503153; x=1685095153; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RDQSmR3vhfuY5wD7//ZjiyUrNw8FfLpaCbF2hNAW7A8=; b=MEhk7dJ1j1wiarphRnFstEHSgl9lDpQ4xqbu8CnBSv/yqz5A4Ev/Lqig/YwcMfjpjq CDnUXNky98lHfpzjseczFCeM2dfWUnAWPOhGHNI/kj91XR2EYI87hzIB+hBAd7orluok aP8Csu2rPSOPLlNXzP0Ro68jsBTLdxbtI6nG8cQlfWpvFcfNcqcW+i+Lk2dVYqNs2IUc F15KmjvDSVMwgahzSPjVQFIGeB7nKmsezANhVN6tFmqg+/dgHbW7PkneYOa03tSn5zwS qrPzOGloIXeOiPfp/mEwsYjrKcf1SPCwyLLxnV/4I541duMTHRlNp079rCRaQCemZiEw FGcA== X-Gm-Message-State: AAQBX9dzK351ENoBUEKUX8q3+M2OhL/Hm8UDrg43sBdncQ6/4aBpLuNS Mvoco0h+xOQ2zEVdpRDsgk0FYQ== X-Google-Smtp-Source: AKy350aeRUFwRFS/9eg5SLTEXt3NPabPbXCpA4JVj2iQdij4+Pb3jl8wR3w9lrqj7t3ZGlfVnpmgtg== X-Received: by 2002:a05:6a00:23d6:b0:63d:2910:5c8b with SMTP id g22-20020a056a0023d600b0063d29105c8bmr27702193pfc.29.1682503153326; Wed, 26 Apr 2023 02:59:13 -0700 (PDT) Received: from [10.200.11.252] ([139.177.225.236]) by smtp.gmail.com with ESMTPSA id c15-20020a624e0f000000b0063f534f0937sm5939078pfb.46.2023.04.26.02.59.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 02:59:13 -0700 (PDT) Message-ID: <0201ec78-5b43-40e1-c1a0-4891f47206dc@bytedance.com> Date: Wed, 26 Apr 2023 17:59:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 20/34] maple_tree: Remove unnecessary check from mas_destroy() To: "Liam R. Howlett" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, Andrew Morton References: <20230425140955.3834476-1-Liam.Howlett@oracle.com> <20230425140955.3834476-21-Liam.Howlett@oracle.com> From: Peng Zhang In-Reply-To: <20230425140955.3834476-21-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 58C3DC0008 X-Stat-Signature: kou14muuddj5r7ea3hsktckphhwebazn X-Rspam-User: X-HE-Tag: 1682503154-359221 X-HE-Meta: U2FsdGVkX19ACTHdUBaZOE4lCLu+FYB86FWS9G28zQ73hLEm5x2C6NrEpoRi8pDK1JYRtEuUnP+TegGNCug1zhBfOy9MF4IiLuLawx/hMtOJIpAc7E/UJNVq6fL1SUjvLaSwNW7rfCI4ub8JyIM0QFOu4aSiGNlnVS7zR2Q3JHpgNTmxssBODElQWEgcFpsMR0ffPZGr8WSPNItJqRl2kCR0LSQg+b4lVfV+iwbF4PlaCrsUpwB6cLSpWorh5ct/dIadr4hwywq+XpD4nH6AdD6cmV8OAKJiHuZPMorXbgjuL0p2mrD+Kux2K8joYMeEa8YbXN4NjDpsvSNuIVi3/BEu1ugd0mKV4oXWX8KIVP1mZih08/p4AH3bzkkMC5/sshhjap9fzITsHZm//urkK5VwkxeBdGbhOgmZNwBMqHDgmpXqlxHzt/bBh/QSqOBMZJ5YztxO635bL+jDJvGUyhlnyWYQDKNxiiLl/39e3z2oRMczPNejTV1FOufHw8xIZGG2pfNY/eJDehzL2lLq1Zjr9fc3uSBW7Rp0pha3qUL5Odt4aKYk5U+zyeq49x/DXcX+Y7nUvrjIZQFvONNb091Oao1ONbtveXCXYv+Vcl+FQwfh4j6Glp+tCRt7XDeNxtNlMNrD3hFoKk1SmIJBC+ZdS5DaDzZjX6rxm4cI7N8tPV2JBDNNsTDDxPkrY3Bcd7VMK3WQ7YteLGm3t/TWWIeSaOam7kPV/QEgCxPL2haYG6V4m5i9zH6YSOj/T1rZOTxo6TUm3p2+oQW67vmpKTcZFZP7ot4GV3XSiTLmgC2smTg+391Mvgp2JPxfS2BqE+BxaayYBYRhwxkJeowogjDaV9I1anyvqeZ1eb4aco9SJgCaBz+0GeU1ye8NcJqfFKtCGgfP2T/ccbm1+cZ3ewTZ9kx+ggY0T0FePpbu2C6Yx3kN9Rh8BnwH3DPYbRO4FOcWwcOZOti9oNKJwqx B3OOAAdE LTAdw1v5ezruhCsLd3SCo6FVoHJanJ296Uwl8IAJq0RpH+JFwouYVNLFaOv0vmajqIML06I/pqL60kTF2Ehar3/LRlQmlSVWKufk45o6TL0RTQtxdCoQmQCxYFWrWPNWY0n6bzCfQyaTNgeoVYBTmvhIaNX/OYGmL8KtUwMfpneoVs+/uhU+WZBm8TIuOyAqMep4+iiSfmDZHDMMDafyAshRkL2e3RQVtBcg/snySNwMDzj97zB2Vj9N4YnOo22iRE/DHAsqEgHcF73YElj3QlYzm8I5NwFY9y6oypNoy3ImJKk9VCoiFSrym4Yah02E7qukCk28qrWZmEbHlEgAJBOIuxk3dmZssX5BUqCB7JWp7vIt/IzluQNw1u6WEpNW5oiCCQfTiJZk5CpS3G15kojY+C3uW6zbaxw9AXArStBrQVcGM3kLFAYhuEJ6rZxTNtCH+WcAV0WE7S1RuqvRP45A3Jn1YqYk54dmEvmcvwPAl85I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/25 22:09, Liam R. Howlett 写道: > mas_destroy currently checks if mas->node is MAS_START prior to calling > mas_start(), but this is unnecessary as mas_start() will do nothing if > the node is anything but MAS_START. > > Signed-off-by: Liam R. Howlett Reviewed-by: Peng Zhang > --- > lib/maple_tree.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 89e30462f8b62..35c6e12ca9482 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -5817,9 +5817,7 @@ void mas_destroy(struct ma_state *mas) > if (mas->mas_flags & MA_STATE_REBALANCE) { > unsigned char end; > > - if (mas_is_start(mas)) > - mas_start(mas); > - > + mas_start(mas); > mtree_range_walk(mas); > end = mas_data_end(mas) + 1; > if (end < mt_min_slot_count(mas->node) - 1)