From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9292BC432BE for ; Wed, 1 Sep 2021 10:18:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D08D6103A for ; Wed, 1 Sep 2021 10:18:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D08D6103A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C19CE8D0001; Wed, 1 Sep 2021 06:18:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4456B0071; Wed, 1 Sep 2021 06:18:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1C2D8D0001; Wed, 1 Sep 2021 06:18:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 8CF136B006C for ; Wed, 1 Sep 2021 06:18:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4D3BE8249980 for ; Wed, 1 Sep 2021 10:18:10 +0000 (UTC) X-FDA: 78538604340.19.5225443 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id EA6E2B0000A0 for ; Wed, 1 Sep 2021 10:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630491489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfADcfJ+X6OH5HhkKuNHIMe8xl+JwSPkUuOE45UHKJk=; b=XY2qi/ppI4cW6wbjX6aYb302euGNH5x2vI6Tdm90wUnQvbRhfN3Ri74tSYy7XeGtRmXasY 4x7FLyeDJ1+SCDON+xx1m5RFhSCmWyx51tDbDAkYE5r+SrJPsff4cgv475mIqypeega/KI /NjWoRVi1Vq5G8Y6igI5wgYalSUC5Bo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-Es74BNHFOrCmtP3PThARSA-1; Wed, 01 Sep 2021 06:18:08 -0400 X-MC-Unique: Es74BNHFOrCmtP3PThARSA-1 Received: by mail-wr1-f70.google.com with SMTP id n18-20020adfe792000000b00156ae576abdso619669wrm.9 for ; Wed, 01 Sep 2021 03:18:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pfADcfJ+X6OH5HhkKuNHIMe8xl+JwSPkUuOE45UHKJk=; b=po4h2NTSZhVptLrnt8W0pjPuF0oJww5eUsfX2D/2zrHU36w1XqC83DgiaDlSE/uShv wVHyCce7GDQHUXGyATlsjONEw9++coK4qQxGLAud5k3j/JjgVifbN/wp47gYg3OyXigU krMoNFP7JLm7eTdDtGx14W8IWZcf8YglqqTBD4w/SLzLgtvwjIMztm152ciXnQGYNN6S O+0TBhYEiwaXQCPd5HkE9jkStBgEYa2i/zI3PuHSqXgfCsWf9fsv3EtTW4PHZmmyrhxB ZmbHr3R4qUmW7ec/avE08vCYhMwTYpnpCOIZ/xUvavaSzplTWVjSJ41GvgR1zPK50in0 UDzQ== X-Gm-Message-State: AOAM5325CkOMnI16VSU1ZhzDRGC7kfUtqIMksbVISDIIWEFwHT8otocC JV2Ug/X+iwjZtJZ0wmm7zo4iPxKR4gMdYB3SKv5Vmp0S6cFWnfnPlHnCF0L2lOOvS6KKM59CntS ueunUYqJYZX4= X-Received: by 2002:a1c:2090:: with SMTP id g138mr8834521wmg.98.1630491486926; Wed, 01 Sep 2021 03:18:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl4CYnbiwwajv/e6oPH+L4f9i90VhhHOcBQshd70NAqISR3VMqozAHnGwKKB1AQuJpML/yRQ== X-Received: by 2002:a1c:2090:: with SMTP id g138mr8834484wmg.98.1630491486611; Wed, 01 Sep 2021 03:18:06 -0700 (PDT) Received: from [192.168.3.132] (p4ff23f71.dip0.t-ipconnect.de. [79.242.63.113]) by smtp.gmail.com with ESMTPSA id g136sm4891862wmg.30.2021.09.01.03.18.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 03:18:06 -0700 (PDT) To: David Howells , torvalds@linux-foundation.org, Andrew Morton , Johannes Weiner Cc: Matthew Wilcox , Theodore Ts'o , Christoph Hellwig , Alexander Viro , Vlastimil Babka , Rasmus Villemoes , "Darrick J. Wong" , Dan Williams , Jeff Layton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <3285174.1630448147@warthog.procyon.org.uk> From: David Hildenbrand Organization: Red Hat Subject: Re: Folios: Can we resolve this please? Message-ID: <01ed765d-449d-fa5f-2f08-1b74e7f6a9c8@redhat.com> Date: Wed, 1 Sep 2021 12:18:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3285174.1630448147@warthog.procyon.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XY2qi/pp"; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EA6E2B0000A0 X-Stat-Signature: esewatw3ggtrdr6duhf9kqgweyffcyba X-HE-Tag: 1630491489-851811 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.21 00:15, David Howells wrote: > Hi Linus, Andrew, Johannes, >=20 > Can we come to a quick resolution on folios? I'd really like this to b= e > solved in this merge window if at all possible as I (and others) have s= tuff > that will depend on and will conflict with Willy's folio work. It woul= d be > great to get this sorted one way or another. >=20 > As I see it, there are three issues, I think, and I think they kind of = go like > this: >=20 > (1) Johannes wants to get away from pages being used as the unit of m= emory > currency and thinks that folios aren't helpful in this regard[1].= There > seems to be some disagreement about where this is heading. >=20 > (2) Linus isn't entirely keen on Willy's approach[2], with a bottom u= p > approach hiding the page objects behind a new type from the pov o= f the > filesystem, but would rather see the page struct stay the main AP= I type > and the changes be hidden transparently inside of that. >=20 > I think from what Linus said, he may be in favour (if that's not = too > strong a word) of using a new type to make sure we don't miss the > necessary changes[3]. >=20 > (3) Linus isn't in favour of the name 'folio' for the new type[2]. V= arious > names have been bandied around and Linus seems okay with "pageset= "[4], > though it's already in minor(-ish) use[5][6]. Willy has an alter= nate > patchset with "folio" changed to "pageset"[7]. >=20 > With regard to (1), I think the folio concept could be used in future t= o hide > at least some of the paginess from filesystems. >=20 > With regard to (2), I think a top-down approach won't work until and un= less we > wrap all accesses to struct page by filesystems (and device drivers) in > wrapper functions - we need to stop filesystems fiddling with page inte= rnals > because what page internals may mean may change. >=20 > With regard to (3), I'm personally fine with the name "folio", as are o= ther > people[8][9][10][11], but I could also live with a conversion to "pages= et". >=20 > Is it possible to take the folios patchset as-is and just live with the= name, > or just take Willy's rename-job (although it hasn't had linux-next soak= time > yet)? Or is the approach fundamentally flawed and in need of redoing? Whatever we do, it would be great to get it out of -next one way (merge)=20 or the other (drop) ASAP, as it's a lot of code churn, affecting various=20 subsystems. But merging it in a (for some people) suboptimal state just to get it=20 out of -next might not necessarily be what we want. --=20 Thanks, David / dhildenb