From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FE5C87FD2 for ; Thu, 29 Aug 2024 18:38:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A78396B00C3; Thu, 29 Aug 2024 14:38:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A293B6B00C4; Thu, 29 Aug 2024 14:38:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 916AD6B00C5; Thu, 29 Aug 2024 14:38:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 70AE06B00C3 for ; Thu, 29 Aug 2024 14:38:53 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 15B63C1022 for ; Thu, 29 Aug 2024 18:38:53 +0000 (UTC) X-FDA: 82506144546.15.D5B8CDF Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by imf15.hostedemail.com (Postfix) with ESMTP id 5B52FA000E for ; Thu, 29 Aug 2024 18:38:51 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=AdhDIDwQ; spf=pass (imf15.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724956687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MLJi7n9niisvBeNz7ehwmqHyybu0ZRqBu18tqOTkky0=; b=MVK29X7UNRyFgK4WWMnB6lRrJ3BHNUNuAKhcw0hFs/7/XbRBFyCcHZFk3/dWhWSUFbxzz+ jtbl04o/fBn487RiXQRYboq4lrJ5acIcWkZnE9ckjZlgOnZKep00oAS15tG0QZaGEaLHme 07TuzC+brneEyuXX5+4M1Gq/MX/UnTU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=AdhDIDwQ; spf=pass (imf15.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724956687; a=rsa-sha256; cv=none; b=BhdrY43rf9n9MxlTsA2pyQYgEtrn+XwFE4BDnaJ6JXtDe8NDT5NS7DDC/gMIczafRjf81R XBxWmY+oPOY1t8O5mIWASdZnptTDp8r/s4MwsJmhOpHVK0YX4jN1iuDbsv/qR/szGehFyh nT/PUdkSKFHZJ4DY3TGgOeRFXj+PGJ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1724956726; x=1725215926; bh=MLJi7n9niisvBeNz7ehwmqHyybu0ZRqBu18tqOTkky0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=AdhDIDwQakEz+/dzhJumYYkSe+qGsMoyJ9+klfZo69XLksxf8gGtpf11I7C+Z0Hlw hHllUrViyv0cN05yUPIIwRoKLPpGWnIYANZ8Dkm2cOg1+EkrBLyIAP+AZ18gDYmobt i5ehKJEdDRBkHT6X9RENqi4Nhk7+BM3vU/0QdjqiMQxDEcJ31l+U9ROzD9qx/LfZBg Z2andH6Btn3FKVJcilk7JH0ivfgRGp4rcBcjCRRiWTioFwfD5cpaCf0EafbpCzFHkn /xxgUmJDBoliYdvN7mnDCr2K5fKWS+qnnAMAS5Ue+ABV3gA216Jc4JfoWIpB4MJQis rNIk+kNyLWx1g== Date: Thu, 29 Aug 2024 18:38:43 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 11/26] rust: alloc: remove `BoxExt` extension Message-ID: <01e83e23-28f8-4e1e-8fc7-4115cfe82bb1@proton.me> In-Reply-To: <20240816001216.26575-12-dakr@kernel.org> References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-12-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 60dc07155cb8e4f3049451d813e6c9d7e4195563 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5B52FA000E X-Stat-Signature: ngffr1ko9kumcqfq135bmmqq9kcfiter X-HE-Tag: 1724956731-354324 X-HE-Meta: U2FsdGVkX18JrYxIc35d/rmAmUvZ979mW2MckohrHszqyk6FyUPl+ky4IaNBzVm6jfOkCcrCacYFbSYSHHUmZmslgL3qOMDAcyrvX5YrIaDT8CBTnHWQXtT+pY79b4ASZ6DC7mOmC3MTA549HpihAn9Ep/vvftWZSAUXpYrDLpr0Z4VUAVTCZvU3oMqnEjAg0LLyJ6xYgf1dC44kxSej3kcz18wlNsItrNINkAtaoUYx9uT/waEPPtFu5W0RBOmhuMn4KkE1dfglJ4O7J1EjJ+AT9nY9Ks1I7VGT/kWgeI51R5MNHwhrtffRzJrTlMGW2XNu9G237W8u9v/L+lhhcgEEAkp82ZijbyXeq7wHjgRbT/Wei7jnQhhJL/aRAOi+VpaPnJa5sZBJ9sACaFom/UoOWmr0f/zmLZr96oIjyq1GownWsl+dSZe1iCUGzc1PHBV4jFWR/C4p2XirDEAJzwXKUINwk00OsNyx6ucId87s2EEZbjk9vZDXX+uwNnEKGasDBfc37BIC1o6FS/cyA3tD+0sYxOojdG0nhtd2Kuo959HD7Bvko28FeY+/gBjfQoUbLGVkTNSikihNnjfhsGfvPD8/5BVgDqCqi829HOi9H5W8pxCHLRjVoCu40+IYN1vCqeYnzntU0O9Y7CEmSGR8KeqbhE0vH6L+0UYQWQ8pgZuZulQyau/8hw5LqOhAU7IY57vZIMVRFeeFPN8kaDjGD7l3426cJvh+027WtPZu8dGb5GJwcsfZCx03eAo097G37VrXo4584mS6ywFSaGvF+ueuWl8OkrVa47iDyHzfMvsBuRn462gGMcSQn9LGvzJfHY8fyzZILag4NkAHiXWW3UkFSr0DqxG6/n3XRUDTrOiAUqMC6mE/Qtxx4Eo3a2WOmzOmrQJVFMV2NRGO12rAScFjfHwvITZq3YXWACkoqy8gYnpTDo3jmez+9XWkLLYwDhuuoNduTr82vZB BBAGXAW9 2mw6dgS6OzTdGLqWCYYGFcxKNmaJV0qekDuVdO0fL2RGgJTMr8sVbEbUnlGIOy3RmYgB95LP6O5bvg6jBdcBQ5DeZCYzaco8cxN3mW9a2Iw45k17bG6v4E78kqlBzJIF9cdoI7EIch+7iB7Dc4ODU119xIq/zwjdGwx7TQcLQMCa+NyChaLXjIvPhOM2vZVa1BBqydE2hHJmoUtPPRcw1sz3MeBLBrqkiIDG5Z6XeED8HP9In0SqVGXarRmHdtkJCgEpYpdsVgsOWl+n0bBVjctf8ysqPav7F5oap94Sgi+l+qDPFBUwirObf16Mr3aukFkOQWWcYMP06EcHnVqAq+l+0EngWJCYlMYg+e+YvquPk/juSPnnpH3a683vnvKPeB5++cDTkonB6OTBXO/ACB+A5QOMl0wooml/d35ZICsII3vE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 02:10, Danilo Krummrich wrote: > Now that all existing `Box` users were moved to the kernel `Box` type, > remove the `BoxExt` extension and all other related extensions. >=20 > Reviewed-by: Alice Ryhl > Signed-off-by: Danilo Krummrich This is just a minor nit, but could you please change the commit title to "rust: alloc: remove extension of std's `Box`"? With that: Reviewed-by: Benno Lossin --- Cheers, Benno > --- > rust/kernel/alloc.rs | 1 - > rust/kernel/alloc/box_ext.rs | 80 ------------------------------------ > rust/kernel/init.rs | 44 +------------------- > rust/kernel/lib.rs | 1 - > rust/kernel/prelude.rs | 4 +- > rust/kernel/types.rs | 28 ------------- > 6 files changed, 3 insertions(+), 155 deletions(-) > delete mode 100644 rust/kernel/alloc/box_ext.rs