From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABEDEC35274 for ; Mon, 18 Dec 2023 15:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BC596B0078; Mon, 18 Dec 2023 10:59:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 243636B007B; Mon, 18 Dec 2023 10:59:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E5346B007D; Mon, 18 Dec 2023 10:59:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EBDFC6B0078 for ; Mon, 18 Dec 2023 10:59:03 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BF38212021E for ; Mon, 18 Dec 2023 15:59:03 +0000 (UTC) X-FDA: 81580397766.16.FC051AD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id EA89E80026 for ; Mon, 18 Dec 2023 15:59:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702915142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WzDA6hcPcsMuFe90fvxOn/sgXkaVvZiE3Qj7nlf2hWo=; b=KYWnZ2GkFRKuSvfuX0+n53j7q6OpmjmyhF/w3p/r6xw9xrZNf9OKTSnhKzsrHvn87m6w/C mNV+3gn+mMcADUy57ERMdmijlPitt6zj7MrupU156wZdQYc/MAbCJflkF7j4+1qUs+jw8K mrD3qhJXCFGWNAQBWO0YGaILX7papMY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702915142; a=rsa-sha256; cv=none; b=NY0kYmitOuN/f7N7X1pTj31pRh1EUWIkSeSkTCKaKAK76dOG/z09RsN+8agtLvlJS/E37+ lt3V9cDOaxHWG/NmFA15XkRXg+OhBENQ+jhtY7+o8qXKsx0w62YO3TyHnuLVRKPzRp/Uex k/x+0FlsrbJ5JMZ3d5STfPcHtREXFrI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 935F72F4; Mon, 18 Dec 2023 07:59:45 -0800 (PST) Received: from [10.57.75.230] (unknown [10.57.75.230]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A7E53F5A1; Mon, 18 Dec 2023 07:58:59 -0800 (PST) Message-ID: <01dac739-ad20-44bf-8280-5c3595773837@arm.com> Date: Mon, 18 Dec 2023 15:58:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 10/39] mm/migrate: page_add_file_rmap() -> folio_add_file_rmap_pte() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-11-david@redhat.com> From: Ryan Roberts In-Reply-To: <20231211155652.131054-11-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EA89E80026 X-Rspam-User: X-Stat-Signature: g1zfyed8con9tthy6i6ybn7rh7d7ifxe X-Rspamd-Server: rspam03 X-HE-Tag: 1702915141-921482 X-HE-Meta: U2FsdGVkX19/+3LfiiNbt70fRy9PfneLniUx7FoSOOxsRG/W30SVPYDA+kM/qOMy/k8XKkiNOQV21yvMpJ4S1HezrH5eG5LG0UqLYVF4RS8CA8FLmy+KZbjQRrl8tmRe/tQf7Wh7hH/r/1IQ1iwjdxOOCr8Xs+HAuzGsH9nkHqQ2468+ro6qhXD7DL0nODzTqyz0/+Wy+yLVT1gXW40bB9aayTbP4jcvcoFklKA/z8PW6HXGOs2ywRTwl9AXNxz9d93Eq1vL8Ft4xtOwXbf6LrmkAcKl7dUCVMtZ5JmwYqA679rKm04gT8zpu8S7hVnsdPRe/lAMWEyEQ0VzfOXnvW8GxuBtgDC0g/PsKPqz+K3N0yMkdqPyU7TjOKLLO973IRqp7+g66KVoN0QgAaQtnBogUaoB75IeCNbJY8hGomJhpFFhq4Jm7u34Q9BXyooESr91C3Ea+b23uu1Vm9apATr7En4wbjOPHj/e7MpF14zrcXUz0Sbl76Ysv7Lsj+R1d7kwNOPs3JlS/FnnirSgcH/81dtA962X+MmmBnS9H2APP9OLk4EaWwWwMLCIasRiO8sFe1ChefgPX+GFLxnigJFv94wmXH00DdmusEocsdhxROm+dPX/FtW4MleolPnfbEAEAmMKZQxqycaJkYsjTo/WFB/XwTTG0eXkpHRbgeWhVoEoKMIJHlowo8eIMy3nN91ODfn3CNorbDpVCtg6Pu1QjB2ktgB1v3wJ5hci4W9HIfwSMckL/6HbAcGNAkT3JMF+8ZEMpPrpcPssmX/TVPU5SWC/3618V85Iq3lHwmydKHnd78Cb/9+BKBC3uP4zml9KJGDRqdJiyBRKpRzziTQQ4FFDAnzhP4dTAKd/dPccloeHir+ISN5/YX+K9WwGdGvydSTXSa87sMI7bV4aG3wkFjqE/OQCVnqwZhLGLX2aLTJohcdxsuVaeUKzQizstL7rsv0N9rCcMiCX1c7 9EaqSQKm W5RkuysohLGH5Chgv3DQsxX+OLIWaIgguGLWCLDCL4l60bR4seCL7gQ58+R7pAb1ElnhJr5pi3vko2ICcCpPiXLoHrGNMSjmy0I69XsBWF4hVtLqCAFANeCmiy/4GbW5wC3apt68StVj0ay5qWpSaOQg0l6/blMjwNPp3TwfZWcps4970juKLPmmY2kS5RVDQIQiFeJZOl23Pwx8IFHI7qG1NUFiWaNEjn4LGFyCip43H5S2/aoyf9S2p3lfE3+r23LC6EyE8XcykzvH/KT+gPkZ5XSIbzN+gxwhTLILwyM9ALxk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/12/2023 15:56, David Hildenbrand wrote: > Let's convert remove_migration_pte(). > > Reviewed-by: Yin Fengwei > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index de9d94b99ab7..efc19f53b05e 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -262,7 +262,7 @@ static bool remove_migration_pte(struct folio *folio, > page_add_anon_rmap(new, vma, pvmw.address, > rmap_flags); > else > - page_add_file_rmap(new, vma, false); > + folio_add_file_rmap_pte(folio, new, vma); > set_pte_at(vma->vm_mm, pvmw.address, pvmw.pte, pte); > } > if (vma->vm_flags & VM_LOCKED)