From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0396CD0E6FC for ; Tue, 22 Oct 2024 11:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21ABA6B0083; Tue, 22 Oct 2024 07:26:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C9F16B0085; Tue, 22 Oct 2024 07:26:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B8916B0088; Tue, 22 Oct 2024 07:26:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E2CBF6B0083 for ; Tue, 22 Oct 2024 07:26:29 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 492B941314 for ; Tue, 22 Oct 2024 11:26:20 +0000 (UTC) X-FDA: 82701009636.23.BE7479B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id AA67616001F for ; Tue, 22 Oct 2024 11:26:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729596237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WciR8AkFN/iiagD/1yFz0EwRymw8hrntnlUZ0U2/8xg=; b=Nn+sWbmLUYtBdVwwZs5XNHWG7z6xJx4W7jF0R5LOa+5Rea9Jh7/m68PgF2JdbiqUfD80U9 lP72aOOcs34MDG8wdtbGJsEa7ZWRX0rYnQWMXyOUEFwh16M9FudQszFufoQZc+yPwgIveJ GBDQHsMi5C5D/zKkLsfsz0/JuE1OH7k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729596237; a=rsa-sha256; cv=none; b=ULZD+Gxubz/N8xrfozKNtK0XNu7I9dgDJCvhdjTMQ2OCOCGu8YFpVXrmb/jw92lU+rLQGN Jz+zEQU2vn1R00jmOwLR3m8xZpnF9No6Lu4A1vd9yhajXefLUfkZUkpBXf78dhciDq/3uB BV93COyoD1mFuOhyCRYHPvOhEtPC8Gw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C301497; Tue, 22 Oct 2024 04:26:56 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4113A3F73B; Tue, 22 Oct 2024 04:26:25 -0700 (PDT) Message-ID: <01d59bcb-b7fe-4ae8-9c16-e6fdb2305824@arm.com> Date: Tue, 22 Oct 2024 12:26:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] s390: Remove remaining _PAGE_* macros To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Heiko Carstens , Vasily Gorbik , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , kernel test robot References: <20241014151340.1639555-1-vincenzo.frascino@arm.com> <20241014151340.1639555-4-vincenzo.frascino@arm.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AA67616001F X-Stat-Signature: phfmkmwqy7h7itgctcxxtywnrxqnu8dm X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729596376-981200 X-HE-Meta: U2FsdGVkX18sLE5LgWWq2IDUNg85EXB1dUX5cTLWX96hrdE1ceu4Z4Uu0+5RZ3+rV3TWjfMHIhHfJOWnVG5IkBchefDCaW4P3mBgvoGvYLGS2A2h4XxpMGaj2z1PZuoVZ2tVgYyC9SEdGRbaF+w4MVD9Zz6RcZ4bZEc6gY6ENgGt1vtppyJbKVx9cPtpt+/tVGnx7GSfiBbJFrL7LRXnQHfOuOWmpztKHFJmmIAti0brbbIL4T3PZtt/LceC+VIKGJK1F2bDyod7YzspJEhsuYdRXQnFoi/KqkixDwoyK5sf3+XJbMo/SzF5mSoqX1jOTOFkySbR5SRZNRPYGdLGkKdF7u81wL7TVr/W0Riq1Iu6aNmvnYQgWSJzzIddWdFv5REofr4PBQdFIbrYWDidsXiQRu62z5QNYvBhpwODm6pnuliZswziuOvR05Stlb8SaxgrnSgNYNUmyp7f+BZCtIcVwF1kGNYrlWdcVr79jacL8mc+zsCOtQ/zpCjgjdLS82054j2SPgg4Kh7GNwzFioe2ybOVkPVqcqlz+FdhNx8TCGxrWBF/ZnBqrAGZBYM6Lz8/+IFSiUGJXGn6ybMTgsadZPUngC15JuSTIAVY2STaY3QWrWiQJQWwlaUMX0mEV6nIWhWFHXVvGiAGTaQyqw+T58t7sRoYDWSIPmW3RZ7sXpIrkGDmHTLlhCai59c6ho6uezmVJYbfi0BvBTJBlHVXUfoD87RaUVxyc8wsXU9QM+pDEl1LEqJr2dqOg5P8IW/nXu7IStE4XhbhghEumIzpH6vNQXkLuqFMn6JpPbiYJQYpPkDYq8hlARGRzpvVFzs8+24H8ZBxWxXh/ddMRu4iPkv7Hpq3B/R60NmuOc2teQ6VO8PjcEQr6y6J5/r3Mdft1MWZLyfwZpqu3rlUnk1EcCYFswU/ixEML7oxgUdpuwAwT1tcyk0G/BIMhBQm/jq6txDP2UUmizgIdVb CyiicPuU uH3Zh7Ko0HkkBvzUYvnstE/QdwbBqIkw+upHONmFW36qVRVjbWd0WgIWqc4ShP6Cp4fTrtADjxRvDsluMdYkpMv1cQpTL/dR8sMdM6sNjLMAz+xQO8duQiAmPbPoqOge2AbtShPG28Z8bhQIoEflpUEaT4dbufmJKJwmLLwfl2WKHrUoqKMxFYWwylLnnUNKxMmh2zPoZfX1QAuCw02ptG+GNwU2PDZUV6PfodvPg7OR+63JALmUVV23IQH18Xan6PwtmygcbuqXS1NxnuTqM1CjU0pZYwNxbou3u8pa60tBaBn0risnNAOVxPop2LwO6kwzmoD/pjMfk/Ca7UeTLbqGCykumBwOu3STPitBXy64fWFa6bJ7g5jaCvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alexander, On 18/10/2024 07:46, Alexander Gordeev wrote: > On Mon, Oct 14, 2024 at 04:13:40PM +0100, Vincenzo Frascino wrote: > > Hi Vincenzo, > >> The introduction of vdso/page.h made redundant the definition of >> _PAGE_SHIFT, _PAGE_SIZE, _PAGE_MASK. >> >> Refactor the code to remove the macros. >> >> Cc: Heiko Carstens >> Cc: Vasily Gorbik >> Cc: Alexander Gordeev >> Cc: Arnd Bergmann >> Cc: Andy Lutomirski >> Cc: Thomas Gleixner >> Cc: Jason A. Donenfeld >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202410112106.mvc2U2p0-lkp@intel.com/ > > Is my understanding correct that with patch 3/3 you fix an issue > introduced with patch 2/3? > Logically yes, but please note that patch 2/3 has a small transitional change to not break bisectability. >> Signed-off-by: Vincenzo Frascino >> --- >> arch/s390/include/asm/page.h | 3 --- >> arch/s390/include/asm/pgtable.h | 2 +- >> arch/s390/mm/fault.c | 2 +- >> arch/s390/mm/gmap.c | 6 +++--- >> arch/s390/mm/pgalloc.c | 4 ++-- >> 5 files changed, 7 insertions(+), 10 deletions(-) > > Thanks! -- Regards, Vincenzo