Re: [PATCH v5 3/3] s390: Remove remaining _PAGE_* macros

[Vincenzo Frascino <vincenzo.frascino@arm.com>]

Hi Alexander,

On 18/10/2024 07:46, Alexander Gordeev wrote:
> On Mon, Oct 14, 2024 at 04:13:40PM +0100, Vincenzo Frascino wrote:
> 
> Hi Vincenzo,
> 
>> The introduction of vdso/page.h made redundant the definition of
>> _PAGE_SHIFT, _PAGE_SIZE, _PAGE_MASK.
>>
>> Refactor the code to remove the macros.
>>
>> Cc: Heiko Carstens <hca@linux.ibm.com>
>> Cc: Vasily Gorbik <gor@linux.ibm.com>
>> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202410112106.mvc2U2p0-lkp@intel.com/
> 
> Is my understanding correct that with patch 3/3 you fix an issue
> introduced with patch 2/3?
> 

Logically yes, but please note that patch 2/3 has a small transitional change to
not break bisectability.

>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> ---
>>  arch/s390/include/asm/page.h    | 3 ---
>>  arch/s390/include/asm/pgtable.h | 2 +-
>>  arch/s390/mm/fault.c            | 2 +-
>>  arch/s390/mm/gmap.c             | 6 +++---
>>  arch/s390/mm/pgalloc.c          | 4 ++--
>>  5 files changed, 7 insertions(+), 10 deletions(-)
> 
> Thanks!

-- 
Regards,
Vincenzo