From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BD2C00144 for ; Tue, 2 Aug 2022 01:08:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81C88E0001; Mon, 1 Aug 2022 21:08:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C326E6B0072; Mon, 1 Aug 2022 21:08:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8C98E0001; Mon, 1 Aug 2022 21:08:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A0FF06B0071 for ; Mon, 1 Aug 2022 21:08:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 66D69808EE for ; Tue, 2 Aug 2022 01:08:45 +0000 (UTC) X-FDA: 79752867810.15.2ED2921 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by imf01.hostedemail.com (Postfix) with ESMTP id 1F9444010A for ; Tue, 2 Aug 2022 01:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659402524; x=1690938524; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lLmzdO6QBOEsPInkr3MZEKTGv2QJNZTXmUOhJU63rs0=; b=ceP6ayoRtztkXb4qKzWaokuCewO0oHQinQJJbO6NuTESCkEBLfVH1qOU SRmtbLVZ3SiVu9On8UdL93lMnZ+QWd6Gn2lEyBQHLIKYP4iR2EnXXIa88 PXqLNZIXU5scs9Q6N0fOPdSrwUt4QYjNvSZpM1IKsrCoCz8Xi+uS0snrs g=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 01 Aug 2022 18:08:42 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2022 18:08:42 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 18:08:42 -0700 Received: from [10.232.65.248] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 18:08:39 -0700 Message-ID: <01b70c1c-b274-7e8f-cdfd-cea020f7279b@quicinc.com> Date: Tue, 2 Aug 2022 09:08:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v3] mm/page_owner.c: add llseek for page_owner To: Souptick Joarder CC: Andrew Morton , , "Minchan Kim" , Joonsoo Kim , , Linux-MM References: <20220729004920.8544-1-quic_yingangl@quicinc.com> Content-Language: en-US From: Kassey Li In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=ceP6ayoR; spf=pass (imf01.hostedemail.com: domain of quic_yingangl@quicinc.com designates 199.106.114.38 as permitted sender) smtp.mailfrom=quic_yingangl@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659402524; a=rsa-sha256; cv=none; b=YaZx8L3lz5nP4oKo27ywXJZN8ExXBBItGsDo6QzQcM+5+9EYlsFvB/aG599ivIET2UoLlN acERMlr6QaRYXT5Yr/k6OX8L5cVcH7Y6T1NYmHhq5AEK2ys1IO/ns92gKDYPKcSosSAl/h Sy942WiD9g84Ku/I45xBO4oYXiWGMFk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659402524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lLmzdO6QBOEsPInkr3MZEKTGv2QJNZTXmUOhJU63rs0=; b=LLT1jtIOv0K9I2HEmtIH1VUGLFBnAdKzFzwmhXWNFwEjB3pXuCKa1fPe6yRiV0wkci5Kop muEhJPg0Rr8jPEj/k6lkkvDGPEYDb1gvx11kEA5RxThFwe88Emfmw5tsvsjau1YVAraVFP ScJwaRWjrq+e+kuLVBrpCoOh1fIN8aQ= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=ceP6ayoR; spf=pass (imf01.hostedemail.com: domain of quic_yingangl@quicinc.com designates 199.106.114.38 as permitted sender) smtp.mailfrom=quic_yingangl@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Stat-Signature: 7k9p5b5woigg9i1emq9xw3imrfjp1soy X-Rspamd-Queue-Id: 1F9444010A X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1659402523-895272 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/30/2022 10:28 AM, Souptick Joarder wrote: > On Fri, Jul 29, 2022 at 6:19 AM Kassey Li wrote: >> >> There is usage to dump a given cma region page_owner >> instead of all page's. >> >> This change allows to specify a ppos as start_pfn >> by fseek. >> >> Any invalid ppos will be skipped, so it did not >> broken the origin dump feature. >> > > I think a Suggested-by tag needs to be added. re-send it again. please help to review, thanks. > > >> Signed-off-by: Kassey Li >> --- >> mm/page_owner.c | 20 ++++++++++++++++++-- >> 1 file changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/mm/page_owner.c b/mm/page_owner.c >> index e4c6f3f1695b..231b1877af99 100644 >> --- a/mm/page_owner.c >> +++ b/mm/page_owner.c >> @@ -497,8 +497,8 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) >> return -EINVAL; >> >> page = NULL; >> - pfn = min_low_pfn + *ppos; >> >> + pfn = *ppos; >> /* Find a valid PFN or the start of a MAX_ORDER_NR_PAGES area */ >> while (!pfn_valid(pfn) && (pfn & (MAX_ORDER_NR_PAGES - 1)) != 0) >> pfn++; >> @@ -561,7 +561,7 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) >> continue; >> >> /* Record the next PFN to read in the file offset */ >> - *ppos = (pfn - min_low_pfn) + 1; >> + *ppos = pfn + 1; >> >> return print_page_owner(buf, count, pfn, page, >> page_owner, handle); >> @@ -570,6 +570,21 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) >> return 0; >> } >> >> +static loff_t llseek_page_owner(struct file *file, loff_t offset, int whence) >> +{ >> + loff_t retval = 0; >> + switch (whence) { >> + case SEEK_CUR: >> + case SEEK_SET: >> + file->f_pos = offset; >> + break; >> + default: >> + retval = -ENXIO; >> + } >> + >> + return retval; >> +} >> + >> static void init_pages_in_zone(pg_data_t *pgdat, struct zone *zone) >> { >> unsigned long pfn = zone->zone_start_pfn; >> @@ -660,6 +675,7 @@ static void init_early_allocated_pages(void) >> >> static const struct file_operations proc_page_owner_operations = { >> .read = read_page_owner, >> + .llseek = llseek_page_owner, >> }; >> >> static int __init pageowner_init(void) >> -- >> 2.17.1 >> >>