From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C870C47DAF for ; Mon, 22 Jan 2024 20:08:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCEFF8D000D; Mon, 22 Jan 2024 15:08:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7F178D0001; Mon, 22 Jan 2024 15:08:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F7FD8D000D; Mon, 22 Jan 2024 15:08:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8CCAB8D0001 for ; Mon, 22 Jan 2024 15:08:34 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 57D4E1A0A63 for ; Mon, 22 Jan 2024 20:08:34 +0000 (UTC) X-FDA: 81708034548.23.E558310 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 05D1C1C000D for ; Mon, 22 Jan 2024 20:08:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aoc3QyQw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705954112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=74vQSZ9Ib6W2cdwmSu4B7EOliPKMRAyQqJMwdDwvZic=; b=wqLS/GysCktrVRZfMhI/9uTWSK6jgsCrrMlDOeB49O0VWZyBaGVXOkEIfX/F0DMLPpgi7P digIz/uGcfLjCx+A/kPyUm7X+oxRE/8Y25hkJ5kxdB/ABHT/FblWFMXpyxY2OAzon0qKv1 IRZh6CKxXcW7dM/dzkw3SGsHDfttxZA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aoc3QyQw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705954112; a=rsa-sha256; cv=none; b=Y4iuquUlcZOgHBnr4lSgvWA8qM8SZG7VFkmmeMvqMG6OXAYdECwHl1pp+CWsmoDbvG3N5B LZEvlnQ6whoqH5sCj3ORxtxZgjlMS8Qes130elx9dx8ZFXxztssZuQP6dqoJuHJm1IvjQ5 ehl26hksMMmN72/NVxe4wHNceT6Que0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705954111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=74vQSZ9Ib6W2cdwmSu4B7EOliPKMRAyQqJMwdDwvZic=; b=aoc3QyQwhROY4tWTQz5igvCWM27ZwdldsTFdi1l8TqSqcyhoXW0Wxuh6G6ZwL7/YcOfUs/ 8tsWB/+W+88F1qMZLTuaW9ptt9rK60eiv42yS0Pq9LPz8YC9SpulZjRC0tEhE56siRi7o5 wxx6v8CtNkrKg7PQBsdORwzKv9TdqeY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-BMwCg3ZuPve1gYCB_FInNw-1; Mon, 22 Jan 2024 15:08:28 -0500 X-MC-Unique: BMwCg3ZuPve1gYCB_FInNw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40eaedb4446so9883675e9.0 for ; Mon, 22 Jan 2024 12:08:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705954107; x=1706558907; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=74vQSZ9Ib6W2cdwmSu4B7EOliPKMRAyQqJMwdDwvZic=; b=a+RiKq2YNBXARoAp8zLGL07iZC6qO/rspcHO/oKyiDrnoRce8McPCy+WusWdKTuqmv KkubLaSGJdlMinraIAzFlq9HryOR5pQUr/Hlc9ftNxL7d0Hf77+8QH/RO/pgFTNb11Sy 0Xrb/OQHt5w+zymPFp6fxwfkvgH5xxPuqUtIjiG2Ls1UnmKSsNK/DFGddzR66gkYnW7s QaF5JaOYBxUop7iYKjn+tKla63CfUCk83aE9qiHmYY3mIkO04qAs02CP1KVBOhN1JNLK nnPDjHB7QRrbJjSAAU/BlsydGAqtDXb09ZG+0MVffhMZS/TiWjXmdzuTfD16ewjllGF+ WBtw== X-Gm-Message-State: AOJu0YxVw6Hyp6BVYJaXEgtCkks8SakSJCiO3S3NhgzGHLjn3Ex2Kfe5 A8R7D6C7Cz7TJM19Sf17414WeCClcbM2gl4+gdHuAsZfcQWUDgOVpgT9ScCXSox5k8ZBHZjNETr KV+u+UN7KB31oyObQdR7r5q84kUEpkFP7/2VAGuagaefqN7eA X-Received: by 2002:a05:600c:4f4a:b0:40e:b207:37ad with SMTP id m10-20020a05600c4f4a00b0040eb20737admr585153wmq.130.1705954106945; Mon, 22 Jan 2024 12:08:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHK8OlAl3XA9eIoNh6f85JWWWd6CdUDvuraIncansW9lJ4yoYjQun4BKcSrDUo/pFZGmSKIpg== X-Received: by 2002:a05:600c:4f4a:b0:40e:b207:37ad with SMTP id m10-20020a05600c4f4a00b0040eb20737admr585125wmq.130.1705954106524; Mon, 22 Jan 2024 12:08:26 -0800 (PST) Received: from ?IPV6:2003:cb:c737:f400:b194:1841:c4a5:75f5? (p200300cbc737f400b1941841c4a575f5.dip0.t-ipconnect.de. [2003:cb:c737:f400:b194:1841:c4a5:75f5]) by smtp.gmail.com with ESMTPSA id v16-20020a5d4b10000000b00337d4eed87asm11594671wrq.115.2024.01.22.12.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 12:08:26 -0800 (PST) Message-ID: <01aa95ee-0abd-4d65-b03b-2191285d1ac3@redhat.com> Date: Mon, 22 Jan 2024 21:08:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/11] risc: pgtable: define PFN_PTE_SHIFT To: Alexandre Ghiti , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org References: <20240122194200.381241-1-david@redhat.com> <20240122194200.381241-5-david@redhat.com> <5601b896-f67c-432d-a169-0f08928123fc@ghiti.fr> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5601b896-f67c-432d-a169-0f08928123fc@ghiti.fr> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 05D1C1C000D X-Stat-Signature: fmd31eyjrqkbcdb71qw8yhjnrzmzfisk X-HE-Tag: 1705954111-821896 X-HE-Meta: U2FsdGVkX190UCDrF2THQEhhXukZO0oEsPsv3SLaKcaQnfwuXDZPlK4UG7cwW6YQ+fghNGbZjF6R0g4cPAd/Sa95mVudyKOV+ytP7ccpcYxN3SoGTkzy3LjsDUHMtRLzFerqUP6FBwR9Jni3pCFoMtiRL/TLyB5Z3sFSeei/EEwqbj5tlehASquCgF+PH+KyWyQ8xLIfPa3Z9/rLPpnLKlJ/ETr0mCbDxWs0VGKp1ixcuFw4RUBX/VA9e2Yiqfv8qtI1mjnulnhGJ6E6GttylAuBEIs9ZV1xtXTnXxjdqJhJey/+bVjIDyYCBMXTFpfjlo1OW0SJBwdtVZQVk+dylAtO/DuLv8PzwGr5QmrkHCs8QscAq0Eoq2SndmqSEuoOW2bqVrHlVkdamS4s9J6raQpddcbQYgzUZBS3rPlZdDSVmKKJjMhQ58WX54w0VBGFFWsnhqRxdm3d5qzJAXHe/uCgm9s9h8+1+mWSknToB9n24GqgwWsDuEJ9freVkNxsSpqa0V0M1ImutYuPUOD2lldu6TposrG4zscQUTSH37pHoL9ZQ2MmuKPIlXIGbocXtSBJpeve3zR8l4SBwzoV5BY40cUqt2RVt3RHXVrL4k3/Zqc7ngjdGY1HrOjv6I2/RAx7S2nZXrhWCwblI687zmhXOeIePVtlhrQ9d1eJ6IW/uHmJtzY/NpvmDtxRVJskgxjzhaBevNNpOnpsatwnVqvsmgOh8d2ufAfpPRAIyzs0kLBMZb2MTdA73jmu6/kHBBKGhD/XfoLJo+cEEemNpu3mY8bP1rZym2V/UxZzZM3+hQWajkIGS9p0mhnynu4X8V1TvifYx2UvvmrEyaEl5RMyqkPf+TPUnvtKgcXXMUCgCVlx3SGRdXlLC5417GO6/xDmrU6LHtWp7lc7t81w/HYIDwljyxxd28j0+9fCOFX4Yadl8NyE2A4cfWjLv6fJ4VcYSkknEaLj1fVNt5W giuV/0S5 GZNTEY7+FBxnaApuIsgWA2LH1BCMNEEzIZ8Vp8i3FZckVUzRnlPraKquf3YAJKcbfURMxjBbU0VGo8b2ZQpKPgW1LYAkg/kCgQ6/HhqvUiD07gLXQ6OlKfpZvbsxrNorQz0c0xjHM6VTihE1py4dJNysp6ySjmHbx9mP/l8Zo+NYEAUb6E/RvVb8sROgdaj9JaOsbFeQqCAfi1YWDVutOtMYttMlEStvKKf0egW0ob+JFFwzsuKhzKG+53EfbLSnM9h2OEnyQ2yGCzkWvWv6NufFWomUZEXxJQC0sZpXtY7jj4OUUGEc80IUtnwFeUb+dIgGAqGmeO1gLTiclYKohLylf44QFjV2nngFz2EtwTQntOVk4319Ub57L2DRjnLVD0F9r3+J+jJAAbDkGqX07e/SX/mgP8wTZX7DaN5ReiobqSwW2EqdpvO+ROeUOTSIvgaC5tZPyXS2FYoBKfQCUKa3uHE6Y5+iFMlxbTkzf9p5d751KmBlOLm7DHsRkv4/v/fESoJRrExsw2Qxin7L0Iyhz98erwME9cuiFmc2HgKuy4Go= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.24 21:03, Alexandre Ghiti wrote: > Hi David, > > On 22/01/2024 20:41, David Hildenbrand wrote: >> We want to make use of pte_next_pfn() outside of set_ptes(). Let's >> simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). >> >> Signed-off-by: David Hildenbrand >> --- >> arch/riscv/include/asm/pgtable.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h >> index 0c94260b5d0c1..add5cd30ab34d 100644 >> --- a/arch/riscv/include/asm/pgtable.h >> +++ b/arch/riscv/include/asm/pgtable.h >> @@ -523,6 +523,8 @@ static inline void __set_pte_at(pte_t *ptep, pte_t pteval) >> set_pte(ptep, pteval); >> } >> >> +#define PFN_PTE_SHIFT _PAGE_PFN_SHIFT >> + >> static inline void set_ptes(struct mm_struct *mm, unsigned long addr, >> pte_t *ptep, pte_t pteval, unsigned int nr) >> { > > > There is a typo in the commit title: risc -> riscv. Otherwise, this is > right so: Whops :) > > Reviewed-by: Alexandre Ghiti Thanks! -- Cheers, David / dhildenb