From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB0B2C10F15 for ; Wed, 24 Apr 2024 20:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F45C8D0032; Wed, 24 Apr 2024 16:50:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DD68D0031; Wed, 24 Apr 2024 16:50:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36C9F8D0032; Wed, 24 Apr 2024 16:50:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 150008D0031 for ; Wed, 24 Apr 2024 16:50:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B8AF480DD6 for ; Wed, 24 Apr 2024 20:50:06 +0000 (UTC) X-FDA: 82045617612.30.07E71F6 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by imf06.hostedemail.com (Postfix) with ESMTP id EC2CA180003 for ; Wed, 24 Apr 2024 20:50:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.194 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713991804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VxLGr5N0l2v9qvxf+dA8fFVW9kVY33/Z3zQofeDE1Cs=; b=uFW+DQpDJkPQBhC4PsJ3at3rvHIpzyYgqKVQ7f/uB8zAh/wkpkBtdd8rHeRQr5tgh9fLQo FK+PipwqAVtQ7gUCB0o6RGU1KXswA8D8yi0gBcAxdh7A7Bzs8TzWi1+HsNljZULZ9jHU9D GKZiT3Mk0tf+4OqVvcBn/Xhue1/M5rs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.194 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713991804; a=rsa-sha256; cv=none; b=dQ6+d/9/zWGQXEIxb4rlY2cotwW5q0Meyt4rtqya0247StBZQ7muIepULMluwfmtglK415 z0+/QEuyBDTIlS3PN/onFCiXWw/LDDzKcZsjjtP+fKSTWua0rjWZ8wrVxkRn8izxp2HOpy b6DxDtZ3uo4jCWzqtRZ8C4lHqmiLOzk= Received: by mail.gandi.net (Postfix) with ESMTPSA id E73F940004; Wed, 24 Apr 2024 20:50:00 +0000 (UTC) Message-ID: <0187110f-e312-407e-85ec-8234ec029305@ghiti.fr> Date: Wed, 24 Apr 2024 22:50:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/13] riscv: Flush the instruction cache during SMP bringup Content-Language: en-US To: Samuel Holland , Palmer Dabbelt , linux-riscv@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexandre Ghiti , Jisheng Zhang , Yunhui Cui References: <20240327045035.368512-1-samuel.holland@sifive.com> <20240327045035.368512-2-samuel.holland@sifive.com> From: Alexandre Ghiti In-Reply-To: <20240327045035.368512-2-samuel.holland@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Stat-Signature: tg5ujyfzhbgb4p9h5czppiq8rw6pmsej X-Rspamd-Queue-Id: EC2CA180003 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713991803-320813 X-HE-Meta: U2FsdGVkX1/dqZmYUHbPljCBuADKzHwQdZJwLZNUa6RAJZh4YNhuM5ITCPp/m/441XrkxlrT9G4R1d04sYS6naTkW0Kn87r5fddpzYGDZiIq2N04WsBxBlTQuYS86slaaq15yOCJ7uRedVlEgPpjnvfylsGX+ipTO35GgRZ4GfP21/QtaL90b5+ZCNqopxqkNnLbq3Bpi9YlBZQOQsBOULxNELGnPC/3voEG9Fz71vVnhYITbvvkUG/JvHaD695R1cWjrnuwKlPukr5/DaHDU+n7sbbbg/k3oAIrOrG/jL3H54aj67v+l3vN3qUtmci5Ioc9eI2QlnW1g1ypppNZ7dsphcjXUKH+4KbTRnTxp30tPbc8Os7ODEWewf9NZWs99KW+0e/+E25L6AReUgEhvVQcVXFWWgpaFkg+Mkz9ny5D3qJcBKg47BjyoKAIV5EGGqrGbtWBKUbCmAQC0jWrF9mSnj1g96MxaqyHJDhrZx4asI1f6UPnGJ3nOwcxlfN4mKC+0Z8tMjlu6GqiWS1IYTfbk5ddxjjMhH7t63oqplmJ0u5BPsDZTavYJ1DpYXqMqw4Puo4+fLU7ppGHRssfgnJS8dEvnWNWLoymR7if+aWQc+nldM4xtORSIIIEvBMACFbrP8SKqmyJSfkn7rqbvboWRbGng+d9OAPu6RshLXXPwa69/mwW7ZdyOkkJ8tN4xm9xEV9/6PkqPVMh0SxptrBQGYjKsWICBzGB5uYll0iA6BFeJE3WlRvq/6m57PEx8S64s7ReCDNFI5DqpUF2X+VEyzaI6hxh/efmPftNFo8Usmd8zKzA1BOx/y/X1q+wVVMoMiAT+4Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000232, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Samuel, On 27/03/2024 05:49, Samuel Holland wrote: > Instruction cache flush IPIs are sent only to CPUs in cpu_online_mask, > so they will not target a CPU until it calls set_cpu_online() earlier in > smp_callin(). As a result, if instruction memory is modified between the > CPU coming out of reset and that point, then its instruction cache may > contain stale data. Therefore, the instruction cache must be flushed > after the set_cpu_online() synchronization point. > > Fixes: 08f051eda33b ("RISC-V: Flush I$ when making a dirty page executable") > Reviewed-by: Alexandre Ghiti > Signed-off-by: Samuel Holland > --- > > (no changes since v4) > > Changes in v4: > - New patch for v4 > > arch/riscv/kernel/smpboot.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c > index d41090fc3203..4b3c50da48ba 100644 > --- a/arch/riscv/kernel/smpboot.c > +++ b/arch/riscv/kernel/smpboot.c > @@ -26,7 +26,7 @@ > #include > #include > > -#include > +#include > #include > #include > #include > @@ -234,9 +234,10 @@ asmlinkage __visible void smp_callin(void) > riscv_user_isa_enable(); > > /* > - * Remote TLB flushes are ignored while the CPU is offline, so emit > - * a local TLB flush right now just in case. > + * Remote cache and TLB flushes are ignored while the CPU is offline, > + * so flush them both right now just in case. > */ > + local_flush_icache_all(); > local_flush_tlb_all(); > complete(&cpu_running); > /* This should go into -fixes, would you mind sending this patch on its own? I think it is easier for Palmer. Thanks, Alex