From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE1FC28B30 for ; Sun, 23 Mar 2025 12:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 301FC280003; Sun, 23 Mar 2025 08:53:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B1D6280001; Sun, 23 Mar 2025 08:53:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12C9F280003; Sun, 23 Mar 2025 08:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EA510280001 for ; Sun, 23 Mar 2025 08:53:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 97597ADCFF for ; Sun, 23 Mar 2025 12:53:08 +0000 (UTC) X-FDA: 83252806056.20.F06CC16 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 22ED640008 for ; Sun, 23 Mar 2025 12:53:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hpfYjFWC; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742734386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eSIceRe9krqWj293/6URxE7hkGbYapwA2HEzmy0enNI=; b=ffzPCQoYAT4odwztYYV1aG/0TkOCUkL+f/TpGGL6KFlH3G8MG7mMDvS+zg2RpaoEv+7eXC Z7oBllBPK2g5rv0MZWow7gkT9KOLSgh19+qO4Efke4LvBBxKhLqmZFdP+ZE+zN/nvzR6ZK SHfw42qUL3SQSKsRZzTH2SiS+9i/PQg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742734386; a=rsa-sha256; cv=none; b=yOmoovUzGh3xLUGTxwGec0CYql3nzo14XiujTE2APZkBj2q23bsKiD0IT17sq6W0H4GqYp Vol4+0dQ5zg9MRhZw+7cyP7+N1KcDAV2ytYFvDLwDFkTvJ2/kiUWIuxC+zEdZwTFR97+HA zs69mX+kgUumwwZ4aHC4c1P3N73nCiE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hpfYjFWC; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742734385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eSIceRe9krqWj293/6URxE7hkGbYapwA2HEzmy0enNI=; b=hpfYjFWCrxRgQUKyNgzG8Q8OEerfSpZXm6FjspCcDlBAUh4Zij7WKCLkA8N5TRj2GCdMoF QKA1yT6gKz3tJ8ij/zf1mbpxAkASFU16kbyTRmU69TblT1i3nneXCOWf1dV2RS0dp0v9zT qte4Ry2qAMIToSAR8296MzZQniFXctM= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-0ZqFUSYIOBCXlg2NOFVj3A-1; Sun, 23 Mar 2025 08:53:04 -0400 X-MC-Unique: 0ZqFUSYIOBCXlg2NOFVj3A-1 X-Mimecast-MFC-AGG-ID: 0ZqFUSYIOBCXlg2NOFVj3A_1742734384 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-47689968650so31869381cf.2 for ; Sun, 23 Mar 2025 05:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742734384; x=1743339184; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eSIceRe9krqWj293/6URxE7hkGbYapwA2HEzmy0enNI=; b=WTUI4CaBuHCbaPmWTD3f+oFAeKKY6RtXmySzdxaPnnIKIRfhbf1eiwCB3xQRNTOTeh ULi9bRE+r25GnW3dibOoDdbe2RjDdkkmbo/95jR7AfbDZ4KsI23AsSpclrszWUW4QHGb ryMSTKKAu0/KzNZrzWGg8HR9FgT/BYJz6vKUMdic8kXAhuv1lUNsOW8tO8ZP0YKobM48 7DVrX0gQ/SdZx8Tq62BNbNkaz07fj05puxrSWI/HDgtPniy9Q4jdsxmi5tCS8f5o9Jy8 R6YDENiYduBtKlO48UkMQuAD2NCe2PrM2tShbduWl+IWtaZLqIffElwfHZTo4uPNfIj+ g1/Q== X-Forwarded-Encrypted: i=1; AJvYcCVtiAEwPx6Kb8lj0lWFHj4W07l37P53YfHIUdfl/jPwGLL/u0+nn5IlMpJhlCC5QkIajHYgeMy/vg==@kvack.org X-Gm-Message-State: AOJu0YzKBRLE2oX3jbxwMB1VQXfGq64FCrt74ydPeIf0RKCzEz2FBVLS qyicWtWFw+nNfFvtJFwSV6CQfI12xS8Db7JsbyXO6kbmP1NZ6ka4DyQL3U0C31sB7DL6+MRwbxd wHfFrCMJVX6Aypmu089oy5SgbXXrCloUeI1gfydGacep6iDES X-Gm-Gg: ASbGncueCSXNN9biltNk4mB7uDk9lIeARIOCumavhWdVtxG9xOIVyfHfZX251cZiA99 XdMAYdwOZrdMNLtc1skDdOy+uMSSv22b15qsconEjIi7VogMr69uRqB3vb9+sdPZ8WjjiuvaVw6 gmIRS2S7m7WKEzGuE1VDN0MhL8uuM3v11J/5vWlPFlxFXM/Q0nBjbks/PZXfBETKwLxfjVLUIBD 0QJ78tVMVD2gQ26PtB5OaOqiPi7rzCUpZ6vdrPvzpuqHGUqECnzQxHBYZ+WTpX5r+VLBLxoirkB smWUN+PNY+ti X-Received: by 2002:a05:622a:4009:b0:476:8cad:72d9 with SMTP id d75a77b69052e-4771de3f530mr160971071cf.33.1742734383771; Sun, 23 Mar 2025 05:53:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCTuJh0gU8l7pZMW/mXxQ1EnUT/iVT8CUW6CIPAN/Z6JIHP2aHH9JskTgzY+HgJkPQRJJ++w== X-Received: by 2002:a05:622a:4009:b0:476:8cad:72d9 with SMTP id d75a77b69052e-4771de3f530mr160970821cf.33.1742734383459; Sun, 23 Mar 2025 05:53:03 -0700 (PDT) Received: from [172.20.3.205] ([99.209.85.25]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4771d18d541sm33433681cf.36.2025.03.23.05.53.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Mar 2025 05:53:02 -0700 (PDT) Message-ID: <01803b0f-47ff-429c-a6af-33fee39b957b@redhat.com> Date: Sun, 23 Mar 2025 13:53:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/7] mm/mremap: introduce more mergeable mremap via MREMAP_RELOCATE_ANON To: Lorenzo Stoakes Cc: Jann Horn , Andrew Morton , Vlastimil Babka , "Liam R . Howlett" , Suren Baghdasaryan , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <182bf1ce-1b67-4243-854b-4d0c26aae563@redhat.com> <21f89b73-aaae-4674-aea2-aefc7a4847d9@redhat.com> <9f81bfe4-4cc7-4754-b92f-db3a4e549f86@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9f81bfe4-4cc7-4754-b92f-db3a4e549f86@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nTqmag71ozGT7PiBrY5_RA5eZONKAU-GV98RG0q893k_1742734384 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: w4xaa9ibbsnyiw4c8usbf6anweahjcyd X-Rspam-User: X-Rspamd-Queue-Id: 22ED640008 X-Rspamd-Server: rspam08 X-HE-Tag: 1742734385-338038 X-HE-Meta: U2FsdGVkX1+WlJYu6Wp+gW6ChlrJo2dr51Dfqsb42FOOgU9LeCrKFT7k3iZKh3Gh59E9QP8q+M+4YS5LI8mnznESXYyEmGESClvpUG7sFHaXEY6emOmz/Ef5wLHdsadGzaAbPVg92MG3O/CP/pN/Ld5CK7KwbjjdzpeH5YKMVp+/3bx+gEd4XffJ8lNKFzG+moyOVoGDEaFZFgNuKpT9v/ox66xseLglgqzXaNfRsQ52hY0EximpkurglsSDE8Hv9cmhDFme2g9EQ6f/wGKGUTrAVMGq7pTdzSr9r3vCZcnFKqCfAmnXamCx6BCsqkoEHpO2xbcm0DSlGJOoThSUHWuv5adhDaemKG8pFQcqkEZrXWWgFxYO4FNKWwMhr5V4r77oIh8Udzxav1zlZSeMmWqG3203Nj6y5A2iBQNeVQrb6SmZSz8gaOHGm+8vSTCE8+QBMA4/Ec7WBXbXbO10F56uqV+fppzxl/e8vwMGj8E5onkxvKdqIeCeQDBypE1lGCAYw2yoW9a/Wm8IA5NDNIJnGajAcA9bs5mpUcw6Nv4zvSuYeL65DfQPpLm4MyDrCo6kQSGk8D61pwFsJyfTKS4/QaYFvFPJZHde9sJC0bwYv+k35miY6aUEK0V8EzSfDLIMaNvjoOCZ+B0caftgM1zXW8NbFJutoY2CQI1ZZZyjXromCAOkwfS0EaBwHdiLWLqMhJfRyPSRZqjA1zYX91DXfZy0Rkzp+UzywLP1Nxe3ykWkIqkcWeV3vpP4z0jO/W5dIwQAl7mZR0Dl8HR7kUqJLaseZc2jMAVwC0NNYEQvi7chjOg78vw1DPG0oYzCpcuVYi5mlBRL3c6eCbSGArJUW0Cq/ssPbOW8hn4Hnw6i7vCc2JVwJgO9/+5/3o4JditxvwSQt/GRSw+hy8qlDsEWo9bIq9lUedKPlRGud70XPajoJ8dou+Of4e6sp5+dJ2vfs5OxA5r+vqpCerj DCutqGJf e0S1bNTUjKF85fEcxw2a3fL4WoldNLgrHtErnb77mL7+FThLRAg9UbEma9UitQUjU6CzkkkxqVsqAZTV3RMu8/PijPRYnlD/E+TCnR9s9UwfqxT4D/Kn/73HT7tM+stsq+oPcnG4qSGVviXiRy1xrdIzja4uRbRFiF9QDgMtm//HXQ98mx3Bap8/7q8wyHDl0j/3x8VfBn/kq2HgJBsOXarAk3ZLrxSma/rf18vCTsLWq0o025vVaPeSu7K7JqTzIpFjJDgK/hTLtI+pQLpzTrkvzmI6mEz0NZik9cZ1ADNaAlVQ16tK5vctAYr42sNotZtzmPJrbHXKD/9zFvt82MebjdjHjsG/rb3GOevSbofYZkzWT0ZRIMi5+YfERiRFWU95Gg3bHjCliGgUaa5X+utLyUqRg8qaSzBYI0cM4QdWQ4ek4nAlwYBPQlhg5Uo7mSRFrthbjZ1JWb7mihM8IMKVfXqqoLYoljlcx34Q9/7UbMT6ZwpQsaJbi2lNle+H6ZU4wFxK5eHSNnekDMDoyDafoih+fjAMbwmwnK8+CPl9sMznUr6BSqYVFCwL1sYvv/5PYV2LQyoMnWOFATkLfJGWodkU+2XVFHJXZu8J3BkjlHU7OJPSSS+/jRA2ijBQmNzB6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.03.25 08:21, Lorenzo Stoakes wrote: > On Sat, Mar 22, 2025 at 07:17:05AM +0100, David Hildenbrand wrote: >> On 22.03.25 06:33, David Hildenbrand wrote: >>> On 22.03.25 01:14, Jann Horn wrote: >>>> On Fri, Mar 21, 2025 at 10:54 PM Lorenzo Stoakes >>>> wrote: >>>>> diff --git a/mm/mremap.c b/mm/mremap.c >>>>> index 0865387531ed..bb67562a0114 100644 >>>>> --- a/mm/mremap.c >>>>> +++ b/mm/mremap.c >>>> [...] >>>>> +/* >>>>> + * If the folio mapped at the specified pte entry can have its index and mapping >>>>> + * relocated, then do so. >>>>> + * >>>>> + * Returns the number of pages we have traversed, or 0 if the operation failed. >>>>> + */ >>>>> +static unsigned long relocate_anon(struct pagetable_move_control *pmc, >>>>> + unsigned long old_addr, unsigned long new_addr, pte_t pte, >>>>> + bool undo) >>>>> +{ >>>>> + struct page *page; >>>>> + struct folio *folio; >>>>> + struct vm_area_struct *old, *new; >>>>> + pgoff_t new_index; >>>>> + unsigned long ret = 1; >>>>> + >>>>> + old = pmc->old; >>>>> + new = pmc->new; >>>>> + >>>>> + /* Ensure we have truly got an anon folio. */ >>>>> + page = vm_normal_page(old, old_addr, pte); >>>>> + if (!page) >>>>> + return ret; >>>>> + folio = page_folio(page); >>>>> + folio_lock(folio); >>>>> + >>>>> + /* no-op. */ >>>>> + if (!folio_test_anon(folio) || folio_test_ksm(folio)) >>>>> + goto out; >>>>> + >>>>> + /* >>>>> + * This should not happen as we explicitly disallow this, but check >>>>> + * anyway. >>>>> + */ >>>>> + if (folio_test_large(folio)) { >>>>> + ret = 0; >>>>> + goto out; >>>>> + } >>>> >>>> Do I understand correctly that you assume here that the page is >>>> exclusively mapped? Maybe we could at least >>>> WARN_ON(folio_mapcount(folio) != 1) or something like that? >>>> >>>> (I was also wondering if the PageAnonExclusive bit is somehow >>>> relevant, but we should probably not look at or touch that here, >>>> unless we want to think about cases where we _used to_ have a child >>>> from which the page may have been GUP'd...) >>> >>> UFFDIO_MOVE implements something similar. Right now we keep it simple: >>> >>> if (folio_test_large(src_folio) || >>> folio_maybe_dma_pinned(src_folio) || >>> !PageAnonExclusive(&src_folio->page)) { >>> err = -EBUSY; >>> goto out; >>> } >>> >>> Whereby we >>> >>> a) Make sure we cover all PTEs (-> small folio, single PTE). Large >>> PTE-mapped folios are split. >>> >>> b) Make sure there are no GUP pins (maybe not required here?) >>> >>> c) The folio is exclusive to this process >> >> On additional note as my memory comes back: if PAE is set, there cannot be >> other (inactive) mappings from the swapcache. So whenever we use folio lock >> + mapcount data, the possibility of the swapcache (having inactive mappings >> from other processes etc.) must be considered. > > Ack, do you have a feel for how such a check would work? Likely under folio lock if (folio_test_swapcache(folio) && !folio_free_swap(folio)) { /* unable to move. */ folio_unlock(folio) return -ENOTGOINGTOHAPPEN; } -- Cheers, David / dhildenb