From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71333EB64DA for ; Sat, 8 Jul 2023 09:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5CCA8D0001; Sat, 8 Jul 2023 05:44:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE5D46B0072; Sat, 8 Jul 2023 05:44:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAD498D0001; Sat, 8 Jul 2023 05:44:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8DA706B0071 for ; Sat, 8 Jul 2023 05:44:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5E7F016015B for ; Sat, 8 Jul 2023 09:44:55 +0000 (UTC) X-FDA: 80987960550.30.636FED0 Received: from mout.web.de (mout.web.de [212.227.17.11]) by imf26.hostedemail.com (Postfix) with ESMTP id 4B565140013 for ; Sat, 8 Jul 2023 09:44:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=nGlqUobp; spf=pass (imf26.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688809492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CHVL3ChqA3g4LRZl4BSshdj0JL73+MhPB/+i8emKVKw=; b=x33D6Eykg7+SSLreSjd/+ketS+V4igkcAjOMq5pG4EikyeiW8uG6wrq1F1+rQjxTakWkYy NIZIfnVNZWsOMjtxLx1EG8qoid1pQTDKblBSfaNOowFy+txQ7XuIhggH7PQpTITn53nuAV oTKgQuZTUSyhaJcGQAgGodNcZV2eIEg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=nGlqUobp; spf=pass (imf26.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=none) header.from=web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688809492; a=rsa-sha256; cv=none; b=BvSZ33VY0CIgVVwsf+GD3c7mk6inzGmhS4Iamx/unT1Pho2JxYFjRgHasVS8dF5fqeO5qj t7DpV7AZqbIsTxFxRreYDoOPRR18MgfmDm9BR8Oe0cJPenpMp7Qj+lYqJfAeBeQsPqwnty 0lZocp8aAa0hErLFbldc8e2MAQxDuXM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688809485; x=1689414285; i=markus.elfring@web.de; bh=CHVL3ChqA3g4LRZl4BSshdj0JL73+MhPB/+i8emKVKw=; h=X-UI-Sender-Class:Date:To:Cc:References:Subject:From:In-Reply-To; b=nGlqUobpJUkg+ZNUPnlExaJtTcS0oP9kl69qvUJH904hVM8NM2LKkPuLGuPJc5rWghf92ID pzdB5XCUVGc3GKt7RK7rsHNnyG0VHVSuezniHpg1TvYbo0TL/pLbx/W2nuVC4xIA/gZVze6iq Rb41502Rv/iYT/oE6o0xeRR7p7tv2yztnV+hQaxBLGj+ivWrHvGka+u8GhwUheGZ7/I6XcxsB YDv2nhOtREkRTfdTnE6Ij2DudbIrZ7Gv0cPj9Id4rp3Z+9tWNzBefk/F1OcDsAmxPteD9sqq/ bb8/vOdpZfhcs14JE4XhQX2a6R76kpRba1kWYUDGMEnn2LnZC5LQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.83]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N8Vsx-1pvxFc2wbZ-0143cr; Sat, 08 Jul 2023 11:44:45 +0200 Message-ID: <017e6c8f-8cc3-bb58-87c7-b51edf09a479@web.de> Date: Sat, 8 Jul 2023 11:44:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Miaohe Lin , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Andrew Morton , Naoya Horiguchi Cc: LKML References: <20230708085744.3599311-2-linmiaohe@huawei.com> Subject: Re: [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage Content-Language: en-GB From: Markus Elfring In-Reply-To: <20230708085744.3599311-2-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:f6gi+QoJAVW8TnrrQ85tGLy2gwLVKZ1XUGySXsnoUo1025w8oKz auplEaXT7GULgltrVh3HRUzEaE0FVZ9toW/DACLuk31PhPUedikp1BYZBJy+Glgl2D7DeiP DQ41BezzTtT5iJDBWj5sFkK9fsqB4I7Y/z4wq1igz0swbnyhRzOPFZw5omjFDlj4OGIW/0Z +98LlUYGo6nQNkPya0vEw== UI-OutboundReport: notjunk:1;M01:P0:pE6+QQgYmms=;bJNZwNaCWEW/uUYAmD/PrhjMa18 HYqv8gJxBIycbRL0iBjfvGVYnE+FGHhtXVu0Noqi8tfjNSqhxbWHGGYtwwRRNrm4G7TvUDODD TSPUCbpxHNyqV+0nLPpOSVxAoMAKKUp40PBCmVOXffv7OMt6w81JhFCJF4l/gY3DQfYMV9CDa /9HiG8EbD1Tm3EI2g4RJGhBihWWQ+d8nwt4envSyFYeS15PfnMz19/4KQc6Yg1cPFmxAs9Vx6 kZDduVBRQL4GwMvVZCjBpdWZDbUDSsti9Qxy44iBeebs2uq9DZuLrBbERCFIFAa8DGZa2Qb7x KdClTZHddA8gUebdpIyp1pqdkdmFphWtLM29CCRNmaT/RXmkgan4Vyi11DEnqT1ZEbMePkK0P P7ZxJU65tXM8wjyd4LTYFRUnzhk3MpDADmkpvQ+aGdFh8X9DUEx05GJ4LgPRHGkpGpt7DAQwP hXKsmS2hpAG74O/sbRr/EuvQWh+I3qILepQT6pczCHlQTkkwn31jVo/WcHBjkDENthA0jWQkM 3BwPcYmp7/GVU+2kFOkPCC3Mdz7SQdp8LMC51Lxbv7pLl2jFVe6kyfZUkUyMkrnaSpxGevAC8 3i5La98NfRPTMuV/9d5Ubfj/GeDSNqAqnvnFblLgNTgNNsFz7iKXkEzSmbR5tj1v1K9165zPm g5YZ+GB5meS1ShOv/oafiTzXcbHXSdlrfuck+m+qNKbcIM0iKP+KrUz2qDtaTA7T58YhwsAdG e31S6JQ1qImeSwCh14GDaCVQ0FgYcjwdRPCxRNmOnE8keywfBFa2xKN8R2YZGtd+aC9zf/CmH V9OoY5hHmt6eXOy0cZt7WpBcMBiOamuPC2CYAeI+4BzsEWTHuTLhnYeQdjfmFL2+RlIQtvqcI WRmS8UV0vWqrZ5fTN1ypOhQYLcJXcnpc4D8lXxWozlzvMfiRkxJEuNb7M5aE156a5lOcR4L/x NoabtA== X-Rspamd-Queue-Id: 4B565140013 X-Rspam-User: X-Stat-Signature: ndks1oukzzd4icsnfxi3sfdf55kpgae9 X-Rspamd-Server: rspam01 X-HE-Tag: 1688809492-204166 X-HE-Meta: U2FsdGVkX1+eMjFz0ppYizAztvNym5LRqIUjayx2gEhjvGO2IznSwiZe4cMM3v6/s0j2Fp4uu4fkMxRr9gEy/AemQMZaSxbDRsYiH543QxHBzJLBPYz51UTS01xoHyYX/NB3evOMc05ZGi5iRznU1Gf71Xr6D8MRJRDBwrDiFRpncDQdVUUVAJmgWGiqPMybeqc7Tf35dkLt5jNQmAkYme0ZUbeCxHtB18dXUdi0IMjYNeuVBB0d4LH5KCPi8ZbluoZxBKEVepVJV4okkzomAVJSFX8A7sFBcvmMpKffsq0XT9PU3HbeXC24shjvWP8MuBWNon8MIlm76salORHWJ7mTutxOV1z/3022RWcYE3SwFzw9K8C2O8OH3bfIY0KHlkBIDcI6wr8wKLEklgSNd3ZUWh7Pb4Uv8VimJbKHbwHQceaDNqtB0XNWc8Vdut+VqPO+w54vRXi/MyV2gL86VwUPDAtyTzkjaY/5rsyIQsw2A8MHi6GyWtZcLvLfSQCOlU1cm3UR3QGQfrSbCvKb68Wz6wPRmqFSRx+HU7PoKU8Fvy6etLgJ3eB8gjvveBUgknA3DVx560JRzrtUV3jo4u5CvEFBbtgKPoWGmdmRcsZmDAErYFbil8GVkYcXObJFpOAYJcaE7dy+qmN9rUaN8VgA8quixDDNEMeDCgJr/+1yVcMsiVMgHEvi7d/TpybQyHEQin1Lq7WC2xza+d0agPzm/Sm9csSWyMsGAYEMIcfI5c9L3nDtfEGyMoVmJBWG3wBGjc4MG8Qe/5nK1WGY/72xw6AH5hGsG/1OE6K2wsBFbBKZXkGbg8pgensZN3WsV3YOvb8f16tz6xv7+1OnR90ITX6cOSidhuJ5R6ZnvLf3ANU2yiJC6mqi9xalV7y3zCy4HlhR8KxkGtaSXgqd97K9tV+AfMlmNPnqboPnFk27vp8x+nZmlLJe+BMnONMn6Y1gTEhkpX/MxiPkU3U X7FZFFs1 j2O3TjBNFiHt68fe5jW0oXG0PlTpgY3yTGz5E4k0Pex+k8LNT4rSfZlkFBQ70lzcaAAJnuIn3/728xMQCGddaJRyRVkUGbq3nfg6DmsZUsNyaJ0EY2O5wprU/WQaC0HEi44qfXbRhU9JtyfnX2AkYUp0gzv5C8Z21/YndjJkPH2Z+v/YaiQ2BUuRZPKHxMGtNnEDXAzA3nOtgu/l9+Z7dg9hXZAgVBRDLLWTSBu/1pzNEY6mBmeIqa71lxoWCCDT37FiP5/ZCTOa1BPU/jqHbc2jVdm8F1DsbSnH8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > If hpage isn't Hugetlb page, MF_DELAYED is returned without unlock hpage > leading to hpage permanently locked. But this shouldn't trigger in the > real world because this PageHuge() check is just for potential problems. Please choose an imperative change suggestion. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 How do you think about to avoid empty descriptions in recipient lists? Regards, Markus