From: Markus Elfring <Markus.Elfring@web.de>
To: Miaohe Lin <linmiaohe@huawei.com>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage
Date: Sat, 8 Jul 2023 11:44:36 +0200 [thread overview]
Message-ID: <017e6c8f-8cc3-bb58-87c7-b51edf09a479@web.de> (raw)
In-Reply-To: <20230708085744.3599311-2-linmiaohe@huawei.com>
> If hpage isn't Hugetlb page, MF_DELAYED is returned without unlock hpage
> leading to hpage permanently locked. But this shouldn't trigger in the
> real world because this PageHuge() check is just for potential problems.
Please choose an imperative change suggestion.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94
How do you think about to avoid empty descriptions in recipient lists?
Regards,
Markus
next prev parent reply other threads:[~2023-07-08 9:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 8:57 [PATCH 0/8] A few fixup and cleanup patches for memory-failure Miaohe Lin
2023-07-08 8:57 ` [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage Miaohe Lin
2023-07-08 9:44 ` Markus Elfring [this message]
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-10 8:26 ` Miaohe Lin
2023-07-08 8:57 ` [PATCH 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages Miaohe Lin
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 3/8] mm: memory-failure: Don't account hwpoison_filter() filtered pages Miaohe Lin
2023-07-08 11:02 ` Markus Elfring
2023-07-10 7:56 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 4/8] mm: memory-failure: use local variable huge to check hugetlb page Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 5/8] mm: memory-failure: remove unneeded header files Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 6/8] mm: memory-failure: minor cleanup for comments and codestyle Miaohe Lin
2023-07-08 11:13 ` Markus Elfring
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Miaohe Lin
2023-07-10 7:57 ` Naoya Horiguchi
2023-07-08 8:57 ` [PATCH 8/8] mm: memory-failure: fix race window when trying to get hugetlb folio Miaohe Lin
2023-07-10 7:58 ` Naoya Horiguchi
2023-07-10 8:32 ` Miaohe Lin
2023-07-10 8:39 ` Naoya Horiguchi
2023-07-10 8:59 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=017e6c8f-8cc3-bb58-87c7-b51edf09a479@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox