From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E691AC7EE2A for ; Wed, 25 Jun 2025 15:29:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8670A6B00D7; Wed, 25 Jun 2025 11:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8167E6B00D8; Wed, 25 Jun 2025 11:29:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B6CB6B00D9; Wed, 25 Jun 2025 11:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 561746B00D7 for ; Wed, 25 Jun 2025 11:29:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0F4E41A052C for ; Wed, 25 Jun 2025 15:29:04 +0000 (UTC) X-FDA: 83594306208.14.F9D69E0 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf11.hostedemail.com (Postfix) with ESMTP id B6F7B40006 for ; Wed, 25 Jun 2025 15:29:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=X8Z4EfFK; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=sMn7OOWz; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750865340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CR+j0gJTD+WQR9+fdOcsjUPY1jcZHk9ITigLtxi+BWQ=; b=Ns5dp+tPOsKDHEmEl6w5wOhuHsCTvaJjtSloBXs/hzHdd9uEhwxZzNyGgwE1ps9qIB+GDs OuRo0m9quiQtQWjyIG6Kx1irf4BqcM0fjO6H9G3qHsg8RJM1E02578hKfuhp+pPwRQ+y27 Bq+nnJMheO0KMU8j9j/4c9/WTx3/7k4= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750865340; a=rsa-sha256; cv=pass; b=MW+kmT5xbXow9PcNRChtjDXn2i5Q1yvgTrkRhC9MhiUz+oaAe1kD0WWiNxDoNcg727cnM+ TmncyuDPs7pniFCEfyCsch1xG205TQSaiTTFKQL59xa0pnR27I+zhSFC2xw2EqMtOd60GX VyQhBC1RhnIvBJpMwsvx+bzw/+tq9WM= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=X8Z4EfFK; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=sMn7OOWz; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55PFC0c3020125; Wed, 25 Jun 2025 15:28:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=CR+j0gJTD+WQR9+fdO csjUPY1jcZHk9ITigLtxi+BWQ=; b=X8Z4EfFKo/VJfDaUb7+FrIbdAQ36m+V9Z4 Pexijd8GSPHcIfx5VKmWZGd9uG+qrzjFz3lq5FRUmXa3RIGlBpH1/rgX0HOF5i5a YOBgM4mmW1vtkDz6evvqphIlshjXCtDbAqI55ZKEIzgRE+32oj/5uZta7ubgszD/ tsNyTjZ2sFXePofyZQvEavjuefohMr2Q+SVO8xV5Lca2vQZoIO1gh+4Vr4IKEeCu QpoBhh01t8jMAx7q/HbXSyx/XZAbdB0gZLATCt7kFSDQRtytH5+47Djym9JBj8+f 3tDEYRYnT4ap3+tGK9VZQ0dErByNIAVATL4zBBXxV+VYk7afnG3Q== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47egt7enf8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 15:28:59 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55PEib2V034367; Wed, 25 Jun 2025 15:28:59 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12on2063.outbound.protection.outlook.com [40.107.244.63]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehks83nr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 15:28:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WhB6DycobpnZz7R6qOqmoIGK3BAegumneMGqZH/1vF/jSCRhjwBxORFf/8rLFDw4O1u8MGrI1SUOYLsbVvX8AuBjzK/vku0Za2SKBVYXCqagEh0bfOwU17yhvniv3AA3Y8IuHGZuTJD6yu7TD64KhdrM7xMyJQoSVEhC1vO0JXKHi9IWybN+4z4EvneaskOgh92VY3ZdKmSBZi0fbgoXk3qwef+WUv8ZJeBPIiNRi/tHgK5lDiDAMHdz3muRjGbf7ZBABk4CRd++n9Ujouab1Hrq5bXwrcKEfpYV+buRRZeGn0Q3aGwZPBOT+Cm7aaijuPEwjK4SByeNPzvOPOXdKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CR+j0gJTD+WQR9+fdOcsjUPY1jcZHk9ITigLtxi+BWQ=; b=fMlXiIqgyWsXhNELDepEYl3ItRCh9wyGo19tKPV4F0u2wifxO92zwCbV7I+iiej9xl/S8QAcXzXvoM2M5xkwz3yruOOfjPFoYQSr9eGY12UWoMzQ6eBw3vRA6bw5LwXG22u4hXIxCnriZDSaqtsHyQeMl8+p39U6H76dcvoAWEtuVR5viPq87Cm3SD5SaQci3nT80Uw1XZJ6uyQWHcaY2RpSI/JEeg7tI2HPLMAyoW9mY40W+vkFM6UUjeYB7r4OYMyECqOM7RTU/j4aP13WOxIe0Uh9khcs60vY7cR+ihM1B63eTIDRqQrv7YApdzbILxXqFCCgvphswf1pOoXSQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CR+j0gJTD+WQR9+fdOcsjUPY1jcZHk9ITigLtxi+BWQ=; b=sMn7OOWzhPEvLvJtpebW/SaHjUlI/EZVXIf/Nj3s9LMGbEB6d4OtsOhIn4jv/Dsmty2yKOJ0IoajA0nPrK2/JyM8oSTtunxhx5cR0pZ1G3nhO5EBm+aKNiDDqjjmx7D2+kAqN0Akm0YOkc2JTFSP0bs8tBSmwduzPd8cCf1uqkM= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ2PR10MB7620.namprd10.prod.outlook.com (2603:10b6:a03:53f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.30; Wed, 25 Jun 2025 15:28:55 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8857.026; Wed, 25 Jun 2025 15:28:55 +0000 Date: Wed, 25 Jun 2025 16:28:51 +0100 From: Lorenzo Stoakes To: Dan Carpenter Cc: linux-mm@kvack.org Subject: Re: [bug report] mm/mremap: complete refactor of move_vma() Message-ID: <01784ef6-1520-4a00-8539-e1705c1be7d6@lucifer.local> References: <2f035b94-ab84-427a-b8a0-5f0274e8b8b9@sabinyo.mountain> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f035b94-ab84-427a-b8a0-5f0274e8b8b9@sabinyo.mountain> X-ClientProxiedBy: LO4P123CA0588.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::18) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ2PR10MB7620:EE_ X-MS-Office365-Filtering-Correlation-Id: 19918742-b8f6-45c8-9e0b-08ddb3fcff08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?V1iOkFywnhsdjMWq/m3khocDxKHpQ7IZF9Aa/rENy8bVpbeqIiL/TM+zDa6E?= =?us-ascii?Q?Gkd2A95A3z7nvalZC7IVnhYiOjBvw7apAQKBb6+c8ujz5NcEuumChgsP1jZu?= =?us-ascii?Q?tXBW6ue+k6RQjr22JlmPVa5DDT6NQQhqalIBrS+/EZl5dPLCbM6aUxTks0kz?= =?us-ascii?Q?4Zg4igKtucoTVl7/UpnD7uAGvrDi3tJrTIflama7PThtJDDQiRPBZSsR9Xk6?= =?us-ascii?Q?bnTm7wiBsequyom8agu+M6y1qZvIjuRS3pw9B2Wv7Vs+9vhJESFkM6UfPo1T?= =?us-ascii?Q?kwKk/xwau6nrCL1T5ln7viqFZxRW5yeujKoT5R2wZ/Beu6/wVWXeh46z5jkW?= =?us-ascii?Q?Oz6rJ5rH1GaEWRHdl56///MADybRlRMkKftwpjfvIfABn2iKBjdj9TQkOhA6?= =?us-ascii?Q?Kf/xH0vBsFdLaNY0UHUIYi+u4Rufwgxu4OQl7WCqtS78i3ghI8pno4Tp63aV?= =?us-ascii?Q?47smbDjgor/hK3TxGoRIqONBdDlA2BatIXZ5VtIJ2rJ5iJdm6JamD91LZkae?= =?us-ascii?Q?ik3gA4Qvnx1E+zjxZgjo7R861xJd04/ssRRLTSPFtN4nJo9LmV+8M1WaCt8f?= =?us-ascii?Q?SXoRK56S8t3q15JIIcGmFIFDdvvrOaXMN8prvn9gV8DNj9vy1ctDfqTw4dgi?= =?us-ascii?Q?oUiYAcT5Zbwmrq/qHg8kDM7KYpmhrZZNoc5udfDQmpDRU0iEVOc8XseKJxDB?= =?us-ascii?Q?qQKMqDa7G9BfbzakEAPnp4LeTnqABDgobrRqnDGbq2rxM+kU8ByhIaTeztI+?= =?us-ascii?Q?/cbcXEkDRTDmteTvdX6hwS+IXgMC0uOLIlXDWn9CyBfktfra58mlpr0dxnl6?= =?us-ascii?Q?WpItA1pNBdX01JP1A3SSru8XNEz0wbKPwWKVSPpHAX+ki1gDHutiy9OpoXQ3?= =?us-ascii?Q?HIIjcF3cO6UtWw5/Tg9Rsf3+tvWszZpk+VM+oP9Is70htoRTqnwTxIlDcjek?= =?us-ascii?Q?KLMHzDsGc+myN5NXl+AsQW6BkTpawSg5a8J8gkStU2iuamZUYIUaXt0KSAP3?= =?us-ascii?Q?BHISKEKTMsZwIIRt1a/lN6cJTTf2e5fozViYGKned9UxVKa+cLYE1upZspxz?= =?us-ascii?Q?SNqpGmLaWpHqPe3+VqA+M7a4TpJxOoPLxDdCegIty99Y11XxVVqBgwcma7oa?= =?us-ascii?Q?gjCTnC15MubXSXbiz8ulXT/GbNkuwYsXFeX1kj+bFtk09kz/cAhdVNJj/Ss6?= =?us-ascii?Q?585fzaT96peYlsbZr285nJcNEAV+ZSVe3zYKK22mUN8cIlA9eW3kpxJvxEgu?= =?us-ascii?Q?fb+Rl6K/lyaDgFYctwavpYAgUE/GGVCP8BmtL0MsXmYdlcG3sOY29qwzVQRP?= =?us-ascii?Q?KcxXOjiDiPvtFB6M+pp1Z821BPXhgjcjB30rwbSYFk2UB3x+dOdA+NVdLm2m?= =?us-ascii?Q?BNB2EroZlyDopOFIBug2a9d/bF+OEXwLF/waOUeO1f/hCMlO8tx6yrNElk+y?= =?us-ascii?Q?pF5CiLj4SDs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o8PsaSC2x7iOVePVZN2efcyDD8A5gJSC+pph3MRjNSM7I+12H85viMXZX7nt?= =?us-ascii?Q?bEJg2eRi+xF3QrSv5/WB2TbWUuE0eEWhEA5H3pL6nlndDZY6mx+A8SRf2yKZ?= =?us-ascii?Q?U+IgZplA8J1Wx1Pv3xpsHx8ZJXPZPsENlXCuNbI3Ev9VRAFFygkfOckJEMLM?= =?us-ascii?Q?GSNqDnxSzOoJpwT+PhLWXzSfurlkS2bXH5pRMR2d4oyy6nF7lR5CvSsWE7gZ?= =?us-ascii?Q?4D3I3nOL0xldlRYchCTISUIh+FRwz3dvXU6Maa0Qpbfd3LzYzAFesgL0eN6h?= =?us-ascii?Q?emEB9QCMATk4graLH6H/q6+ZD88e9oGj5dNQrt3AmNmI2yXroFIqBZyAbUdK?= =?us-ascii?Q?OHhGvFJrncpTdX7ioIAA5HK174WSEihV87ifTlVf8UhEl7ZyIttl3jIjyGZs?= =?us-ascii?Q?mfBGPpJlXOD6CApCe4azhdZ9wh+m2lz75EseAKheSkIsS+Uz5JlsQhNnEt0U?= =?us-ascii?Q?ssQwq70N30B8okkkpzH1aWp60aazwxfmoW//kCnqHn19reQZxNi8uaJC8UO+?= =?us-ascii?Q?TBVhkVbYW0b2jJrvw6sbw4IcRxD973CDjk1lGK7ZyjkXUbx6wrwkQs3ppWCa?= =?us-ascii?Q?l17MT8CTx3Jv65RHiRsZLsZ5GF46ALnYiNwq6Djc/H2MiDyGZGj8gwEtgSjf?= =?us-ascii?Q?C/cUqztSPNO5g7SbfifRW6M2fopqHnZ3wmq6Efpp2njC9WsTt4yO0HFLEjL4?= =?us-ascii?Q?aj789F5Jok7sNrksozSy03KjYFEqXTz5vk5h72InPv6D2M7PZi/ITuOgWn4Z?= =?us-ascii?Q?mbhBSOMHbmSOJgIH4BKyZX6RIpJzstqq5B96Txt3lNGSwskN7OOBkDblmMd4?= =?us-ascii?Q?P3L1U8Cz/dEkhO55R4zWQjTH++GrNTby0s9JeJuk05Vjzeg9DpHOLkNJS/11?= =?us-ascii?Q?6HadjiiDx0ZWmKoqS20DlQTYUJdRHAcvcYkHwVmSB/a6AL1UquQRBTXdqfm7?= =?us-ascii?Q?i2L2PzsQYxtKPFCGDJe9WOUhFuRLysAJ6+pWbV7bg3FAlbvajWGZcyMsSZnj?= =?us-ascii?Q?7KUPuaFYpKRFTwEUbh7ZpASw1sQSRwERAzeB7acGSprWLp4wW3tuUMTL48O1?= =?us-ascii?Q?yxjGxh6CkVLJdoj0PHPB7cKf1RScFkhRkqg1kACNJqxG43M2IPcYmANEWyC7?= =?us-ascii?Q?F8hOm+SdY49JZlKs9Ss2NPg5FVQe/Ik/RYhlHNC3SiyXf9LcIUTrC451T4bP?= =?us-ascii?Q?Fi8VvMBqHE+mtfZuIkpQ+IRJFJmeJANgFPFN42G1djB7YT/PiLV2TjvLT6rl?= =?us-ascii?Q?Wp5uopdFgpDzgf/j3/RLgzA7ILkE/HrUCd3L2qlDKdk6jc3CEX08Z+HJRsYB?= =?us-ascii?Q?4lOSSTvtQsVJN7IMtitbsjgHLn8p75+yKlWiwKD0KuyBshVAOm1b4jA1OvsN?= =?us-ascii?Q?0MH7s5TIiQyCaWLcgJHOyP627eYS3yNumv4ZYoeIPPnCMpve6C6fcYxvgV+6?= =?us-ascii?Q?4Q/xvfn1WvKzU55n4VZpvdTiQBi7o2L9iXQ43pIJRsm4z8v3RV8eux74Ar6D?= =?us-ascii?Q?jYF8MzgtL0orv7SdfdIblJtVnppDm/xxhNg6kUMSy21CqdDFCvHGffGn0lnJ?= =?us-ascii?Q?yubYOEcxXVf6OTX34WdzTitgZskYYAxtuJOaGjqB6Wqz2YmgAq97Ey2kFkk5?= =?us-ascii?Q?rQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pB9WgCn9JEV/EAPUHlTB2UAmadV+Ni1yylQPXCeNwznEaguIKpwX5YWffrkGnYONEVDQj5vKdIaDgxiMHHCkM1A2Xai/ANj/8CmFgBkfmct6SSPH21jAKsmLoYlYTCuRrF03tjq+YPkrlqSllWaje8957zvFSGKnwB3fz7Jh3Tlb5CX8sBcw01JnXeMUukhuoP2wOw2hk93YhiutokE744tRL+a13BdjgFTXgQu5ONOqtE6LhsplaNejUt96oIaX2efY4LVQ3Kxk9gJD7vRxcc9EhD/LnrujNj6vEudJKGfH8FbJTXeeeMba93g6D5c4vsvS7A0iG7wu9DjIRkOTFGrGfxHy2t4kaL5Ytw6ecgSDSHSQ4mFdemXQdlzDAfERHZtnaVlUvSAE9gx1Odndy4pui+Oiss/4Q7aWkdugPZKoD6s4BhgmFMrXdwYCcVCY2e6C7772l2hjfzawvmLSbN3rVnQOFXW6Li+VgiDOkJTH2OFftXkoiIH9rIOVgqCKF9lJqUjfTdyioYW/LPJ22nlDQYmboOHCpDPfC5R6D0zeZe4PvZ+08tKTmvzXAd2P7rApQ01ribTBf5DQExe5QSazq6lXQqHYu8ug3w/0T/Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19918742-b8f6-45c8-9e0b-08ddb3fcff08 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2025 15:28:55.0115 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iZ2ag7YKZeM/shYv+5TOJ1Y5wYuG15fhvvayNCKujrQER0t0fPteACNiUkX3zq+9smrpXr2fYnApWe7k0QC8Cyfwn3dfXHfHs/ufARP7B3g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7620 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_04,2025-06-25_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250114 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDExNCBTYWx0ZWRfXwJKV46tov9rr h2uVNboA+cjt6uapb/K1X+gvpW2SDoBBqLVUm81Vpd0HKjKuBaRMPBRf6HuxYnJ2nFcfkJ8gS/z rKYz7rHwOfysV1owEbLRXY7RsKIz7K6BKEGs2h98n4aWFQ1RBt4MX9zuOwolTW+GmvppO+KKrjh ExTepP1Uu7pf2A1zWl+uadTdtGSg7nDpFh2ZPXm9JC/ULvm0eiJdlWze088m1aaq5s4ZbUccApz 2q5iq8/JpgBpOWFtY2zEHwcl2OPDNjmJ6gpntmfjcTf3HVzJZiRABFiFjM0UMQxeVyXZfL8rF2q YAyRhw3vlF8Qxja1WWKqM1kx3prsd8EyhJ4CXWrtAWz27Da/uo1A39bzc2ey84cJzOU98BAAXfH YSk8qne6bNgMfOaQgJJKWCapzrS39dzWtypyInh+Mbw6BEbgK/XKvLKLXS//YOVEIkl5249B X-Proofpoint-GUID: SEq5Tt0FUOvh_6DdlSZR4H94qKMZtlE2 X-Authority-Analysis: v=2.4 cv=QNpoRhLL c=1 sm=1 tr=0 ts=685c15bb b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=eXeZvf_XFns6GfkOVVIA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13216 X-Proofpoint-ORIG-GUID: SEq5Tt0FUOvh_6DdlSZR4H94qKMZtlE2 X-Rspamd-Queue-Id: B6F7B40006 X-Stat-Signature: p4zc8abth69kx8xt619x1ec1bywqz1h7 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750865340-966770 X-HE-Meta: U2FsdGVkX1+qmWqVe1xrZLXx6Z2Fc+yDQZ71gaZgdgQTNRWLYf7hEDAHP+r5zT8ueH2dddUzaSWDhL0ZlfDUdOwtypqwTZkvJSPc3V/dbjKbVd1Zj+AJfMNvkYFstK16PfrC6o9hmC0ElRKbbFUe+oi2rkoJdDC7HzjG+1HG7q3KkNUSxUHuPnWX0yclqFexb243nnHWQvn5cFlmbn7w75AHgEGbIXZCSWgqexsB3aFS9aNKqej41HXm2E5ntHhFecnZx5pcUsP4dwwXex3dtGiNaX+VijGQHAHbgHEo3XsGT9YOp8LKDVqXMgwoJJiErNNIQmaUw5oLFfHP0Ejfts20QAJCChzfBOdk9TyypjuA4cwCwhXFA97MvjCXd8XkBF1ATnRilRm3HQGF3CPk6JuDOKCA178BSKRCAy72QATwDF2y9AjN9idgX3XDcfeMMFfw/MypONxuxhCSmeoUNtqff9YmPvkq8lm6G2VF/MZcKYFSyP+qUitANNQwmcMwBi3KJp0AlE10VoRp3TKNPgQ+cHHDdmAv1gDtmdKBBcFUyVAN51+DXrXk/JYb09aQE+Txx828yNXiTPqHQaBtCGk3lZqC/Gm3aX1cmXkrMsR7WcZS/ku42beEf/2enTaJ45rgj/Spb4Pv4ezz0xV1FsUVBg5Je2scF5xLGgIWqhoGZI0AKyGfJ7Id83p3PC8fnFxCiqsnmNFSwV74BQwNrz+6mngtRko1NL2YnLYPva5K/3ThXyucGFyI6QtFt2avTymp7XsFkrLWBwUuyCr3P4oz4dwrhFprloyKSVUi8RtC0IgDLW1W6/ddyw0Eu5pycHClh3SWm+4mLi0V6zDGvRG8CxJ7ezaQDYnxQyQgFBX8m7LLXIaRWXkfULTIHz/0By/eNsj2QGc9j7wqxR07/K85DB/oivNh/HEXr88uNC5WSe0O0Qhwgm6cXuBc08iqPjvZgo20VGnC0yQZJni 3opAKs23 UkCg2i9wIqAGPD+a4LQCZpXOU5vwoqBoPerQLsw3UbWt9M3uZ/ULUwLEH6A4tWCr8DN17jT+C44uTf7/Nfn3jb+6YJkBgAvq547eU8JEHVn6UdSwfM0o6RRZvSgdAVe5CpePqUDwA/jmOz2TTkL0wV8QQU2qfDJSbVVVrdUb5IxYbAF+bNLCKJSgrnpSJA/oTm711Ex6zC13u5DOXOAclOtlj1y3OQzRPBMFbBITscSXbnVggDql0yEcebAOH2Z2NxJOQLD0eRX/9nYXKPuZi1dGfaveHYqWiJfwkesCwVryis3DCnhohS0calbiyOZce3j5sEaFwxS4rkmB35HCGYSFiDcw+IDN1bYtkdK8Rv1tvESA6iPs9PphT6Vvl2lGBsLzCX0JkEp4fAdjiusCojcchSzE2O/Weudv/Y41aQ51CqT3b5ZxaW/RUdMUug3IqKstaEQ53ZSO4kBJX61zCTL787N4LqaW2YIi8E8gyEzfTvFii/2aexMz/hqVWM0YsJPF/XaFeSWCqv+T9EIGdqMdF1JrSaL125rF99gaLERoxIslE9B5bzcGzslH2kvTSt8GjSUt9niDA7udSsBaXb8nWMaeah4haw8++9cuor0Cwm/LimeS4J1VRy86ewy0UmDv31AfL1Ohm1ib7YEM7ACN3RrKBw4/qCOnuUY0zDBxAkiiX9SGBDJIXfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 10:22:49AM -0500, Dan Carpenter wrote: > Hello Lorenzo Stoakes, > > The patch b714ccb02a76: "mm/mremap: complete refactor of move_vma()" > from Mar 10, 2025, leads to the following static checker warning: > > mm/mremap.c:1920 move_vma() > error: uninitialized symbol 'new_vma'. > > mm/mremap.c > 1895 static unsigned long move_vma(struct vma_remap_struct *vrm) > 1896 { > 1897 struct mm_struct *mm = current->mm; > 1898 struct vm_area_struct *new_vma; > 1899 unsigned long hiwater_vm; > 1900 int err; > 1901 > 1902 err = prep_move_vma(vrm); > 1903 if (err) > 1904 return err; > 1905 > 1906 /* If accounted, charge the number of bytes the operation will use. */ > 1907 if (!vrm_charge(vrm)) > 1908 return -ENOMEM; > 1909 > 1910 /* We don't want racing faults. */ > 1911 vma_start_write(vrm->vma); > 1912 > 1913 /* Perform copy step. */ > 1914 err = copy_vma_and_data(vrm, &new_vma); > 1915 /* > 1916 * If we established the copied-to VMA, we attempt to recover from the > 1917 * error by setting the destination VMA to the source VMA and unmapping > 1918 * it below. > 1919 */ > --> 1920 if (err && !new_vma) > ^^^^^^^ > new_vma isn't set on the first error path in copy_vma_and_data(). Hmm, the first error path is: if (!new_vma) { vrm_uncharge(vrm); *new_vma_ptr = NULL; return -ENOMEM; } Which explicitly sets new_vma = NULL (new_vma_ptr = &new_vma) The final return there is: *new_vma_ptr = new_vma; return err; Which also sets it. So I'm not sure what's wrong here? Am I missing something? > > 1921 return err; > 1922 > 1923 /* > 1924 * If we failed to move page tables we still do total_vm increment > 1925 * since do_munmap() will decrement it by old_len == new_len. > 1926 * > 1927 * Since total_vm is about to be raised artificially high for a > > regards, > dan carpenter >