From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFFAC10F1A for ; Tue, 7 May 2024 08:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766686B009C; Tue, 7 May 2024 04:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7164D6B009D; Tue, 7 May 2024 04:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 590D66B009E; Tue, 7 May 2024 04:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 39BD96B009C for ; Tue, 7 May 2024 04:13:41 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E22E0A10A1 for ; Tue, 7 May 2024 08:13:40 +0000 (UTC) X-FDA: 82090885800.12.33DDB3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id A5786A0012 for ; Tue, 7 May 2024 08:13:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EzCYMAHo; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715069618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0D7kJ1qnE1ifbGitHrjWMHHalzkwljHgHWRhLR/9vEU=; b=BwXWqW7UkmtGaBbY95lmFtN34hl1dMT2BOBd9TpfKSFfW1qKDDvoHyyjmTzoVGuJUaUi4F Fug1u2sxgLMXicE9SzBpmwmtCuchjICt3yQwZorCIJRgQAVoXSd5GIVJjzuy3IoDYL7pjd 1Ra7UEMvU3QHHLbbZMewr+OG66GUiZ8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EzCYMAHo; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715069618; a=rsa-sha256; cv=none; b=nQNRgsE4mNrvWNUyAZ95zeM6n05kqD+yyVvHkOlDiuXWityWXfvBdlvNuD0QbAk8eXaC1c ia6A25BTe/6U/GBo++T4s678smERCU4lbDT246QKjprvYHLgDweKyKmg3w/hSimxJdc8Bi BsIAMMTYUoFQcxQ4mCofDLNuZQIrLDY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715069618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0D7kJ1qnE1ifbGitHrjWMHHalzkwljHgHWRhLR/9vEU=; b=EzCYMAHo/aL5X5t1pTpavN23Fhi3Q4oVNXT4cHTUBxlRrrIdRO019rVcuUhPlWYml6cK2u Q0MrQG7PwC/Fl/07aEznOjWZwbcOrnDvxo/tXBWPE6cyztVDpAI26yH2Ur5KYzs/0lMjww p/f8hqBLznX7gNsE9F0/wQPBbveSsPw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-VzcPY7cFNK-qPX3mfLBcVw-1; Tue, 07 May 2024 04:13:36 -0400 X-MC-Unique: VzcPY7cFNK-qPX3mfLBcVw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-418df23b51cso15126515e9.1 for ; Tue, 07 May 2024 01:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715069615; x=1715674415; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0D7kJ1qnE1ifbGitHrjWMHHalzkwljHgHWRhLR/9vEU=; b=RF9nXVlqmhNWWdRpOeHq5qIxEXFGDtcSA3o608HpWh9eObGRn8yPWMV577lg0Cf63v eCqP+2Czg34Ky84uAWPnQpxSrxunZCtXEHpiC0Ob9OUsSm8zgxIVNz5imtzHDUh+VZ2e 0o1OP9FFDimyWT/kLEXZfo79aquilP0XmIxVUJodf+SZ8FcE12DZ9515lnOSORc4obW9 YSgRscU/agOqjZnYuW4uWAJ7EsVK07zScK8uCjjG9NVNCJ2RXgZFWHhgMJgLdo12O/ug XTRCTu7xf6LM0bdIHYY3n1yjq6GOmOM7yKeuWyL3BWPaAiz2SO5L3w7DciwWYH4JVXeI ZEBA== X-Forwarded-Encrypted: i=1; AJvYcCVpbtgc9iCiasUEmZ1YCJJq95LzeViWkUK9xGoKpsZJAcHLJ/SFSUH4KAMlZliSrLYa1lnKW8++eFktPVjxiWJ2Tkw= X-Gm-Message-State: AOJu0YyWJri6I7icdGEuR/XLqYfpTcsY0ZXvPJoIxVuS7VHgY28VX0mD f0yhEjHquBGhaWHf2pl0myBx61emR09iufAjV5GvJjKceTN7x9VPVCoiD3qBbehv1UHmbKMOeNS mM3LYzcAL5Rxyl+uk8OydVx4e1eSSx53q+pvNFhvHyeA/u48G X-Received: by 2002:a05:600c:3512:b0:41a:c92:d323 with SMTP id h18-20020a05600c351200b0041a0c92d323mr9227579wmq.10.1715069615354; Tue, 07 May 2024 01:13:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbUJypzMJ8qTpkAD3kEukaZowb7+J0NqZa2mJ6+j1UoIsdTZp9UvATWBmT9DDZhIzHtHejkg== X-Received: by 2002:a05:600c:3512:b0:41a:c92:d323 with SMTP id h18-20020a05600c351200b0041a0c92d323mr9227559wmq.10.1715069614957; Tue, 07 May 2024 01:13:34 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id j15-20020a05600c190f00b0041bf512f85bsm22268129wmq.14.2024.05.07.01.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 01:13:33 -0700 (PDT) Message-ID: <016d8cff-efc3-4ef1-9aff-7c21c48f2d69@redhat.com> Date: Tue, 7 May 2024 10:13:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs To: John Hubbard , Andy Lutomirski Cc: Dave Hansen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , LKML , linux-mm@kvack.org, Peter Xu , Axel Rasmussen References: <20240507022939.236896-1-jhubbard@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240507022939.236896-1-jhubbard@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A5786A0012 X-Stat-Signature: ht8bcmxarp3za5foehtgftustyutho9i X-Rspam-User: X-HE-Tag: 1715069618-906820 X-HE-Meta: U2FsdGVkX18X1S22PWBtJOALnTg1I4vo+CuPfDzGuEq4fTcH3004GO+COXVIlxENhY+2j/EX7qOlCHf+yN4xk22vrMRWU/9Ny14EmG4c+od4t0o25R5gC9n3bqx5HahBY6HuIncJGcj7uasOMcguq7KuppgcFcAxBEQJp7pF5z7CyNgdh3En87mSruEu0yRqzCW8YNuXkyl9X6XWvqbXaTdOx99SypUhVTfSUDQUfqxzNqQMqNYzPCyo+gfijMP2r9P5DQIf+qSyMdGn+v0Z8PmkfexX742JPXZIygqiwG6Tv37VjRbayMvYYcVQbjPlS6ey+ZqND6l2OPhIUJjUtMvKnieXxZYz4NZTmPu7xZPpVNC3WgcvbuIgY60rdyGOES7KGtaBdinPqqVRnJpP7sszjflvQ2HobMFaxaCKX9xoiwySjH+QPgNWZuiRj5xLXhNYBZ9cAwmq1B+rjNM0dTtXPeZCKzuC1gdqMFb4rjlhGAbkA4ciF7gDthJ5v4+Ss9MBpcVbBY44BZfh0JVTx96JsYbAvqIhifokXwP56seouOZII07FNvrvtKpqy3Curur6xgpMtdNPyZg4kSV9xrLM4CHc2uBSotwe1W8QdyAfrha10GSvMMiOmnX3rrMHnKp4bLo+AodAlkj+rWB7/UADhc7qSsXQ9TRieFg5VSIFCVXt2Kj9LHsvAf3zsZnbQzNy7a4e9cXLrqSc0oJMJyOcOblXxqI2Nh/UCGxGj5kmPpkhpvhHob9Eoulyqui3zUZtNcQZk6d3xSS9Pg5jSV48E6Iim2YvWVhJClIDsUpuvAd8+iVLCRZZsqxbgxZLGPfq0zIghYAS9U+N3irBy0jggJYbKqQ6NiV168wKFxBXqEloZdhnRSlDORkSi/3MsFunns7aaluWhl/M7EHoi3y/Ubyfw2SArEeXbDKO+xDaBjBbv10tHyUrHzKSurJHdRw9mT3wlQRF21jkj5K wgM0B/+q y9OY2opZFiGNBKGnrt733Sog09Fo9P7d4yMTpldQr3KAnRvQy0TSy2gsii8uXI8P6brmh0qwbqijdtHdBAUi1vbA16VlFD98vv8JWWk0x3romT0SyopoZ7+Jj5UWmC5zeWjDQ0UFM+pbSEKm8V4umKRC1GP6WW33zHOHemMrOrL0tz2mO/OqEzUgi0zoX4sGFxJ8xiQUFsjACAR43kVEIkPgAx5yrjeEU/Iy/uZY89kXVqHiJoyoInvBAt9FQbLyNkVIp3bOusEXhvWUmS4IEYTjTXM47mbQvBhKx1wvMA4Mfsa3+zXNVV3XfHQ2a/yr5ta3Lcspu4Say0RBVzmMVxoq56YDwshIDi0OQPMm+vbbJmUhie1Ah/83vscYTVnj5Du1QtTSRCcS/mXRpDYWtmm+DrYEh/Mx8u+txU3p570PrOAVAjyi2KRlcZk5aEtE1zoz42yP9U2TozvXS0tONI8TLYifryVE0zTL0w9hSnqTa3q7xerR9VKpQO9fjCsoM4iZ5WqZ+R4RPNTUelJqitlCngN9yPTxgg4iLo/MmbMG+4z1Q41jy4HmWwQlhM1sIXkcm0emwTEBwwFbrRJEnyM8T+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The patch subject is misleading. This should be "don't flood the system log". Nobody cares about the speed of a unittest ;) On 07.05.24 04:29, John Hubbard wrote: > If a system experiences a lot of memory failures, then any associated > printk() output really needs to be rate-limited. I noticed this while > running selftests/mm/uffd-unit-tests, which logs 12,305 lines of output, > adding (on my system) an extra 97 seconds of runtime due to printk time. Recently discussed: https://lkml.kernel.org/r/a9e3120d-8b79-4435-b113-ceb20aa45ee2@alu.unizg.hr See the pros/cons of using ratelimiting, and what an alternative for uffd is that Axel is working on. (CCing Peter and Axel) -- Cheers, David / dhildenb