From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70841D462D0 for ; Wed, 13 Nov 2024 16:26:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9C716B009E; Wed, 13 Nov 2024 11:26:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4CCB6B00A7; Wed, 13 Nov 2024 11:26:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64E56B00BE; Wed, 13 Nov 2024 11:26:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 835EF6B009E for ; Wed, 13 Nov 2024 11:26:16 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3719A80B8C for ; Wed, 13 Nov 2024 16:26:16 +0000 (UTC) X-FDA: 82781596968.13.C083027 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id D26A3C0014 for ; Wed, 13 Nov 2024 16:25:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weMFu3bi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1jNDs+Ni; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weMFu3bi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1jNDs+Ni; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731514939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=alkqEOzDsF7o+c45FSOLYXKaghCcU2hvyUGMJsUjNDY=; b=HSKZkG2eHEc+ojsFROdWYCAdTgvjEIcfUFXC3ER4/POVSWHC1hDu5vVnEywUL2bUh6X92l 9hsgIpmDW63xrlBtMowgdzogd0e+kS+/GD+yWxXuN9qQgbBRQtKl5I6gzZwTh88lpJVPQr cOQ8fY5Teoec0dkI025n/7Pb+1FkcfQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weMFu3bi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1jNDs+Ni; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weMFu3bi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1jNDs+Ni; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731514939; a=rsa-sha256; cv=none; b=spdfqSBa3D85Uq+PP3W0bNjKLIOcNFhR/2zkxKYDDhGRE1Gh1u21Tu/yAcmV1nGt5e/LuJ O6mveQK6ELWHf0wRPwMkqpVumpJvHN44ijsW/G41d0Ju201MUIs6pIBI39y+Z5RDdPm6RW l5lu0i1Lr1AKlznYens0auISvvkrnVY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0C2B721169; Wed, 13 Nov 2024 16:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731515172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=alkqEOzDsF7o+c45FSOLYXKaghCcU2hvyUGMJsUjNDY=; b=weMFu3bisXPCTs8gkD6mjQepRS5uRK2qwfX89o9qNXq4qiV0dYQo5nfbH1FYyq5EkNlGpV YVOQug5Or4PgJeVBcfUNw8zg71C5UGxx43SfYtRf7/nakw8NgokaWFLosPV+Qqeb1wWvTB gqixWaF0c7DH63N6hwOZlT6rL91uQ/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731515172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=alkqEOzDsF7o+c45FSOLYXKaghCcU2hvyUGMJsUjNDY=; b=1jNDs+NiDBe7E0TmB4J5ATL/BqxRhl682Oyw1mCUaVjfC+ia68NYhPYv8/kzkWoYNWn2Ci OvXDavmqDeOSwEAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731515172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=alkqEOzDsF7o+c45FSOLYXKaghCcU2hvyUGMJsUjNDY=; b=weMFu3bisXPCTs8gkD6mjQepRS5uRK2qwfX89o9qNXq4qiV0dYQo5nfbH1FYyq5EkNlGpV YVOQug5Or4PgJeVBcfUNw8zg71C5UGxx43SfYtRf7/nakw8NgokaWFLosPV+Qqeb1wWvTB gqixWaF0c7DH63N6hwOZlT6rL91uQ/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731515172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=alkqEOzDsF7o+c45FSOLYXKaghCcU2hvyUGMJsUjNDY=; b=1jNDs+NiDBe7E0TmB4J5ATL/BqxRhl682Oyw1mCUaVjfC+ia68NYhPYv8/kzkWoYNWn2Ci OvXDavmqDeOSwEAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F114A13A6E; Wed, 13 Nov 2024 16:26:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gk45OiPTNGeLMwAAD6G6ig (envelope-from ); Wed, 13 Nov 2024 16:26:11 +0000 Message-ID: <01657c51-f7f5-4d66-a2b7-9bf0f1acc20f@suse.cz> Date: Wed, 13 Nov 2024 17:26:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC for stable 5.15 and 5.10] mm/memory: only copy anonymous pages during fork() Content-Language: en-US To: David Hildenbrand , linux-mm@kvack.org Cc: Peter Xu References: <20241113160103.48943-2-vbabka@suse.cz> <5c881108-41d8-4e8c-a1ec-9c04bc68a008@redhat.com> <5929cbc4-d8c5-4b1b-b7ca-b4daf47b13d0@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <5929cbc4-d8c5-4b1b-b7ca-b4daf47b13d0@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D26A3C0014 X-Stat-Signature: kpmdfedht3f3gsz5w6fdpruofennuf34 X-Rspam-User: X-HE-Tag: 1731515129-189366 X-HE-Meta: U2FsdGVkX1/07jq5kGb8xCGHGt2caH7askNUcsYvmrKIH/m4W0bftU0k7mfmC+FZtJKwZrV/tR5n2DbdcnzLkka/kBOM+7CysQNvkKK3Q7bePaUBuX9TED4sIKQITedw2OqX22PxyM1gbJk1g6ZpSTzj0qT9IufuoVuhRGQ/ylIDTeG7tDYgNEPD1rZMdrWPwE6+W5L0gsqdjXrpsI0EuxGRxv4z+3+HiyiSr5Gf/9pVX8TQzy32JlGGxyRu+c8cjbQ4E2DWOs6Eb2wdELmayCi1r7IUUWzBsz61ulHiMFdF/OaoHIGcNAKlusJwxqDWaBggHlAHms3ilj3gWdE6tYn8d+sWwlX7E3gPA0XKm45CmMc178LW2790PsMfQSGv729KOsJSwfY454b3/3Mh7NVntJLB/r+kwk521r58Vjt9o4EBNZ68OUZJev4gLbLKVQPl1bq5UxYN8RENF7MvWTDsHuk0vHBVjnvwmXuSlnCZL5KkL3zF0UvOTfu5m6Haam59IcJlCCtIgf9ZJe60vdaov5VTaV0/74MduWEkvPZipJr6Ba9nAVkQxRjfwq/1hBvwyN9UbuI98EizFNQ6jL5n44lXa7wJzveAFvL4TvYa3emm0BpfY0WY3sKvIudZYDQdxyk5Jj3xPbZzCLx/Qvkxk0KnlraygrAjZGwuMlrpKOKjmkbpLstxtaocjvP+1YH0WAZZcVyRndeUcqna6Row2xEIs1xgA3RF+5CSpDxk6hScgUyS5Veem7xxvzNh+8jVTFuBoJT7FSPfIZvBLD35UHhrFHCgE5p0x8pRH739dtceaHYAPBW/sZTY0l5raJKFTFtXtDDP5BCn7N4xAtk4USBLPOyjoSyxyhXiugD/yD2VuBmgNluBdd+TqnrHeXU1gkQ+zNgnizQPvPjD4HbhLIR8Vj4goNnMip/kCTRGQpaOIuc81BAB71RC4GBp63kjC/qNpoJO+Q5+IhY zG0DeDej F76nTicEp7X9vw9Zt3IsC51nBh7LBXkXXpoQucZqLCFXxrQQPb6qZvu7Jr591RRkYC9nNNEDwrhMy6+ShgW6IPEbJLPciIyOuPGcPs4P4iUveruzcE8DgaUeWbt0XIj7xxGNlzHeKJz+uR16xzVDSoj/ARSoQ6yl11DCrBD29GpFzdhMzR3/KfALT1v/+96NrZKUl5mxJvpIuiedzhBs0A2KBDwXYLU4Tc1gNnmYFMBHLyeOS6GVUXYl3u2E9q/OZt3V9V4W0EzTfVXRLaTfRTCyBuAXMRFCI28P78874F/MJVRfqqsBV1KxU4HLMDucHdynZ3zr9L6wdr2nWOcnNdv7Tiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000483, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/13/24 17:25, David Hildenbrand wrote: > On 13.11.24 17:18, Vlastimil Babka wrote: >> On 11/13/24 17:09, David Hildenbrand wrote: >>>> --- >>>> Hi, we've seen this in our 5.14 based kernel and it involved the out of >>>> tree gpfs module, but I believe the same thing can happen in LTS's 5.10 >>>> and 5.15 without out of tree modules as well. So I'd like your opinion >>>> on this fix before I propose it to stable as a non-standard >>>> version-specific fix (I don't think we'd want to backport fb3d824d1a46 >>>> with prerequisities). Thanks. >>> >>> I recall seeing+discussing this exact patch already a couple years ago :D >>> >>> Ah, here is the 5.15 version >>> >>> https://lkml.kernel.org/r/20221028075244.3112566-1-songyuanzheng@huawei.com >>> >>> And the 5.10 version >>> >>> https://lore.kernel.org/lkml/20221024094911.3054769-1-songyuanzheng@huawei.com/ >>> >>> >>> ... I could have sworn they got applied. >>> >>> ... and in linux-5.10.y I see >>> >>> commit 935a8b6202101d7f58fe9cd11287f9cec0d8dd32 >>> Author: Yuanzheng Song >>> Date: Fri Oct 28 03:07:05 2022 +0000 >>> >>> mm/memory: add non-anonymous page check in the copy_present_page() >>> >>> The vma->anon_vma of the child process may be NULL because >>> the entire vma does not contain anonymous pages. In this >>> case, a BUG will occur when the copy_present_page() passes >>> a copy of a non-anonymous page of that vma to the >>> page_add_new_anon_rmap() to set up new anonymous rmap. >>> >>> >>> >>> Maybe you missed that the PageAnon() check is simply a couple of lines >>> further down in there? >> >> No I was only looking at the 5.15 branch so far, and seems it was never >> applied there, unlike 5.10. Weird. But thanks for the heads up. > > Indeed, looks like it never got applied to 5.15 ... The author forgot to actually include stable@ will forward it