From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FCC9EB64DA for ; Thu, 20 Jul 2023 08:42:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7DA82800DE; Thu, 20 Jul 2023 04:42:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2D8428004C; Thu, 20 Jul 2023 04:42:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C392800DE; Thu, 20 Jul 2023 04:42:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7C13B28004C for ; Thu, 20 Jul 2023 04:42:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F0830C0241 for ; Thu, 20 Jul 2023 08:42:18 +0000 (UTC) X-FDA: 81031348356.19.16920ED Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf28.hostedemail.com (Postfix) with ESMTP id AB308C0009 for ; Thu, 20 Jul 2023 08:42:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689842535; a=rsa-sha256; cv=none; b=CELhVu6epMWMgahJJW8ipJyRbsnepEU804rr7E1tngaBJ7K/lZv7uK10L+LY8DWi4riPr5 Meidvj7/k9xRnGMuAP8PeMOfvwrhsr566UntO5lU4mIKpa0eZ2dWSQd/8OEplCkwpc7RfA P6OHx4ch7D0nQzKV7ti/2kXgO03ZVLY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689842535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B3IiENGLYlZCGyxBi9XWl0xOnmPP/tAYGnjYkVFpVJM=; b=HneU1zta2fc6PUlgeozdy4XX6lXUhfz9A3UuzXGPbbyrxpUjJ7iy5h0h5WAMK3IkZgAC+r 2qEZ6HCTfGWMPiyBRveMxj/YAgHwPvA0Xok2CpS2EQJkJ9PKP+r4k5opVBKbWmCY6Fixhd iEZ07I1FaWzD7LriaZN2soU3Op+JfxI= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R65kl660XzrRnN; Thu, 20 Jul 2023 16:41:19 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 16:42:05 +0800 Subject: Re: [PATCH 4/4] mm: memory-failure: add PageOffline() check To: Naoya Horiguchi CC: , , , , References: <20230715031729.2420338-1-linmiaohe@huawei.com> <20230715031729.2420338-5-linmiaohe@huawei.com> <20230720010953.GC1583723@ik1-406-35019.vs.sakura.ne.jp> From: Miaohe Lin Message-ID: <0161d32a-79d8-912c-0981-496a15f3eebf@huawei.com> Date: Thu, 20 Jul 2023 16:42:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230720010953.GC1583723@ik1-406-35019.vs.sakura.ne.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AB308C0009 X-Stat-Signature: n1dtsg5tsr78a34hk8kfsrjsh6ff1rwa X-Rspam-User: X-HE-Tag: 1689842534-881015 X-HE-Meta: U2FsdGVkX19UXanXgBtWMslDax5zuByFzs3Zbz8CWVdZCJnmbjX+ZOqEms0mh+Av4lGpdI3NZ4/y4dB5CG3xRB+HtiVAijs7tG32t8KN+O6EAI6Pb4yRDc5mUpCM4Cr748Jb0GXQN2YoJnzYM1sRseqQez9q0tlHJagPQgRvPD2WqOgr4gpXu3jbXkBWAy62xEUDHd6weAdrrMBAck4bxPCr/KLPAhKyhp9UbRr38QAxpfdvQuoM3kMVfn8p9NJQU+8U2egwiz8WPdQpCrWAYgsDvLfVr1hHIU4G1Y1P6HJNcSkiz08VFtZwy4TbKuya7p4FAr3saq0o4nSsYo6N68UvTuhlwnf1TM+wF5pSC+jEfbs+I6qblTXTMOf55dhFDfNPzySftWoTQq8TzjhOQkojdkGsrtDO6cWvN4I/KQKBWEoi4UWxj92zEd6eCtfsqih0oVy5X8CVqfN57dbaFygPptkw+xiyluymtmqVJbRk9WBtqct2+Mc1zcC592n9JavATjT/v60pbbjdhgzLTa41OABnowZXFE6nnag6JV8Nj2aQrbkkwAQqx1WlzL2fSYlHC2YXSFpK7R+Io8vKMmq3KfkfaanyFG4pY3NZWKLSIyFFskpUBV7lA81LqRnn/XXbrN8FqOrwrEEgje8UDKsKN0F5g3i8vKrRKGq90pKhNRBt0PEROyrQ4D5pxnU3ksHu0JXH+CLMQ+0P6IcOgr4/8E8Rd1Jrj3t3I1SGoIqnKAz1zisQdm6ePoemgjQpQ9VrVxvx5xIpnMzKidEvG1xLS5gOEOpm3tXCyanow5BsP9+xPmgY0UQwUSpF+rsdf1q5jw8JyzJgh+LU7MrvD3geY36oE5u+yhTZ0cgdINXkqb+b6QadfA4AxQe8e3PAj6Dh+XuJGuyAICudGRrTsT9mDKhlljdyA2LHdLGchFb7wUEM2xFcGxM3NngZefVCbX3nNbY93/T0bTEu35V Nve7InJz ZUrOVHF4io/5VNnxRX8qo88zeeStgsbJGihyooyxgUywriOTk0sJU4Owg7OI3kkoIHyk8jLs1Ct0peGdTINhgv5HPuXii7pjfIaNmc+k/y/gPr/W8Uo4ogWZM1U0JaVybPqoI48IAYxFyuDn6gcvAl9pLcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/20 9:09, Naoya Horiguchi wrote: > On Sat, Jul 15, 2023 at 11:17:29AM +0800, Miaohe Lin wrote: >> Memory failure is not interested in logically offlined page. Skip this >> type of pages. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/memory-failure.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 42e63b0ab5f7..ed79b69837de 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1559,7 +1559,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn, >> * Here we are interested only in user-mapped pages, so skip any >> * other types of pages. >> */ >> - if (PageReserved(p) || PageSlab(p) || PageTable(p)) >> + if (PageReserved(p) || PageSlab(p) || PageTable(p) || PageOffline(p)) > > hwpoison_user_mappings() is called after some checks are done, so I'm not > sure that it's the right place to check PageOffline(). hwpoison_user_mappings() is called after the "if (!PageLRU(p) && !PageWriteback(p))" check in memory_failure(). So the page can't also be PageReserved(p) or PageSlab(p) or PageTable(p) here? I think the check here just wants to make things clear that only user-mapped pages are interested. Or am I miss something? Thanks Naoya.