From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC78EB64DC for ; Thu, 15 Jun 2023 09:48:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF2CD8E0003; Thu, 15 Jun 2023 05:48:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA2AF8E0002; Thu, 15 Jun 2023 05:48:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6B228E0003; Thu, 15 Jun 2023 05:48:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C754E8E0002 for ; Thu, 15 Jun 2023 05:48:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9944D120B77 for ; Thu, 15 Jun 2023 09:48:44 +0000 (UTC) X-FDA: 80904507768.06.A005F4E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 6579C1C001C for ; Thu, 15 Jun 2023 09:48:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NatE6MF6; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686822522; a=rsa-sha256; cv=none; b=g9zkdvDhYdzecGRmbnWZLb4i+9JLYIKbMCDIAl91WrMAUYnhOGEynr3ZFjNJN0d3vtpbLW gmGwqmznEJntsWCI3yjTrd9DRxw87QEGStu8FuiJtvxOu1KDh8TmgdjPYA2PjvUZaF0ShO 540hYXiuHONcHebHMfu+amcCB1wjCpw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NatE6MF6; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686822522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFas5ce2A1vgl/Pd1KLK4gSYDaGRoYeIBhP4kavIodY=; b=Q4aG2EVmoQ3C33meQu26UrZkmn2/WlLm976mn1Un+SWiHLA0m1CcW+QSkdvGS4tXzMNZuB VNeAVZlQTa6keuKat2ZEWQ9NnSZi4aqM0KPF3MdFMQ3eLz/d3uLxC10kmvav31juyAZQ3i JJi9eNN9cxMTXCXis7FKomT3nWnULiI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686822521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFas5ce2A1vgl/Pd1KLK4gSYDaGRoYeIBhP4kavIodY=; b=NatE6MF6Y8/dQzJmdg6A+ecH12fVPACPmDm10/TAB/Ble/Ybzz2uqmFMNNPA9siYSIt1oI ItCppK0Ft45XiLOk8Mt1HQvwf/Br5PtJsuhIsSmwX7IbxjRzAXXildQPRVD9d0QsnHC3k3 mo6ZZMZ0PdbzeBICAEGsF4RqH7h6dXU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-m8tkrnyTP4e6OSPcu-xxsA-1; Thu, 15 Jun 2023 05:48:38 -0400 X-MC-Unique: m8tkrnyTP4e6OSPcu-xxsA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4f76712f950so1584204e87.0 for ; Thu, 15 Jun 2023 02:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686822517; x=1689414517; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tFas5ce2A1vgl/Pd1KLK4gSYDaGRoYeIBhP4kavIodY=; b=RpUScs01Gn8ksb1+ZHehg2Fj5cTma1pu16PPil3jhRBfWebvzpuyY/AFyPcXuYpq1o f3Kysa+RoOcqisGF2qrVcF9xX2fRUwfefCAjKQJglckaN60gYNLwd0N9aHwcmeya6CPM BuyM2g7l5sFQyiaH1Uj7EZe0ZCVTcAH5MU7jpc/1UKAtfZ7UF1iqKFb6/UKbWJovGtpe J7dlV6u2foDpyDBzRvaZS3ioOBUoarjY51XTSN0KqYZIqRWtdvT3Lk3WCXBA1BIz3FJw Qwrh3jyOTKwJH57LkXgQ6ckqIW3B4DMWb6bT8u8w/HRNV3nobXm6eXIsd2ESYdgOpIZi sOXw== X-Gm-Message-State: AC+VfDz+wvXZzivZOdcIGje5NEN+bzaCuSeS1xsfaojVVp501xninDHW A8LUF7lA8JBr4jyU8H+BGaI6RXqqxiTzrdyWK1TMtZy7feZZn3XTRjJ9RQXivk6U2LkC250n8HY x1Z8kVm5XaDA= X-Received: by 2002:a19:f205:0:b0:4dd:ce0b:7692 with SMTP id q5-20020a19f205000000b004ddce0b7692mr9513515lfh.46.1686822517132; Thu, 15 Jun 2023 02:48:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46ndnLtQ+lzJHNZ0kHKuZExuBXAwZ8nLK7yynFFKnsFo1JVRKjQW7nWIYv41TgUUl1IrX0NA== X-Received: by 2002:a19:f205:0:b0:4dd:ce0b:7692 with SMTP id q5-20020a19f205000000b004ddce0b7692mr9513496lfh.46.1686822516710; Thu, 15 Jun 2023 02:48:36 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id z15-20020a7bc7cf000000b003f6129d2e30sm20115269wmk.1.2023.06.15.02.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 02:48:36 -0700 (PDT) Message-ID: <015062b6-2d4a-7b91-8f64-1695f526f794@redhat.com> Date: Thu, 15 Jun 2023 11:48:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: "Kasireddy, Vivek" , Mike Kravetz , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "dri-devel@lists.freedesktop.org" , "qemu-devel@nongnu.org" , Hugh Dickins Cc: "Hocko, Michal" , "jmarchan@redhat.com" , "Kim, Dongwon" , "Chang, Junxiao" , "muchun.song@linux.dev" , "stable@vger.kernel.org" , James Houghton , Gerd Hoffmann , Greg Kroah-Hartman , Andrew Morton , "kirill.shutemov@linux.intel.com" References: <20230608204927.88711-1-mike.kravetz@oracle.com> <281caf4f-25da-3a73-554b-4fb252963035@redhat.com> <676ee47d-8ca0-94c4-7454-46e9915ea36a@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)' In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6579C1C001C X-Stat-Signature: pw63pjpyyuyk45b9q4an6n14tcdpfhc1 X-Rspam-User: X-HE-Tag: 1686822522-390570 X-HE-Meta: U2FsdGVkX18b9op4r1uwRNu0fzP18Sbq8uyE4KQCmwHbJ1zOhwEmlEQWtZOVfJStr7upIei9l1haVKTTypzoEW8UwtJ7rWgLs+ki/tf023FJllMVAM71SPn3JGHIupD/sgZUekQno1E0VMr9FVhBCxm7elPkbP7MbST/PBRNhC9WX66zgXZJfQ2KAD3mVDxTfNQgw8KIPPupW8/4fd9RTuSlHvsIkold4xNtnfKOTMOfZWOfoczuZU0/bM1amNelPnK+IVwZzDXagyfVo4f1kiApoFOOeV0XRAmtENFKmPDvPwbop1BDmnahyiq8CKkWlpI0PanuOuGnhMioXyTwVkmfYKHgWy4qqmWI0fORjyCPWgWvECAlUEhCevQ+4kxZqRZs1K/HSScMcoDpim41MpG9pS0gdi62xuEkzECc9xmdlDq14n38grKN0Njge6RkV2lP2nSmDZuHgq47Gvhqm3j4+kJJ60QvRE67gQ//VlGfijMVUxPFa5qG0OnftGY990Is4GGDo82TALNivM/x91/d+wgJjq8tUa07aXmoSQgLrwF6pQqYelFy3Lm5IpqoIq7N4v32MPv+d+IFNwWB0ZBtEZAHNRJGNEpZ1swMOJUm5oXHQpx8+nu5XtTx/WZYal22/BtFtxANTIEN/+YVLiQ8G/URGRakbxw6CKHI2xCOZBfIX7EOPJk/wkO4efB0zj/beh44n6nVTibwaA9AKaaEBLfQgZWYsPc5TZQa6smV1jHLVeL3JxRlO1G2qcdbgPLaE0/M4evG1VYVkgDehs8ve726MclznIWvNwMczHGSDem2BF3+NcgbbCHgHXsyW8JI8wRfzLhLYL0+MMxISDA4COWRHf4waqBWC0OvBXcqBm6Qv4QIuv0KWz1jvhYBXStBXndxzVQFsPLqorawiLHia/3JdBPxtpw1G64FAzatQwUXcXCrRZA0wKw5VgNcf2X9JP9ivXGRZUt1JjM 2tY/QaI0 hBGoRci088/O2oBIwybyuinAfHFOj1iwYGAj8nA80ZWWBaILc11S+SdMmDtKVyql+Mkp9BfaJ0RLP5jr+Esh4eSqsgUsqy2lWR8dmiNTvYbw+XD7wLfRJms/VIcf53LtLBZeUHvwmz5Bl/3wBvWgYDMQai+l/lOStb5Xpz+xbMR+s48wNLPFXXnAXG3LB4ccKUw9swqu+NYAc7j999MJiJTCczQABP6+yTdsfr5lVOxUuPo/XbBZySpwNi6zw7hLPAQ2HnZEqdMmgC5kPe3ZHPuYjuk1SkBdzHwYfz6MWY8Ahl/gYHStCJ2GlEuVVe9on7AMhmzUI7+x7/yaGJmYPpIUWnjwk6uOLVhyaiP5+pq8oJtnicHVzkPt7yi6NRRs1N9aYsRdWRW/NMoEEvwWxyhpVh9mWSATOjV1twvxQoNiadCNys6z/XZEZ6PTOZgZwQMDY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> Skimming over at shmem_read_mapping_page() users, I assume most of >> them >> use a VM_PFNMAP mapping (or don't mmap them at all), where we won't be >> messing with the struct page at all. >> >> (That might even allow you to mmap hugetlb sub-pages, because the struct >> page -- and mapcount -- will be ignored completely and not touched.) > Oh, are you suggesting that if we do vma->vm_flags |= VM_PFNMAP > in the mmap handler (mmap_udmabuf) and also do > vmf_insert_pfn(vma, vmf->address, page_to_pfn(page)) > instead of > vmf->page = ubuf->pages[pgoff]; > get_page(vmf->page); > > in the vma fault handler (udmabuf_vm_fault), we can avoid most of the > pitfalls you have identified -- including with the usage of hugetlb subpages? Yes, that's my thinking, but I have to do my homework first to see if that would really work for hugetlb. The thing is, I kind-of consider what udmabuf does a layer violation: we have a filesystem (shmem/hugetlb) that should handle mappings to user space. Yet, a driver decides to bypass that and simply map the pages ordinarily to user space. (revealed by the fact that hugetlb does never map sub-pages but udmabuf decides to do so) In an ideal world everybody would simply mmap() the original memfd, but thinking about offset+size configuration within the memfd that might not always be desirable. As a workaround, we could mmap() only the PFNs, leaving the struct page unaffected. I'll have to look closer into that. -- Cheers, David / dhildenb