From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC3CC433EF for ; Tue, 28 Sep 2021 10:53:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AFE66101E for ; Tue, 28 Sep 2021 10:53:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AFE66101E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DF7D5900003; Tue, 28 Sep 2021 06:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA786900002; Tue, 28 Sep 2021 06:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6E9D900003; Tue, 28 Sep 2021 06:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id B45A6900002 for ; Tue, 28 Sep 2021 06:53:50 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 698178249980 for ; Tue, 28 Sep 2021 10:53:50 +0000 (UTC) X-FDA: 78636671820.02.FB63633 Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by imf26.hostedemail.com (Postfix) with ESMTP id 06B2120019D7 for ; Tue, 28 Sep 2021 10:53:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632826430; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=NZcnDpRDCvHoGo8Uu7Z28aE4Y4k3OjuuF5aRxTueu0Q=; b=Bgbj3rJKyOltPxlb48bJNlME6LL9YuSDBi4SN+nRgN2FnZgnwHbFAThS21KuIF8qfTvZ18dA mA7wfoE6TPJATHXaDjMuY2o2qUgguMAI5Hmn26fhv+pcCwxw7ldtc/5KTmCjGiB6rM9iVxow sAwyvpguHzYvF2y1hdveQF4V/Jw= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 6152f430713d5d6f96ff7916 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Sep 2021 10:53:36 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E9401C43460; Tue, 28 Sep 2021 10:53:35 +0000 (UTC) Received: from [192.168.0.109] (unknown [49.204.180.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: faiyazm) by smtp.codeaurora.org (Postfix) with ESMTPSA id B807DC4338F; Tue, 28 Sep 2021 10:53:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org B807DC4338F Subject: Re: [PATCH v1] mm: page_alloc: Add debug log in free_reserved_area for static memory To: David Hildenbrand , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: guptap@codeaurora.org References: <1632819849-511-1-git-send-email-faiyazm@codeaurora.org> <248ec931-7c16-3e2d-cc8f-8ce0dd4e923b@redhat.com> From: Faiyaz Mohammed Message-ID: <0149edd5-fe7f-2786-413c-6de2eab3e30c@codeaurora.org> Date: Tue, 28 Sep 2021 16:23:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <248ec931-7c16-3e2d-cc8f-8ce0dd4e923b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 06B2120019D7 X-Stat-Signature: o536h71tuk4sfawaygujat1iwanrapht Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=mg.codeaurora.org header.s=smtp header.b=Bgbj3rJK; spf=pass (imf26.hostedemail.com: domain of "bounce+d06763.be9e4a-linux-mm=kvack.org@mg.codeaurora.org" designates 198.61.254.9 as permitted sender) smtp.mailfrom="bounce+d06763.be9e4a-linux-mm=kvack.org@mg.codeaurora.org"; dmarc=none X-HE-Tag: 1632826428-3969 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/28/2021 4:09 PM, David Hildenbrand wrote: > On 28.09.21 11:04, Faiyaz Mohammed wrote: >> For INITRD and initmem memory is reserved through "memblock_reserve" >> during boot up but it is free via "free_reserved_area" instead >> of "memblock_free". >> For example: >> [=C2=A0=C2=A0=C2=A0 0.294848] Freeing initrd memory: 12K. >> [=C2=A0=C2=A0=C2=A0 0.696688] Freeing unused kernel memory: 4096K. >> >> To get the start and end address of the above freed memory and to acco= unt >> proper memblock added memblock_dbg log in "free_reserved_area". >> After adding log: >> [=C2=A0=C2=A0=C2=A0 0.294837] memblock_free: [0x00000083600000-0x00000= 083603000] >> free_initrd_mem+0x20/0x28 >> [=C2=A0=C2=A0=C2=A0 0.294848] Freeing initrd memory: 12K. >> [=C2=A0=C2=A0=C2=A0 0.695246] memblock_free: [0x00000081600000-0x00000= 081a00000] >> free_initmem+0x70/0xc8 >> [=C2=A0=C2=A0=C2=A0 0.696688] Freeing unused kernel memory: 4096K. >> >> Signed-off-by: Faiyaz Mohammed >> --- >> =C2=A0 mm/page_alloc.c | 5 +++++ >> =C2=A0 1 file changed, 5 insertions(+) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index b37435c..f85c3b2 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -8129,6 +8129,11 @@ unsigned long free_reserved_area(void *start, >> void *end, int poison, const char >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pr_info("Freein= g %s memory: %ldK\n", >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 s, pages << (PAGE_SHIFT - 10)); >> =C2=A0 +#ifdef CONFIG_HAVE_MEMBLOCK >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 memblock_dbg("memblock_fre= e: [%#016llx-%#016llx] %pS\n", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __= pa(start), __pa(end), (void *)_RET_IP_); >> +#endif >=20 > IMHO, the "memblock_free" part is misleading. Something was allocated > early via memblock, then we transitioned to the buddy, now we're freein= g > that early allocation via the buddy. > Yes, we're freeing the early allocation via buddy, but for proper memblock accounting we need this debug print. > I would not expect memblock_dbg once memblock might not actually be > alive anymore. >=20 Here we can add pr_info as well, but the intention is to get callsite and address info when the memblock=3Ddebug is pass through command line and it is for debugging purpose. Thanks and regards, Mohammed Faiyaz