From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F55EC021A4 for ; Thu, 13 Feb 2025 11:23:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 106456B0083; Thu, 13 Feb 2025 06:23:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 018BA6B0085; Thu, 13 Feb 2025 06:23:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFC066B0088; Thu, 13 Feb 2025 06:23:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C50AB6B0083 for ; Thu, 13 Feb 2025 06:23:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6F5E2140BBF for ; Thu, 13 Feb 2025 11:23:14 +0000 (UTC) X-FDA: 83114685108.12.85D917E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id C117E1C000C for ; Thu, 13 Feb 2025 11:23:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739445792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KQKt9gJcEjwsdD/XKr5BddoRRpzqugGZDbUGizbLTew=; b=YZbQZnWYfVjleU/swlTEpkUgoXuTLuk49gELRipys5ZgKGJPn9KAtqjFcFhBEtQXD+74uD 4iqHgwrIAzacROb5JqBTMzBRNsQvuD/x3MqrHIXlX5rW5XvWzWg416SSMFqb1482rzWKqL uIjBYypCzXJSVQyBtEoIQrI0DN9rlFM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739445792; a=rsa-sha256; cv=none; b=8I4+l0G9szbhRk7u/lelAt8fIqBfLPW+RwPB+cS3sdifGAJyxdc1tLwXVQF11Q77XXuuTp xYWaclnHPpUyCmrrQU/VN6yJCN6XfLBQffjprI+5zqET5kk7gO54pmrDjtTZxm7j7hjTkL 0meG8379BHOFnKFEJ6frCkSF4I0tuyU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2DF726A4; Thu, 13 Feb 2025 03:23:32 -0800 (PST) Received: from [10.1.32.44] (e122027.cambridge.arm.com [10.1.32.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CA3D3F6A8; Thu, 13 Feb 2025 03:23:10 -0800 (PST) Message-ID: <0141324f-19e9-4e40-9500-df3bc140f2d0@arm.com> Date: Thu, 13 Feb 2025 11:23:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: Make DEBUG_WX depdendent on GENERIC_PTDUMP To: Anshuman Khandual , linux-mm@kvack.org Cc: christophe.leroy@csgroup.eu, Andrew Morton , linux-kernel@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-3-anshuman.khandual@arm.com> Content-Language: en-GB From: Steven Price In-Reply-To: <20250213040934.3245750-3-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C117E1C000C X-Stat-Signature: oxngr8b7tdzwxswp3p8cztfbim7pdocj X-HE-Tag: 1739445792-417201 X-HE-Meta: U2FsdGVkX1924ON/eAqWUX1NFkFjs64eEGD/vUv7VZNVTG31HQvzCn1CHBAwJevCS2JSrltrPknOqZZ8/8R6bXjGiUxFumEKYAI5XP0b4X1t8h15FLQga1JAcxBdS4xFuXAiHbv4jNCa947MXd33I1rStAkzGT5BaTBxwIV/rxlcbDhZmI68oWEKmY203kVPEHXGAYSUlXdqsqswZwka5/Q1UD8yuT1oUwKZ4o3VLJQGsL4KcdOAnrhFV11yDQLPWCxgFZGheIKo2myGcxfiG9Bkru2cITu91mDJstBcz6CvOUXbVZFa17RTPuagnYjnCrQA/6YPdg/BmpwNDFiRajdqs8UxodxbzvgaB4EPL4oLAF3zN+KhCGL3y4LlEe8LxPCPJKIwrbpjllcWxRhbazdZnbnsnJ9PhHer7vWGsb5eY9C/ZAyGKeFOdN1guiNA/RjHvcacNKiEZ6/kEQhIi+7wXOpadPkKa9j8iBdWv0rPTdWm+/JKNu4j7FrgD3PEv8nGh8Z3F5nV4MyMl36TLhSTRdgvMzZ8bYLGXjwMft4RHwCuY8aV7Abn0GgACpw/AdHKxqSJdxOMbIYfFm7EMPAwpiYslOpGQ7W2+BYbvNDJay2b+NDqtgR8jTXZtuTJz04X7B+3EkM/ydKMWK0GZyD+MqRBhcxKOmdYBqPT5e8a0aqlVTjDtNGiNWIVGBBAPG0Rjzezl84D2xRMoV5c4xeLIPDQbUtm24utBQdR6CdPEi31CSRWVa1IZ/Dnb/YbstzPJ0zPAAMUoUuO+XUWV+odkDnpy3eXBBrdlyJEtMAqOP0xbosJDcYVGhaPvzTRf4+trRREGqJWMGrGqhYnZRiSivKXjPjo5MAdDGAhrxeT7Fm+geZxUpdsnRq02zUwnJx2s9pc0BGaDj66z5A+qF19l/ZdAxOE115bcB/2MGjk1DvKcE8iXlDyrubEgh/vH3PhmZkDVwGiSN68YPt pNgIASvI kBotG30GSQjNBmoCp/7Ml+Ha5SFUFl4bqGU2qo2ANs0yYyAdasmFmxmQLouXtzJypucSfmme3MRkBVySQgIsFC+pa5lhxXK4JbEO9KiQMIUCAWb7MFCQ5tlN5N2hIQTfggmFa5XtWGp4/UnB0n7E5mct0AnTJ2RGKy35G61dUH/m/Uah9aFv7Kar/fifvS3ybPW3EcC9WY1q1ZDB+WDpD75vqlYfFawZRmUHhWndLujVcbeypsUP84yRBTixwQmDNDox6YuPymgC+OpFJcJ6KJjX+bUv00MZrmGVCXNUjrNoxr8rpZmeN+9dDARhvf+Bam9sfdQkx7ew+UodrQ35wIzqiTNKR634lxJjnRcj+caw4LcT0Bf22G/0k3P5sQFVUSXelFKRFFsbHOyY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13/02/2025 04:09, Anshuman Khandual wrote: > DEBUG_WX selects PTDUMP_CORE without even ensuring that the given platform > implements GENERIC_PTDUMP. This problem has been latent until now, as all > the platforms subscribing ARCH_HAS_DEBUG_WX also subscribe GENERIC_PTDUMP. > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Reviewed-by: Steven Price > --- > mm/Kconfig.debug | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index 41a58536531d..a51a1149909a 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -186,6 +186,7 @@ config ARCH_HAS_DEBUG_WX > config DEBUG_WX > bool "Warn on W+X mappings at boot" > depends on ARCH_HAS_DEBUG_WX > + depends on GENERIC_PTDUMP > depends on MMU > select PTDUMP_CORE > help