linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: christophe.leroy@csgroup.eu,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: Make DEBUG_WX depdendent on GENERIC_PTDUMP
Date: Thu, 13 Feb 2025 11:23:07 +0000	[thread overview]
Message-ID: <0141324f-19e9-4e40-9500-df3bc140f2d0@arm.com> (raw)
In-Reply-To: <20250213040934.3245750-3-anshuman.khandual@arm.com>

On 13/02/2025 04:09, Anshuman Khandual wrote:
> DEBUG_WX selects PTDUMP_CORE without even ensuring that the given platform
> implements GENERIC_PTDUMP. This problem has been latent until now, as all
> the platforms subscribing ARCH_HAS_DEBUG_WX also subscribe GENERIC_PTDUMP.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  mm/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 41a58536531d..a51a1149909a 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -186,6 +186,7 @@ config ARCH_HAS_DEBUG_WX
>  config DEBUG_WX
>  	bool "Warn on W+X mappings at boot"
>  	depends on ARCH_HAS_DEBUG_WX
> +	depends on GENERIC_PTDUMP
>  	depends on MMU
>  	select PTDUMP_CORE
>  	help



  reply	other threads:[~2025-02-13 11:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13  4:09 [PATCH 0/4] mm: Rework generic PTDUMP configs Anshuman Khandual
2025-02-13  4:09 ` [PATCH 1/4] configs: Drop GENERIC_PTDUMP from debug.config Anshuman Khandual
2025-02-13 11:23   ` Steven Price
2025-02-13  4:09 ` [PATCH 2/4] mm: Make DEBUG_WX depdendent on GENERIC_PTDUMP Anshuman Khandual
2025-02-13 11:23   ` Steven Price [this message]
2025-02-13  4:09 ` [PATCH 3/4] mm: Make GENERIC_PTDUMP dependent on MMU Anshuman Khandual
2025-02-13  7:30   ` Christophe Leroy
2025-02-13 11:23   ` Steven Price
2025-02-14  6:49     ` Anshuman Khandual
2025-02-13  4:09 ` [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE Anshuman Khandual
2025-02-13  7:38   ` Christophe Leroy
2025-02-14  7:17     ` Anshuman Khandual
2025-02-24 11:12       ` Christophe Leroy
2025-02-13 11:23   ` Steven Price
2025-02-13 11:49     ` Christophe Leroy
2025-02-14  7:26       ` Anshuman Khandual
2025-02-24 11:13         ` Christophe Leroy
2025-02-14  7:19     ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0141324f-19e9-4e40-9500-df3bc140f2d0@arm.com \
    --to=steven.price@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox