From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8030C2B9F8 for ; Tue, 25 May 2021 07:52:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 344D761401 for ; Tue, 25 May 2021 07:52:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 344D761401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E1B46B006C; Tue, 25 May 2021 03:52:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 891D56B006E; Tue, 25 May 2021 03:52:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70B2B6B0070; Tue, 25 May 2021 03:52:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 3E91A6B006C for ; Tue, 25 May 2021 03:52:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C20E4181AEF39 for ; Tue, 25 May 2021 07:52:35 +0000 (UTC) X-FDA: 78178986270.24.E14179C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 82286C0042C4 for ; Tue, 25 May 2021 07:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621929154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHZzxf+ytlYjm3d6c5CzbDAImZNM1V4d4EFj0tNGWZg=; b=SPN3xcznSxTjn28HDc8a2npMjeBS7ODfiRlYXWbRbAIcmayFsXMZaHSYhUuL9wWKxxTNS/ kQYPX9mERtn9C39BEZSJpEdb1RhuQEpF/WRq7UNFrzrOJStxHAcychb1jMXlrr8x7xR/xC u1rzMGXCwWsVUTbXge7O3uEjWxs2sas= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-Kq3MRxILNnaIDdJvPWKTGg-1; Tue, 25 May 2021 03:52:30 -0400 X-MC-Unique: Kq3MRxILNnaIDdJvPWKTGg-1 Received: by mail-wr1-f72.google.com with SMTP id h104-20020adf90710000b029010de8455a3aso14189141wrh.12 for ; Tue, 25 May 2021 00:52:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nHZzxf+ytlYjm3d6c5CzbDAImZNM1V4d4EFj0tNGWZg=; b=ToTHohNYrwtkBL8Xg82VQIubBj0lc0s3FnnELVizG7Owq2qQoSH7XfgsOoi+EiazHR L0465YCFQNW9zx5gLr8PyhcYD4iVs+djD7J9l3V8kXgM6udMvUdbrkNrxF4zFBhJUULt NiIXZT1D0uf8ufqIGJj/d/F/uOvFGJ+KKSnNd7iMu5fCJUQGdzCi3Dw/qnM91e5o6imA Thz7ya1213g6389AEbnpmiVv5E08+xyw/Yi2gLG2hHXyaKXf1gXHALHYKO9rGkLh/nhh zSSal1LIBYtOB/jeD/uTqJ065L6l/49/Z2VAb4RlmHNppCGAqXwU+OkDWE7yMot/SwxV bktQ== X-Gm-Message-State: AOAM532zcFxN1w4PUIRQ9XQgpfcH7hsmgj1z1bNs7eAFYo4+LAYxYBkf RcEaEuUg1n0JmLnImFxmGn0g21qgqShfkQAXGXdO47HrdlOITidLt4+8EWVG3/glnnUytppjx+/ dl3SYs2tYlbg= X-Received: by 2002:adf:ee86:: with SMTP id b6mr18948546wro.53.1621929149476; Tue, 25 May 2021 00:52:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxHwIj/9rOfNndM5jJAWHzg448cYs0giNs6SHGBNZGGeed+ecAft4vmApavUXRAVUkm647vQ== X-Received: by 2002:adf:ee86:: with SMTP id b6mr18948527wro.53.1621929149216; Tue, 25 May 2021 00:52:29 -0700 (PDT) Received: from ?IPv6:2003:d8:2f38:2400:62f4:c5fa:ba13:ac32? (p200300d82f38240062f4c5faba13ac32.dip0.t-ipconnect.de. [2003:d8:2f38:2400:62f4:c5fa:ba13:ac32]) by smtp.gmail.com with ESMTPSA id d9sm14504444wrx.11.2021.05.25.00.52.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 00:52:28 -0700 (PDT) Subject: Re: [PATCH 2/5] mm/sparse: free section usage memory in case populate_section_memmap failed To: Dong Aisheng , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, dongas86@gmail.com, Andrew Morton References: <20210517112044.233138-1-aisheng.dong@nxp.com> <20210517112044.233138-3-aisheng.dong@nxp.com> From: David Hildenbrand Organization: Red Hat Message-ID: <01356cc7-61c3-fb15-1c85-939b6366a636@redhat.com> Date: Tue, 25 May 2021 09:52:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210517112044.233138-3-aisheng.dong@nxp.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 82286C0042C4 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SPN3xczn; spf=none (imf22.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: j5k47efxcwn7u7d7izbro4g7bjcgwzky X-HE-Tag: 1621929149-650580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.05.21 13:20, Dong Aisheng wrote: > Free section usage memory in case populate_section_memmap failed. > We use map_count to track the remain unused memory to be freed. > > Cc: Andrew Morton > Signed-off-by: Dong Aisheng > --- > mm/sparse.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 7ac481353b6b..98bfacc763da 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -549,12 +549,14 @@ static void __init sparse_init_nid(int nid, unsigned long pnum_begin, > __func__, nid); > pnum_begin = pnum; > sparse_buffer_fini(); > + memblock_free_early(__pa(usage), map_count * mem_section_usage_size()); > goto failed; > } > check_usemap_section_nr(nid, usage); > sparse_init_one_section(__nr_to_section(pnum), pnum, map, usage, > SECTION_IS_EARLY); > usage = (void *) usage + mem_section_usage_size(); > + map_count--; > } > sparse_buffer_fini(); > return; > Why care about optimizing something that literally never fails, and if it would fail, leave the system in a sub-optimal, mostly unusable state? -- Thanks, David / dhildenb