From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BDFC5AE5A for ; Wed, 28 Aug 2024 15:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1156E6B0083; Wed, 28 Aug 2024 11:31:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C5F86B0085; Wed, 28 Aug 2024 11:31:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECF706B0088; Wed, 28 Aug 2024 11:31:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CDF7F6B0083 for ; Wed, 28 Aug 2024 11:31:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 48644160328 for ; Wed, 28 Aug 2024 15:31:38 +0000 (UTC) X-FDA: 82502043876.03.C8BB0DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id D8E2B4002A for ; Wed, 28 Aug 2024 15:31:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QHe4DrwU; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724859008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xOPKOsg5jv8jg6VD4xEjJRB23KAp6IEXnaWD2DP6S5o=; b=PJmdMGQBRo9gTxG0Y3MdFA2c4CW+g47G+YwaEsUPWs8CYXO3HMaszrRo0mS3TO+vqJtca9 OME2xBlWZK9tK5Nq+tr8G1yiIxtnlT2eN4wdW16Ym8k5kkIXj4th/X3xEdC4915ly0BSR6 PaOja8+AMyDgqJtNyHZXeMhPynKecxM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724859008; a=rsa-sha256; cv=none; b=ITrr7fD5QGlsbY7bZ8JSHvdMI8gfwS2wMv0na7KHa2OLF7JQvvUoXfWQWysZJADYU7bHd2 tqSxd5HjF93dKOFZmnYCo/otgu5r7WBy8P0ZDSme2Yi7Qzzbt5j3oL9N9LqSKBr/fr/nhJ ODSYG0FIG5KPlS3rMNDZNYXd0uerATc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QHe4DrwU; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724859095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xOPKOsg5jv8jg6VD4xEjJRB23KAp6IEXnaWD2DP6S5o=; b=QHe4DrwUQipKJT1Y5nAoL8Gv/JwmSYPkHmr0rDETsU//0TXtdze5Q4irf/3Jkp1RZCvlv6 lazC7qQZSnB9kkgFtsZiHI8ZnxVRPDfgDZUBHH4llF/UNPZkHcWWRCAcE0Lj8qbQPZLGVi kuv/feKYSbcRERU9ENFkQQr89cfCEp0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-eRW_yFGTPrWB53Z-27Itmw-1; Wed, 28 Aug 2024 11:31:32 -0400 X-MC-Unique: eRW_yFGTPrWB53Z-27Itmw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-429e937ed39so63853185e9.1 for ; Wed, 28 Aug 2024 08:31:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724859091; x=1725463891; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xOPKOsg5jv8jg6VD4xEjJRB23KAp6IEXnaWD2DP6S5o=; b=w5+pwybzvRxhTtv2V6lgYW0advgIhabF1Rlon5Lgl2aDpdxjBxM1rpXh7+t2MM3e4j Xi38jiDBw5QenbPahjQZyxTe9xTLDewdNdrWDAtrXoW5pF8fyMJw4RRSbtXd9KU1a7wx bn9NDAxDNQGSQTDQGtWhI5qsXupSEgnosOjQKdtsYBh7trIo3fZ0zQe6efDIHZBYQzHz fhIxesuVHkDCsE/gu4nPsKZ+zohrdKRg2S77/GN6q3VZ8no80Xhk8Mv9XvblyLZ+uMB8 862frCEp1hUv86vL9gBVgJ70H0Ue7QL4DBOhCarD/l3HWNStuJsLOOIUkiZlHoCzjiCd yUTg== X-Forwarded-Encrypted: i=1; AJvYcCWPfmkWPwmrIvysJ3PBV6FMADzAWgAZgSYpPKBCFkTyBml4CZ6PjjD+apgIWVYpfjdHUJ37hMU2+w==@kvack.org X-Gm-Message-State: AOJu0Yyc7TXaPCe61Dl1+iz3/S43H6smfLQf214BIkrWSUDHBoFhzFmm fZkzgrvc29Lj0CSNXsX2zbxtqiKcYjc0WIhfuT02wGbHjF7pqhAqxuxQWfKep5mY3u11uTC3LGC Xmk6tDOjnmippNdT35ww6MW7GV6EMtTlaZYu9V7fouoUodfV2 X-Received: by 2002:a05:600c:3b97:b0:426:5c36:207c with SMTP id 5b1f17b1804b1-42bb27a9c77mr76435e9.25.1724859091172; Wed, 28 Aug 2024 08:31:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6XqulJHuzc87ef1Sa38B+B4vXhV59jcrORNIKvdBRzM+hIg3NDU7pbYLM5WafNDZhZwqCXg== X-Received: by 2002:a05:600c:3b97:b0:426:5c36:207c with SMTP id 5b1f17b1804b1-42bb27a9c77mr75985e9.25.1724859090191; Wed, 28 Aug 2024 08:31:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:1700:6b81:27cb:c9e2:a09a? (p200300cbc70617006b8127cbc9e2a09a.dip0.t-ipconnect.de. [2003:cb:c706:1700:6b81:27cb:c9e2:a09a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb01d3029sm772145e9.42.2024.08.28.08.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2024 08:31:29 -0700 (PDT) Message-ID: <012789cd-90d0-4b3b-b48e-16990ee40fc4@redhat.com> Date: Wed, 28 Aug 2024 17:31:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/19] mm: Mark special bits for huge pfn mappings when inject To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-4-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240826204353.2228736-4-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D8E2B4002A X-Stat-Signature: j7bazg9zhmpzxoqy13n4nt7d9ebgpijk X-HE-Tag: 1724859095-967101 X-HE-Meta: U2FsdGVkX1+MhUfn9uPy49psf9wvPA1k2krWCECA6+fHmr+Tk2D3UAo0cxT1Zb0ywQ+FNtQWs3aTs8Bsx1W3/1oZmOFtI0h+0YncpCetjXX36YhTHQIGDX3810GnI2wI9lc99xhz3tXAJhMoCPZfuPXH3/e5bfbn0+5qSR2dATyQEB95h3IK31yA+ZSRgn3cSX+EacqxbHkBYBnE9inDQ30ud+diRETh7gf7GaAzfVNK4HTJbgXl6hcza9c2Zk+Cmo3SM4ZvVU706r/vPOyMcHKdIOcWAHU/dMlDYsprpYiA9Td88Z/nEbqCY1+HxlgQhFQfUCEhaZrZJqhe70lLCq8C+C+ZBysb86FHYQDQYDA3vvnoUCzWhIcXFiOTzC2fr0/btKp1jMIi7aQkYm1+rSMKMZ9wzbAT+LU2wKjLGWVoghJTEcj4gx3PLTKBaBzQEBxKaY6dE9HvDK4R1GaKGFUrKq9rHhfmeNJurbvGrkMKAPaE/rSn/h1yJZdoZ23OmMZ1MZBRX3KrQHt9xcHu0Vye0gpFPNVapVbnxkmFt2zLbHQZ5Or8IgZcwd4yoUC45WGbfE6QdlFTK1vH+ds48/CUBbc+eKj8zW0FzPM0uMRi8GQz0ggUxDsbrZc5J3sTK2mu+10/ZOZ7g05hwEJ81bb2Hx4TUuWUdZLBYj+bEgqvG9Igzu2SAbCWfygU8TTTleeY/AqGkTS9sUupCYH1huv8mIJPHLQUIPE5XkDCF3L3dHcPIt1kpNTzOTfWyUahqpL34pc56XM+cElLWE0OU8YFGVXraFVbDJ4sR8SCW5WTLyKJkFoCDY/UnqmtVHxrF7vDLi+yBvKatkIGcaBuv9KLDwcmI2U2PRDJHrvGOjNhXa/urdtPWLGvk8o6wF8TyJC/v2FHSBfNRLRyPER+JQFgwIDeePCHNmRPjoK7qpWOyX1CuvukDDS3Ve3GAj35HraDwiT4Nfjfdhm3Miy 49vRb5vf KiZGdFCuXrvM3bXqoNyfvO3+MyDdLrUZYozOqpkyZLFh1udc1XFrZE9sEnPO/5gcZGUl2kRDts2B+PjDG6h0SIG4C9O/9ROJWgAhFuoGmvMRhuDg7COStohGVChA/upRgoIfVW37l13z+qXxynrDIOpDUI9ZCRs+evDtnR3b8veIR4lXgKFwIQ6zDmxQKzU9WG3uLlEFPq56nYQPGzDJDCkRAPT+IrS5F7EoVr1cexWgJ0k30+c3MyGnbTHsIn8gJoPRiRX/1F+BCMoldeqEutqSs7UemtXGSGFda3vtb9iJMouZvTMWXYb7lD/uyrEkX3h0sLv5wYbISSf0gPaC31/CMosFN1Ub0YbghMaSxA7TfaR2GYqVg9F2vq6q58bo6T/Cc7wPoUEkLyQB+xbl+uV5XFqb+LqiwnuL9rpnlsmPgQfeqhvanTUQ2frvAuOiPGiY3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.08.24 22:43, Peter Xu wrote: > We need these special bits to be around on pfnmaps. Mark properly for > !devmap case, reflecting that there's no page struct backing the entry. > > Reviewed-by: Jason Gunthorpe > Signed-off-by: Peter Xu > --- > mm/huge_memory.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 3f74b09ada38..dec17d09390f 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1346,6 +1346,8 @@ static void insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > entry = pmd_mkhuge(pfn_t_pmd(pfn, prot)); > if (pfn_t_devmap(pfn)) > entry = pmd_mkdevmap(entry); > + else > + entry = pmd_mkspecial(entry); > if (write) { > entry = pmd_mkyoung(pmd_mkdirty(entry)); > entry = maybe_pmd_mkwrite(entry, vma); > @@ -1442,6 +1444,8 @@ static void insert_pfn_pud(struct vm_area_struct *vma, unsigned long addr, > entry = pud_mkhuge(pfn_t_pud(pfn, prot)); > if (pfn_t_devmap(pfn)) > entry = pud_mkdevmap(entry); > + else > + entry = pud_mkspecial(entry); > if (write) { > entry = pud_mkyoung(pud_mkdirty(entry)); > entry = maybe_pud_mkwrite(entry, vma); Acked-by: David Hildenbrand -- Cheers, David / dhildenb