From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx185.postini.com [74.125.245.185]) by kanga.kvack.org (Postfix) with SMTP id 7967B6B005A for ; Tue, 7 Aug 2012 09:20:23 -0400 (EDT) Received: from epcpsbgm2.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8D002WCZPVOKE0@mailout1.samsung.com> for linux-mm@kvack.org; Tue, 07 Aug 2012 22:20:21 +0900 (KST) Received: from AMDC159 ([106.116.147.30]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8D00FROZPOI580@mmp1.samsung.com> for linux-mm@kvack.org; Tue, 07 Aug 2012 22:20:21 +0900 (KST) From: Marek Szyprowski References: <1344171029-24804-1-git-send-email-aaro.koskinen@iki.fi> In-reply-to: <1344171029-24804-1-git-send-email-aaro.koskinen@iki.fi> Subject: RE: [PATCH] ARM: dma-mapping: fix incorrect freeing of atomic allocations Date: Tue, 07 Aug 2012 15:20:11 +0200 Message-id: <011c01cd749f$620a80d0$261f8270$%szyprowski@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: pl Sender: owner-linux-mm@kvack.org List-ID: To: 'Aaro Koskinen' , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Hi Aaro, On Sunday, August 05, 2012 2:50 PM Aaro Koskinen wrote: > Commit e9da6e9905e639b0f842a244bc770b48ad0523e9 (ARM: dma-mapping: > remove custom consistent dma region) changed the way atomic allocations > are handled. However, arm_dma_free() was not modified accordingly, and > as a result freeing of atomic allocations does not work correctly when > CMA is disabled. Memory is leaked and following WARNINGs are seen: > > [ 57.698911] ------------[ cut here ]------------ > [ 57.753518] WARNING: at arch/arm/mm/dma-mapping.c:263 arm_dma_free+0x88/0xe4() > [ 57.811473] trying to free invalid coherent area: e0848000 > [ 57.867398] Modules linked in: sata_mv(-) > [ 57.921373] [] (unwind_backtrace+0x0/0xf0) from [] > (warn_slowpath_common+0x50/0x68) > [ 58.033924] [] (warn_slowpath_common+0x50/0x68) from [] > (warn_slowpath_fmt+0x30/0x40) > [ 58.152024] [] (warn_slowpath_fmt+0x30/0x40) from [] > (arm_dma_free+0x88/0xe4) > [ 58.219592] [] (arm_dma_free+0x88/0xe4) from [] > (dma_pool_destroy+0x100/0x148) > [ 58.345526] [] (dma_pool_destroy+0x100/0x148) from [] > (release_nodes+0x144/0x218) > [ 58.475782] [] (release_nodes+0x144/0x218) from [] > (__device_release_driver+0x60/0xb8) > [ 58.614260] [] (__device_release_driver+0x60/0xb8) from [] > (driver_detach+0xd8/0xec) > [ 58.756527] [] (driver_detach+0xd8/0xec) from [] > (bus_remove_driver+0x7c/0xc4) > [ 58.901648] [] (bus_remove_driver+0x7c/0xc4) from [] > (sys_delete_module+0x19c/0x220) > [ 59.051447] [] (sys_delete_module+0x19c/0x220) from [] > (ret_fast_syscall+0x0/0x2c) > [ 59.207996] ---[ end trace 0745420412c0325a ]--- > [ 59.287110] ------------[ cut here ]------------ > [ 59.366324] WARNING: at arch/arm/mm/dma-mapping.c:263 arm_dma_free+0x88/0xe4() > [ 59.450511] trying to free invalid coherent area: e0847000 > [ 59.534357] Modules linked in: sata_mv(-) > [ 59.616785] [] (unwind_backtrace+0x0/0xf0) from [] > (warn_slowpath_common+0x50/0x68) > [ 59.790030] [] (warn_slowpath_common+0x50/0x68) from [] > (warn_slowpath_fmt+0x30/0x40) > [ 59.972322] [] (warn_slowpath_fmt+0x30/0x40) from [] > (arm_dma_free+0x88/0xe4) > [ 60.070701] [] (arm_dma_free+0x88/0xe4) from [] > (dma_pool_destroy+0x100/0x148) > [ 60.256817] [] (dma_pool_destroy+0x100/0x148) from [] > (release_nodes+0x144/0x218) > [ 60.445201] [] (release_nodes+0x144/0x218) from [] > (__device_release_driver+0x60/0xb8) > [ 60.634148] [] (__device_release_driver+0x60/0xb8) from [] > (driver_detach+0xd8/0xec) > [ 60.823623] [] (driver_detach+0xd8/0xec) from [] > (bus_remove_driver+0x7c/0xc4) > [ 61.013268] [] (bus_remove_driver+0x7c/0xc4) from [] > (sys_delete_module+0x19c/0x220) > [ 61.203472] [] (sys_delete_module+0x19c/0x220) from [] > (ret_fast_syscall+0x0/0x2c) > [ 61.393390] ---[ end trace 0745420412c0325b ]--- > > The patch fixes this. > > Signed-off-by: Aaro Koskinen Thanks for spotting this issue. I've applied it to my fixes branch. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org